Revise 'About' Section #426
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -582,8 +583,28 @@ test('inject ChapterDisplay', async () => { | |||
| } | |||
| } | |||
|
|
|||
| const translationReference = referenceFactory.build() | |||
| const intertextReference = referenceFactory.build() | |||
| const translationReference = referenceFactory.build( | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }, | ||
| } | ||
| ) | ||
| const intertextReference = referenceFactory.build( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| Annie Attia, Sona Eypper, and Henry Stadhouders (as external | ||
| collaborators). | ||
| <p /> | ||
| <p> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -42,3 +42,20 @@ export default class MarkupService { | |||
| return this.referenceInjector.injectReferencesToMarkup(parts) | |||
| } | |||
| } | |||
|
|
|||
| export class CachedMarkupService extends MarkupService { | |||
| fromString(text: string): Bluebird<readonly MarkupPart[]> { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| import Markup from 'markup/ui/markup' | ||
| import MarkupService from 'markup/application/MarkupService' | ||
|
|
||
| import afoRegisterCover from 'about/ui/static/afoRegister.png' | ||
|
|
||
| export default function AboutProject( | ||
| export default function AboutBibliography( |
There was a problem hiding this comment.
Function AboutBibliography has 308 lines of code (exceeds 25 allowed). Consider refactoring.
| export default function AboutProject( | ||
| markupService: MarkupService | ||
| ): JSX.Element { | ||
| export default function AboutCorpus(markupService: MarkupService): JSX.Element { |
There was a problem hiding this comment.
Function AboutCorpus has 91 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -21,44 +21,72 @@ import smithdt1 from 'about/ui/static/smithdt1.jpg' | |||
| import strassmaier from 'about/ui/static/strassmaier.jpg' | |||
| import strassmaiercopies from 'about/ui/static/strassmaiercopies.jpg' | |||
|
|
|||
| export default function AboutProject( | |||
| export default function AboutFragmentarium( | |||
There was a problem hiding this comment.
Function AboutFragmentarium has 733 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 89b6840 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.4% (75% is the threshold). This pull request will bring the total coverage in the repository to 90.9% (0.0% change). View more on Code Climate. |
No description provided.