feature(wallet-mobile): Dapp explorer UI #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
commented
Apr 11, 2024
| import {useHasWallets} from './yoroi-wallets/hooks' | ||
|
|
||
| const Tab = createBottomTabNavigator<WalletTabRoutes>() | ||
| const WalletTabNavigator = () => { | ||
| const strings = useStrings() | ||
| const {colors} = useStyles() | ||
| const wallet = useSelectedWallet() | ||
| const initialRoute = isHaskellShelley(wallet.walletImplementationId) ? 'staking-dashboard' : 'history' | ||
| const initialRoute = /* isHaskellShelley(wallet.walletImplementationId) ? 'staking-dashboard' :*/ 'history' |
stackchain
commented
Apr 11, 2024
| @@ -117,7 +115,7 @@ const WalletTabNavigator = () => { | |||
| )} | |||
| </Tab.Screen> | |||
|
|
|||
| {isHaskellShelley(wallet.walletImplementationId) && ( | |||
| {/* {isHaskellShelley(wallet.walletImplementationId) && ( | |||
There was a problem hiding this comment.
check the feature flag
stackchain
commented
Apr 11, 2024
There was a problem hiding this comment.
I'm guessing these icons are mocked for now, later they will come from the configuration manageR?
stackchain
commented
Apr 11, 2024
| @@ -0,0 +1,16 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
import * React... for all screens
stackchain
commented
Apr 11, 2024
| ...initialState, | ||
| }) | ||
|
|
||
| useEffect(() => { |
|
@michaeljscript looks solid, basically some adjust to import react, and consume react hooks with React.use bringing it in, please adjust the feature flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.