This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
IR-2549: create static resource using project name from request data #10353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jose-galvan
requested review from
jonathan-casarrubias,
HexaField,
hanzlamateen and
aditya-mitra
|
@HexaField can you please have a look of this |
HexaField
suggested changes
Jun 10, 2024
There was a problem hiding this comment.
I didn't realise there was already for a task for this, aditya did it here based off the PR I have that changes a lot of the backend services
https://github.com/EtherealEngine/etherealengine/pull/10354/files
packages/ui/src/components/editor/panels/Files/container/index.tsx
Outdated
Show resolved
Hide resolved
HexaField
suggested changes
Jun 10, 2024
packages/editor/src/components/assets/FileBrowser/FileBrowserContentPanel.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When static resources are uploaded through the file browser service the project field is assigned by splitting the file path
and using the first segment after project. i.e for a file with the path
projects/default-project/drop-shadow.pngthe project would be
default-project, however this approach doesn't work for multi-tenancy projects where the first segment of the path afterprojects/only identifies the account name. To support both single-tenant and multi-tenancy projects the project name is now attached to the request, rather than being extracted from the file path.Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps