This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fix xrui pointer input & improved follow camera #10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamMazerIR
commented
Jun 27, 2024
… to no longer calling setTargetCameraRotation() twice)
… in the orbit camera
speigg
approved these changes
Jun 28, 2024
speigg
changed the title
…herealengine into fix-xrui-pointer-input
…InteractableComponent
DanielBelmes
approved these changes
Jul 2, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jul 2, 2024
* dev: (21 commits) show grid lines by default in studio (#10500) Fix xrui pointer input & improved follow camera (#10471) feat: zendesk widget in viewer app & custom button (#10494) fix the download project button (#10499) studio: titles of some elements on components are not properly displayed (camelcased or lowercased) (#10491) fix slider ui (#10490) add point light name (#10495) upload from assets panel (#10487) IR-2838-Studio-Click-Selection-Regression (#10479) Add better error to file-browser patch (#10489) Fixed issue with HLS streams not playing (#10485) IR-2810: Redesign Compress Menu (#10469) studio: fix context menu (#10475) fix(IR-2799): fix feature flags state (#10453) fix WebXR (#10484) IR-2727: Zendesk authentication (#10452) Assets must populate from all projects you have perms for (#10409) image convert modal (#10466) clean out userdata after initializing ecs data from gltfs (#10470) Material IO Fixes (#10480) ... # Conflicts: # packages/common/src/utils/getAllStringValueNodes.ts # packages/engine/src/avatar/systems/AvatarCameraInputSystem.ts # packages/spatial/src/camera/components/FollowCameraComponent.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
XRUI pointer input changes, as well as orbit/follow camera work
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps