-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] support minimonkey model #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @white2018 , I think most of the changes look good. Can you share a screenshot of the evaluation result using this model? Then I think it will be good to merge.
Hi @kcz358 , I run this evaluation code with mmstar dataset. Here is the screeshot as follows: |
@white2018 , the result looks good, can you do a final lint to pass the format checking? Current the workflow has failed. You can do it by python3 -m pip install pre-commit
pre-commit install
pre-commit run --all-files And simply commit the formatted files would be good. Thank you! |
@kcz358 All right! It is done. Thanks a lot |
Thank you for your contribution. Merging this PR now. |
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
Thank you for your contributions!
This PR intends to enhance the functionality of lmms-eval by supporting MiniMonkey model in Monkey series, which is not covered in latest version.