Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Custom Roles Lagging Back When Spawning #428

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

TtroubleTT
Copy link

@TtroubleTT TtroubleTT commented Feb 4, 2025

Description

Describe the changes
Fixed custom roles lagging back by using spawned event.

What is the current behavior? (You can also link to an open issue here)
People spawning custom roles through custom role api spawn system will lag back because of using spawning event.

What is the new behavior? (if this is a feature change)
Fixes issue by using spawned event.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
N/A


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misfiy Misfiy merged commit 61c1c23 into ExMod-Team:dev Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants