Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand on the getContext() description #122

Merged
merged 11 commits into from
Mar 24, 2021
Merged

expand on the getContext() description #122

merged 11 commits into from
Mar 24, 2021

Conversation

andre-merzky
Copy link
Collaborator

Also fixes a couple of smaller issues.

@andre-merzky andre-merzky added the enhancement New feature or request label Mar 24, 2021
@andre-merzky andre-merzky self-assigned this Mar 24, 2021
Copy link
Collaborator

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! Just a few nits below.

specification.md Outdated
@@ -147,7 +151,7 @@ C](#bulk-submission).
## Layers

There are at least three major ways in which a job management API can be
used:
used
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would actually vote to keep the semicolon here since we are listing the three methods below it. If we want to remove the semicolon, I think the sentence should still end with some punctuation (i.e., .).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! :-)

@andre-merzky andre-merzky requested a review from SteVwonder March 24, 2021 21:32
@andre-merzky andre-merzky merged commit eecf4e1 into main Mar 24, 2021
@andre-merzky andre-merzky deleted the fix/get_context branch March 24, 2021 21:32
@hategan
Copy link
Collaborator

hategan commented Mar 24, 2021

What's the difference in purpose between getContext() and the existing getMetadata()?

@andre-merzky
Copy link
Collaborator Author

What's the difference in purpose between getContext() and the existing getMetadata()?

Good question - and in a different PR I wondered the same about getMessage() vs. getMetadata(). I would think we need only one of those.

@hategan
Copy link
Collaborator

hategan commented Mar 25, 2021

See a8dd4e9

Their description is very similar. It even says "metadata" for "getContext()". So I think this is a duplicate and should be reverted.

We can discuss "getMessage" separately, but, for reference, it is meant to convey error messages on failed states, so I do not think it should be removed.

@andre-merzky
Copy link
Collaborator Author

See a8dd4e9

Their description is very similar. It even says "metadata" for "getContext()". So I think this is a duplicate and should be reverted.

You are probably right, and I don't mind reverting. Sorry for the confusion.

We can discuss "getMessage" separately, but, for reference, it is meant to convey error messages on failed states, so I do not think it should be removed.

I opened a ticket at #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants