-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand on the getContext()
description
#122
Conversation
Co-authored-by: Stephen Herbein <[email protected]>
Co-authored-by: Stephen Herbein <[email protected]>
Co-authored-by: Stephen Herbein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM! Just a few nits below.
specification.md
Outdated
@@ -147,7 +151,7 @@ C](#bulk-submission). | |||
## Layers | |||
|
|||
There are at least three major ways in which a job management API can be | |||
used: | |||
used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would actually vote to keep the semicolon here since we are listing the three methods below it. If we want to remove the semicolon, I think the sentence should still end with some punctuation (i.e., .
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack! :-)
Thanks @SteVwonder Co-authored-by: Stephen Herbein <[email protected]>
…to fix/get_context
What's the difference in purpose between |
Good question - and in a different PR I wondered the same about |
See a8dd4e9 Their description is very similar. It even says "metadata" for "getContext()". So I think this is a duplicate and should be reverted. We can discuss "getMessage" separately, but, for reference, it is meant to convey error messages on failed states, so I do not think it should be removed. |
You are probably right, and I don't mind reverting. Sorry for the confusion.
I opened a ticket at #124. |
Also fixes a couple of smaller issues.