[HOLD] [$1000] Web - Closing Connect bank account drawer doesn't show the right URL @aneequeahmad

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open web app https://new.expensify.com/
2. Click on user icon on LHN to open setting.
3. Click on user's workspace.
4. Click on Connect bank account.
5. Click on close icon on top right.

Expected Result:

Url in browser should be r/reportId

Actual Result:

Url dispalyed as workspace/workspaceId or https://new.expensify.com/settings

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.99.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

bug_connect_bank.mov

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661274757727099

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mdneyazahmad]

@kbecciv can you please correct the reporter name. It is @aneequeahmad who reported this issue. Thank you!

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abekkala]

I was able to reproduce

[kbecciv]

@mdneyazahmad Corrected reporter

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Gonals]

Setting as external!

[parasharrajat]

There are similar issues like this. All of them seem to have the same root cause. #10989
#10991

There is no use in keeping them all open. Instead, we should merge the test cases. Also, this has been discussed somewhere in the past but can't find it. Navigation does not work with nested levels of Modals.

This should be held like other navigational issues and added to the Navigation project.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[JmillsExpensify]

Same same.

[chiragsalian]

Not overdue, still on HOLD

[JmillsExpensify]

Still on HOLD.

[JmillsExpensify]

Same as above.

[JmillsExpensify]

Alright, I'm circling back to this testing this issue. Here's my summary:

• We've deprecated the close button, so that's not longer a relevant part of the testing steps
• Further, when I go from the workspace editor, to bank account, and then back to workspace, the URLs are correct each time. I go from https://new.expensify.com/workspace/ and then to https://new.expensify.com/bank-account/ before going back to the right workspace URL.

Accordingly, I think we're good to go here and we'll pay out @aneequeahmad $250 for reporting.

[JmillsExpensify]

Putting this back on hold purely for internal prioritization. Still working through the remaining issues.

[JmillsExpensify]

Same

[chiragsalian]

not overdue, on hold

[JmillsExpensify]

@aneequeahmad I think we should be good on this issue, though can you test everything up to step 5 in the reproduction steps and confirm that all the URLs/paths are correct?

[JmillsExpensify]

At that point we can issue payment for reporting, since we've since fixed the underlying issue.

[aneequeahmad]

@JmillsExpensify i think we are good to close this issue as this issue doesn’t exist anymore in production.

[JmillsExpensify]

Please share a video confirming in the future. I'll approve this first one. Offer sent for reporting this one.

[aneequeahmad]

@JmillsExpensify Sure, ill share the video in future. Accepted the offer that you sent

[JmillsExpensify]

This one is all paid out. Thanks!