Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Wrong URL when Paypal.me payments page is closed @aneequeahmad #10991

Closed
kbecciv opened this issue Sep 14, 2022 · 41 comments
Closed

Web - Wrong URL when Paypal.me payments page is closed @aneequeahmad #10991

kbecciv opened this issue Sep 14, 2022 · 41 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Open settings page > Workspace > Manage members
  4. Select Invite member and close the page
  5. Open settings page > payments > Add payment method > Paypal
  6. Close the page

Expected Result:

Url should be r/reportId

Actual Result:

Url is /settings/payments

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.0.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-26.at.3.24.54.AM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661466607294799

View all open jobs on GitHub

@kbecciv kbecciv added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 14, 2022

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@parasharrajat
Copy link
Member

More info #10939 (comment)

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
@tjferriss tjferriss removed their assignment Sep 19, 2022
@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2022
@tjferriss
Copy link
Contributor

I was able to reproduce the first part where the wrong URL appeared after closing the Invite member page. I was not able to reproduce the issue with the Paypal page. As mentioned above it looks like there might be similar issues with different pages #10939 (comment).

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MonilBhavsar
Copy link
Contributor

I'm able to reproduce the issue, but looks like a duplicate issue. @parasharrajat could you please confirm. Thank you!

@parasharrajat
Copy link
Member

Yes, it should be tracked on #11111.

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Sep 22, 2022

Thank you! Then I think we can close this issue and other duplicate issues as well and keep only one tracking issue open

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@JmillsExpensify
Copy link

Going to close this issue in favor of #10939, which @parasharrajat has highlighted as having the same root cause.

@parasharrajat
Copy link
Member

Thanks @JmillsExpensify. Please add this to #11111

@JmillsExpensify
Copy link

Sorry, what does "add this to $11111" mean?

@parasharrajat
Copy link
Member

You can follow the same pattern and add the issue title and Steps so that we can track it.
#11111 was created to track these issues.
image

@JmillsExpensify
Copy link

Ok cool, same page. One concern though is that we need to keep track of the bug reporter. It looks like we're fine for the time being, in that I can add @aneequeahmad to the master issue since now reporter is currently listed there.

@parasharrajat
Copy link
Member

Yeah that is fine

@JmillsExpensify JmillsExpensify self-assigned this Jun 26, 2023
@MonilBhavsar
Copy link
Contributor

Thank you! I think it is fair to bump to this to weekly then

@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Jul 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2023
@JmillsExpensify
Copy link

Still working on the testing issues.

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 11, 2023
@JmillsExpensify
Copy link

Still trying to make time. Low priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 25, 2023
@JmillsExpensify
Copy link

Same

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@MonilBhavsar
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2023
@JmillsExpensify
Copy link

We're deprecating Paypal, so I'm going to issue payment for reporting and then we can close this issue.

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@JmillsExpensify
Copy link

@aneequeahmad I send you a report offer for this Upwork job: https://www.upwork.com/jobs/~01832a474eb99777e9. Let me know when you've accepted.

@aneequeahmad
Copy link
Contributor

@JmillsExpensify i have accepted the offer. Thank you for inviting

@aneequeahmad
Copy link
Contributor

@JmillsExpensify any update on this issue ? Lets close this one.
Also, what about other navigation issues that i reported ? Should i test them all ? If they are reproducible or not

@melvin-bot melvin-bot bot added the Overdue label Oct 4, 2023
@MonilBhavsar
Copy link
Contributor

We're closing this issue as Paypal is being deprecated. Which other issue is being referred here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@aneequeahmad
Copy link
Contributor

@MonilBhavsar im talking about other navigation issues that are listed in navigation project.

@aneequeahmad
Copy link
Contributor

@JmillsExpensify i accepted the offer its been 2 weeks. Please accept it and lets close this offer. Thanks

@JmillsExpensify
Copy link

@JmillsExpensify any update on this issue ? Lets close this one. Also, what about other navigation issues that i reported ? Should i test them all ? If they are reproducible or not

Yes please test them all and confirm if they are still reproducible or not.

@JmillsExpensify
Copy link

@JmillsExpensify i accepted the offer its been 2 weeks. Please accept it and lets close this offer. Thanks

Paid out.

@JmillsExpensify JmillsExpensify changed the title [HOLD] Web - Wrong URL when Paypal.me payments page is closed @aneequeahmad Web - Wrong URL when Paypal.me payments page is closed @aneequeahmad Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants