Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] Web - Wrong URL if participant detail page in default room is closed @aneequeahmad #10989

Closed
kbecciv opened this issue Sep 14, 2022 · 66 comments
Closed

[HOLD] Web - Wrong URL if participant detail page in default room is closed @aneequeahmad #10989

kbecciv opened this issue Sep 14, 2022 · 66 comments
Assignees
@JmillsExpensify
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com and log in with any account
  2. Click on any default room (workspace room)
  3. Click on header to open details page > settings > go back by clicking back button >
  4. Click on members > any member.
  5. Click on close button

Expected Result:

URL should be r/reportId

Actual Result:

URL is /r/reportId/details

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.0.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-26.at.2.20.23.AM.mov

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661463319371319

View all open jobs on GitHub
@kbecciv kbecciv added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 14, 2022

Triggered auto assignment to @maddylewis (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Sep 14, 2022
@maddylewis maddylewis removed their assignment Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 14, 2022

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat parasharrajat mentioned this issue Sep 15, 2022
Closed
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@parasharrajat
Copy link
Member

More info #10939 (comment)

@grgia
Copy link
Contributor

grgia commented Sep 15, 2022

Setting to external. Note similar issues in comment above!

@grgia grgia added External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. labels Sep 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@grgia grgia added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Sep 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
This was referenced Sep 19, 2022
Closed
Closed
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

@JmillsExpensify
Copy link

Sorry ya'll. Missed this in the shuffle. Upwork job is here: https://www.upwork.com/jobs/~01b51a6599d08a678a

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

@JmillsExpensify
Copy link

@aneequeahmad Would you mind re-testing this issue, including video, and comment confirming whether the issue still persists?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@aneequeahmad
Copy link
Contributor

@JmillsExpensify This issue isn’t reproducible. Fixed in production. I think time to close this issue.

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@JmillsExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Oct 9, 2023

@JmillsExpensify 12 days overdue now... This issue's end is nigh!

@JmillsExpensify
Copy link

@aneequeahmad similar to your other reported issues, can you please retest this issue with the exception of the last step and confirm that all is good? At that point we can get you paid for reporting what we've since fixed.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@aneequeahmad
Copy link
Contributor

@JmillsExpensify this issue is fixed and doesn't exist in production. We are good to close this and issue payment. Thanks

@JmillsExpensify
Copy link

Can you please leave a video confirming? Thanks

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

Once we get a final test confirmation, we can close this one out.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

Still waiting on final test confirmation

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
@JmillsExpensify JmillsExpensify added Monthly KSv2 and removed Daily KSv2 labels Oct 24, 2023
@aneequeahmad
Copy link
Contributor

@JmillsExpensify Sorry for the delay. Here is the test confirmation video. All the Actions are performed as stated in repro steps here

WrongURL-Fix.mp4

@aneequeahmad
Copy link
Contributor

@JmillsExpensify lets close this issue as well confirmation video is attached. Thanks

@JmillsExpensify
Copy link

Nice, thank a bunch! That looks great. Closing this out on the Upwork side via payment.

@JmillsExpensify
Copy link

Offer sent. Please accept so I can issue payment.

@aneequeahmad
Copy link
Contributor

@JmillsExpensify accepted the offer. Thanks for mentioning

@JmillsExpensify
Copy link

All paid out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@JmillsExpensify @luacmartins @parasharrajat @jliexpensify @mountiny @aneequeahmad @grgia @maddylewis @kbecciv