Viewport jumping up #16443

gedu · 2023-03-23T12:11:52Z

Details

Added a new prop to ScreenWrapper which lets you ignore the change added in this ticket. This new prop will make the component use 100% height. So on screens that you don't want the components get moved up by the Keyboard in this case you will have to set lockHeight to true

Fixed Issues

$ #15270
PROPOSAL: #15270 (comment)

Tests

Open Send Money or Request Money screen
Click on the Currency Sign
The Keybard should open (if not open it clicking on the input)
Close it, and when going back the NumericPad should be in place
Going to the last screen the confirm button should avoid the keyboard

Verify that no errors appear in the JS console

Offline tests

Open Send Money or Request Money screen
Click on the Currency Sign
The Keybard should open (if not open it clicking on the input)
Close it, and when going back the NumericPad should be in place
Going to the last screen the confirm button should avoid the keyboard

QA Steps

Open Send Money or Request Money screen
Click on the Currency Sign
The Keybard should open (if not open it clicking on the input)
Close it, and when going back the NumericPad should be in place
Going to the last screen the confirm button should avoid the keyboard

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

noJumpingChrome.mp4

noJumpingSafari.mp4

Mobile Web - Chrome

noJumpingChromeMobile.mp4

Mobile Web - Safari

noJumpingSafariMobile.mp4

Desktop

noJumpingDesktop.mp4

iOS

noJumpingIphone.mp4

Android

noJumpingAndroid.mp4

MelvinBot · 2023-03-23T12:12:01Z

@hayata-suenaga @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2023-03-23T15:50:29Z

@gedu thank you for the quick PR. I was wondering if the original issue is the IOU amount page specific. as we discussed before, this jumping issue might exist on other screens, too.

gedu · 2023-03-23T18:24:50Z

@gedu thank you for the quick PR. I was wondering if the original issue is the IOU amount page specific. as we discussed before, this jumping issue might exist on other screens, too.

@hayata-suenaga
The issue is not specific to IOUXXX; it arises from the ScreenWrapper component listening to height changes and updating the maxHeight. Therefore, any screen that utilizes this component will have the "keyboard avoiding" feature turned on by default. Additionally, on iOS, there is a slight delay in the height change event, which causes the component to jump. In the example you linked we could lockHeight, and given the screen has a scroll view all will work, and because is using 100% height the next screen should look ok, I can give it a try later.

hayata-suenaga · 2023-03-23T22:37:16Z

@gedu thank you for the detailed explanation. I think we can find and fix all places where this issue is observed.

gedu · 2023-03-24T10:51:55Z

@gedu thank you for the detailed explanation. I think we can find and fix all places where this issue is observed.

@hayata-suenaga do you mean in this PR or on follow-up PRs?

hayata-suenaga · 2023-03-24T16:18:18Z

@gedu I believe we should handle all similar issues in your PRs as the root cause is the same among them.

gedu · 2023-03-27T12:25:45Z

@gedu I believe we should handle all similar issues in your PRs as the root cause is the same among them.

@hayata-suenaga I went through the app and found 2 places that I think make sense to add this new flag, Report List, and Profile screen, I'm adding videos so you can see the before and after

Before

LHN_before.mp4

After

LHN_after.mp4

Before

Profile_before.mp4

After

Profile_after.mp4

hayata-suenaga

LGTM! @thesahindia could you also review this one, please?

gedu · 2023-03-28T14:45:07Z

@hayata-suenaga I was looking at some edit comment issues and saw this behavior, I think we should apply this fix to the ReportScreen

Before

Report_before.mp4

After

Report_after.mp4

# Conflicts: # src/pages/home/ReportScreen.js

thesahindia · 2023-03-28T17:51:30Z

Didn't get enough time today to review this PR. It's EOD for me. I will get to this in the morning.

hayata-suenaga · 2023-03-29T14:06:00Z

@gedu good catch!

gedu · 2023-03-31T11:42:54Z

@hayata-suenaga is all ok? is something that I can help with?

hayata-suenaga · 2023-03-31T12:34:33Z

@gedu could you check this comment?

gedu · 2023-03-31T14:47:10Z

@hayata-suenaga replied

gedu · 2023-04-05T09:26:54Z

Received the list of which screens the button should avoid the keyboard. Working on them

# Conflicts: # src/pages/iou/IOUModal.js

hayata-suenaga · 2023-04-17T15:34:39Z

@gedu please ping @thesahindia and me when you're ready for the review again 🙂

# Conflicts: # src/pages/iou/MoneyRequestModal.js

gedu · 2023-04-17T15:47:47Z

Fixed the conflicts, the comment and fixed MoneyRequestDescriptionPage so the save button moves up

@hayata-suenaga @thesahindia

thesahindia · 2023-04-17T20:58:56Z

src/components/ScreenWrapper/propTypes.js

@@ -44,6 +48,7 @@ const defaultProps = {
    onEntryTransitionEnd: () => {},
    modal: {},
    keyboardAvoidingViewBehavior: 'padding',
+    shouldEnableMaxHeight: !DeviceCapabilities.canUseTouchScreen(),


@gedu, why aren't we using false here?

Because the issue was reported mainly on web mobile, so I wanna leave the behavior for web as is just in case, but I think it can be false, should I change it?

Yes. We should use false.

thesahindia · 2023-04-17T21:01:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-18.at.2.22.47.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-18.at.12.57.46.AM.mov

Mobile Web - Safari

Screen.Recording.2023-04-18.at.12.43.55.AM.mov

Desktop

Screen.Recording.2023-04-18.at.1.01.21.AM.mov

iOS

Android

Screen.Recording.2023-04-18.at.12.58.54.AM.mov

thesahindia · 2023-04-17T21:01:38Z

Looks good. Will approve once #16443 (comment) gets resolved.

hayata-suenaga

It's probably discussed previously, but could you remind me again why we're not using enabled prop of KeyboardAvoidingView and instead setting maxHeight?

thesahindia · 2023-04-18T20:39:04Z

It's probably discussed previously, but could you remind me again why we're not using enabled prop of KeyboardAvoidingView and instead setting maxHeight?

I believe it doesn't work on ios safari (tested just now), I think that's why we used maxHeight.

thesahindia

Looks good and works well!

All yours @hayata-suenaga

hayata-suenaga · 2023-04-18T23:49:19Z

It's probably discussed previously, but could you remind me again why we're not using enabled prop of KeyboardAvoidingView and instead setting maxHeight?

for a moment, I completely forgot the purpose of this PR. please never mind the above question.

hayata-suenaga

LGTM

NAB: just a question

does anybody know why we're not using flex: 1 and instead using maxHeight on KeyboardAvodingView?

MelvinBot · 2023-04-21T15:18:32Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-04-21T16:24:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-21T21:45:31Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-04-24T22:00:48Z

Hey, looks the PR didn't fix all the instances of the view port jump behaviour on the request money page, we got another report here #17866

parasharrajat · 2023-04-24T22:06:20Z

src/components/ScreenWrapper/index.js

@@ -109,7 +111,7 @@ class ScreenWrapper extends React.Component {
                                paddingStyle,
                            ]}
                        >
-                            <KeyboardAvoidingView style={[styles.w100, styles.h100, {maxHeight: this.props.windowHeight}]} behavior={this.props.keyboardAvoidingViewBehavior}>
+                            <KeyboardAvoidingView style={[styles.w100, styles.h100, {maxHeight}]} behavior={this.props.keyboardAvoidingViewBehavior}>


No inline styles cc: @thesahindia

OSBotify · 2023-04-25T05:18:42Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hayata-suenaga · 2023-04-25T16:11:24Z

Hey, looks the PR didn't fix all the instances of the view port jump behaviour on the request money page, we got another report here #17866

The linked issue seems to be a little bit different from the original issue (button jumps to the bottom vs. keyboard jumps to the top). @gedu @thesahindia could one of you check if this is a regression caused from this PR?

Christinadobrzyn · 2023-04-27T17:25:16Z

nudging @thesahindia and @gedu about ^ regression question so we can determine if we should move forward with this job as a separate fix. Thanks!

thesahindia · 2023-04-27T17:27:43Z

Ahh sorry, I forgot to comment here. Actually I wasn't able to repro the issue and I don't think it is a regression from this PR.

thesahindia · 2023-04-27T17:29:02Z

The purpose of this PR was fixing the jump issue on ios safari.

s77rt · 2023-07-25T21:44:12Z

We didn't handle all the pages that needs the shouldEnableMaxHeight prop e.g. NewContactMethodPage (Coming from #22661).

gedu added 2 commits March 22, 2023 12:24

New locking height prop

0713192

Cleanups

81986b1

gedu requested a review from a team as a code owner March 23, 2023 12:11

melvin-bot bot requested review from hayata-suenaga and thesahindia and removed request for a team March 23, 2023 12:11

ArekChr previously approved these changes Mar 23, 2023

View reviewed changes

add lockHeight to Profile and SideBar Pages

be4fdf1

gedu dismissed ArekChr’s stale review via be4fdf1 March 27, 2023 13:18

hayata-suenaga previously approved these changes Mar 27, 2023

View reviewed changes

locking height to ReportScreen for messages

b6c8612

gedu dismissed hayata-suenaga’s stale review via b6c8612 March 28, 2023 14:47

Merge branch 'main' into edu/15270_viewport_jumping_up

0f0628e

# Conflicts: # src/pages/home/ReportScreen.js

lockheight for add payment screen

c0af64c

gedu added 2 commits April 5, 2023 15:14

Merge branch 'main' into edu/15270_viewport_jumping_up

12a307a

# Conflicts: # src/pages/iou/IOUModal.js

Updated max height handling

276e23b

Merge branch 'main' into edu/15270_viewport_jumping_up

afb02f1

# Conflicts: # src/pages/iou/MoneyRequestModal.js

thesahindia reviewed Apr 17, 2023

View reviewed changes

hayata-suenaga reviewed Apr 17, 2023

View reviewed changes

Changed shouldEnableMaxHeight to be false as default

b90d6c8

thesahindia approved these changes Apr 18, 2023

View reviewed changes

hayata-suenaga approved these changes Apr 19, 2023

View reviewed changes

s77rt mentioned this pull request Apr 19, 2023

[$1000] mWeb/Chrome-Chat- Black area above the keyboard overlaps the Send button #17270

Closed

6 tasks

bernhardoj mentioned this pull request Apr 19, 2023

[$1000] mWeb - Connect Bank Account - When navigating through fields in VBA, the information is "flashing" #15991

Closed

6 tasks

thesahindia mentioned this pull request Apr 19, 2023

[$1000] When navigating from the Display Name Page to the Profile page in the app, the timezone and personal details disappear for a moment. #17425

Closed

6 tasks

hayata-suenaga merged commit 4341da6 into Expensify:main Apr 21, 2023

OSBotify mentioned this pull request Apr 21, 2023

Deploy Checklist: New Expensify 2023-04-21 #17804

Closed

14 tasks

s77rt mentioned this pull request Apr 24, 2023

[HOLD for payment 2023-12-15] [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #17866

Closed

6 tasks

parasharrajat reviewed Apr 24, 2023

View reviewed changes

s77rt mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-01] [$1000] mWeb - Next button is hidden behind the keyboard #22661

Closed

6 tasks

Viewport jumping up #16443

Viewport jumping up #16443

Conversation

gedu commented Mar 23, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 23, 2023

hayata-suenaga commented Mar 23, 2023 • edited Loading

gedu commented Mar 23, 2023

hayata-suenaga commented Mar 23, 2023

gedu commented Mar 24, 2023

hayata-suenaga commented Mar 24, 2023

gedu commented Mar 27, 2023

Before

After

Before

After

hayata-suenaga left a comment • edited Loading

Choose a reason for hiding this comment

gedu commented Mar 28, 2023

Before

After

thesahindia commented Mar 28, 2023

hayata-suenaga commented Mar 29, 2023

gedu commented Mar 31, 2023

hayata-suenaga commented Mar 31, 2023

gedu commented Mar 31, 2023

gedu commented Apr 5, 2023

hayata-suenaga commented Apr 17, 2023

gedu commented Apr 17, 2023

thesahindia Apr 17, 2023

Choose a reason for hiding this comment

gedu Apr 18, 2023

Choose a reason for hiding this comment

thesahindia Apr 18, 2023

Choose a reason for hiding this comment

gedu Apr 18, 2023

Choose a reason for hiding this comment

thesahindia commented Apr 17, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia commented Apr 17, 2023

hayata-suenaga left a comment • edited Loading

Choose a reason for hiding this comment

thesahindia commented Apr 18, 2023

thesahindia left a comment

Choose a reason for hiding this comment

hayata-suenaga commented Apr 18, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

MelvinBot commented Apr 21, 2023

OSBotify commented Apr 21, 2023

OSBotify commented Apr 21, 2023

s77rt commented Apr 24, 2023

parasharrajat Apr 24, 2023

Choose a reason for hiding this comment

OSBotify commented Apr 25, 2023

hayata-suenaga commented Apr 25, 2023

Christinadobrzyn commented Apr 27, 2023

thesahindia commented Apr 27, 2023

thesahindia commented Apr 27, 2023

s77rt commented Jul 25, 2023

gedu commented Mar 23, 2023 •

edited

Loading

hayata-suenaga commented Mar 23, 2023 •

edited

Loading

hayata-suenaga left a comment •

edited

Loading

hayata-suenaga left a comment •

edited

Loading