[HOLD for 18997] [$1000] Android- infinite loading on open profile pic preview second time

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click on any user to see details
3. Click on profile pic to see preview
4. Click on back button
5. Again click on profile pic to see preview

Expected Result:

Should show profile pic preview

Actual Result:

Infinite loading on open profile pic

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230714_164616_New.Expensify.mp4

Screen_Recording_20230714_170233_Expensify.Chat.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689333392843659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d82661194c0b255b
• Upwork Job ID: 1681049828862857216
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android- infinite loading on open profile pic preview second time

What is the root cause of that problem?

On second loading of ImageView, isLoading is true although image is already loaded in ImageView component.
Problem is with Image component, Image component is using react-native-fast-image, it supports image caching like browser.

On first loading, Image component lifecycle is onLoadStart => onLoad => onLoadEnd.
FYI, we are not using onLoadEnd callback.

App/src/components/ImageView/index.native.js

Lines 211 to 227 in 405fcdf

	<Image
	style={[
	styles.w100,
	styles.h100,
	this.props.style,
	// Hide image while loading so ImageZoom can get the image
	// size before presenting - preventing visual glitches or shift
	// due to ImageZoom
	shouldShowLoadingIndicator ? styles.opacity0 : styles.opacity1,
	]}
	source={{uri: this.props.url}}
	isAuthTokenRequired={this.props.isAuthTokenRequired}
	resizeMode={Image.resizeMode.contain}
	onLoadStart={this.imageLoadingStart}
	onLoad={this.configureImageZoom}
	/>

isLoading is true on component loading, and onLoadStart is also updating isLoading to true

App/src/components/ImageView/index.native.js

Lines 142 to 148 in 405fcdf

	imageLoadingStart() {
	if (this.state.isLoading) {
	return;
	}
	this.resetImageZoom();
	this.setState({imageHeight: 0, imageWidth: 0, isLoading: true});
	}

When onLoad is invoked, isLoading becomes true currently.

App/src/components/ImageView/index.native.js

Lines 105 to 121 in 405fcdf

	configureImageZoom({nativeEvent}) {
	let imageWidth = nativeEvent.width;
	let imageHeight = nativeEvent.height;
	const containerWidth = Math.round(this.props.windowWidth);
	const containerHeight = Math.round(this.state.containerHeight ? this.state.containerHeight : this.props.windowHeight);
	const aspectRatio = Math.min(containerHeight / imageHeight, containerWidth / imageWidth);
	imageHeight *= aspectRatio;
	imageWidth *= aspectRatio;
	// Resize the image to max dimensions possible on the Native platforms to prevent crashes on Android. To keep the same behavior, apply to IOS as well.
	const maxDimensionsScale = 11;
	imageWidth = Math.min(imageWidth, containerWidth * maxDimensionsScale);
	imageHeight = Math.min(imageHeight, containerHeight * maxDimensionsScale);
	this.setState({imageHeight, imageWidth, isLoading: false});
	}

Once image is cached, Image component lifecycle is onLoad => onLoadStart => onLoadEnd
Thats why isLoading is false although image is already loaded.

What changes do you think we should make in order to solve the problem?

In ImageView component, need to add onLoadEnd prop in Image component usage and updates isLoading to true in onLoadEnd callback.

    <Image
        style={[
            styles.w100,
            styles.h100,
            this.props.style,

            // Hide image while loading so ImageZoom can get the image
            // size before presenting - preventing visual glitches or shift
            // due to ImageZoom
            shouldShowLoadingIndicator ? styles.opacity0 : styles.opacity1,
        ]}
        source={{uri: this.props.url}}
        isAuthTokenRequired={this.props.isAuthTokenRequired}
        resizeMode={Image.resizeMode.contain}
        onLoadStart={this.imageLoadingStart}
        onLoad={this.configureImageZoom}
        onLoadEnd={() => this.setState({isLoading: false})}
    />

And prevent to initialize image dimension in onLoadStart, no need to reset isLoading to true because it initiates by true on component loading.

    imageLoadingStart() {
        if (this.state.isLoading) {
            return;
        }
        this.resetImageZoom();
    }

Result

Screen.Recording.2023-07-15.at.7.03.08.AM.mov

What alternative solutions did you explore? (Optional)

We can prevent to invoke onLoadStart after onLoad is invoked by image caching.
If image is already loaded, imgHeight and imgWidth value is not 0.

    imageLoadingStart() {
        if (this.state.isLoading || (this.state.imgHeight !== 0 && this.state.imgWidth !== 0)) {
            return;
        }
        this.resetImageZoom();
        this.setState({imageHeight: 0, imageWidth: 0, isLoading: true});
    }

[hoangzinh]

I'm not sure if it's dup with #16046

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d82661194c0b255b

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[adelekennedy]

I was too fast with making this external, walking it back since this may be related to a larger issue

[jfquevedol2198]

I think its better to use onLoadEnd prop to resolve this issue.

[adelekennedy]

deprioritizing for a mo

[adelekennedy]

still holding here

[adelekennedy]

on hold

[kbecciv]

The issue is reproducible on staging build 1.4.8.0, reopening @adelekennedy

Android-Avatar-preview-endless-spinner-staging.mp4

[adelekennedy]

we're still on hold here

[adelekennedy]

not reproducible