[HOLD for payment 2023-09-21] [$500] Implement new layout for SecurityPage

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Open the security settings page

Expected Result:

It should look like this:

and should be implemented using the IllustratedHeaderPageLayout component. The asset for the safe animation lottie JSON file can be found here:

Safe.json.zip

The correct background color is ice500 or #4ED7DE

Actual Result:

It looks like this:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179e9954261696fde
• Upwork Job ID: 1699055159124353024
• Last Price Increase: 2023-09-05
• Automatic offers:
• hungvu193 | Contributor | 26507971

[melvin-bot]

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0179e9954261696fde

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[roryabraham]

Please use our standard proposal template.

[roryabraham]

@getusha your proposal does not provide sufficient detail

[hungvu193]

Proposal

Please re-state the feature request that we are trying to solve in this issue.

Implement new layout for SecurityPage

What is the root cause of that problem?

We're using ScreenWrapper for SecurityPage.

What changes do you think we should make in order to solve the problem?

• Download the lottie animation above and put to our asset.
• Replace ScreenWrapper with IllustratedHeaderPageLayout with the illustration we just saved and background color: #4ED7DE
• Remove HeaderWithBackButton and move the its props to IllustratedHeaderPageLayout.
• Also add shouldShowBackButton to IllustratedHeaderPageLayout to make sure the back button is visible.

What alternative solutions did you explore? (Optional)

N/A

[roryabraham]

@hungvu193 missing considerations for adding the lottie animation asset

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Implement new layout for SecurityPage #26784

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment offer (Contributor)
• @narefyev91 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[trjExpensify]

👋 @hungvu193 @narefyev91 looks like this needs a bit of clean-up: #27453

[trjExpensify]

Comparisons:

[roryabraham]

Working on cleanup now

[hungvu193]

Thanks @roryabraham , let me know if I can help anything

[roryabraham]

follow-up PR is ready for review here

[maddylewis]

payment this week

[maddylewis]

is payment for this happening over here? #27487

[roryabraham]

@maddylewis unless I'm missing something I think this is separate from #27487 so we should be able to pay this out. However, this technically caused a regression, so we should only pay 50%.

[maddylewis]

Payments

• @hungvu193 - $250 (Upwork)
• @narefyev91 - $250 (Upwork)

[maddylewis]

@narefyev91 - could you link your Upwork profile here? im having a tough time hiring you to this job - ty!

[narefyev91]

@narefyev91 - could you link your Upwork profile here? im having a tough time hiring you to this job - ty!

Hey @maddylewis ! I'm from Callstack - no needs any payment with Upwork

[maddylewis]

oops! my b, thanks for clarifying!

[maddylewis]

paid!