-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-21] [$500] Security - Status bar color does not match with header #27453
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01217477790895e67d |
Triggered auto assignment to @trjExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @sophiepintoraetz ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu ( |
ProposalProblemSecurity - Status bar color does not match with header. Root CauseWe are using Route instead of route name for defining the color for Header. https://github.com/Expensify/App/blob/main/src/styles/themes/default.js#L90 ChangesAdd and new variable SECURITY under SETTINGS as Settings_Security. use also we need to do the same for |
Commented on the issue that implemented this: #26775 (comment) |
Hey, this is a regression so we should not pay an additional bounty to fix it. |
Yuppp, we'll just pay out the bug report to @gadhiyamanan! |
This issue has not been updated in over 15 days. @burczu, @trjExpensify, @roryabraham eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-21. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
👋 @burczu checklist time please! I'm curious how this can be caught in the future in development. As for payments, I think @gadhiyamanan is the only one due $50 for the bug report as per here. Correct? |
Bump on the above! |
@trjExpensify Sorry for the delay - I'll get back to BZ Checklists soon, after I finish reviewing my PR's and proposals. |
Sounds good! |
Any luck? :) |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
I'm not sure how to treat this one because the issue was actually fixed somewhere else, I think here: #27483, and this issue and related PR actually does not fix anything (it just switches from using But the issue itself was introduced by the new feature (link to PR).
Regression test proposal in a separate comment.
|
Regression Test Proposal
|
LGTM 👍🏼 |
Okay cool! I'm curious if there's something in the dev lifecycle, like in the PR checklist or something for ensuring the status bar colour matches when introducing a new animation? As for the regression test, we have this one below. So I was thinking of adding a couple of items bolded to accommodate this:
I'll float that with Applause here. |
In the meantime, @gadhiyamanan sent you an offer for the bug report. |
@trjExpensify offer accepted, thanks! |
@gadhiyamanan - paid! |
@trjExpensify regarding this:
I don't think so, but I think it's quite rare when we change this particular part of the app. Maybe we should add something like |
Hm yeah, I think it's pretty generic -- we'd want to offer some direction. We do also have a note somewhere to add the design label for design changes. Okay, maybe we leave it for now then 👍 Everyone is settled up here, closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Status bar color should be blue same as header
Actual Result:
Status bar color does not match with header
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.70.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:@gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694494708815589
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: