Fix settings page / status bugs #27482

roryabraham · 2023-09-15T02:04:19Z

Details

~~This PR fixes four problems:

For the settings page background color theme, we had used the route as the key instead of the screen name, which is why it didn't work here
We had the same problem for the SaveTheWorld page, so I fixed it there too
We had the same problem for the custom status page, so I fixed it there too
I removed some unnecessary props from the IllustratedHeaderPageLayout – the shouldShowCloseButton prop was causing the close button to appear.~~

Edit: These changes were made elsewhere, so this is just a documentation/cleanup change now.

Fixed Issues

$ #27453

Tests

Open the settings page on iOS Safari.
Verify that the status bar animates to blue.
Verify that no close button is shown.
Press back
Verify that the status bar animated back to green

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Same as test steps.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

iOSWeb.mov

Desktop

iOS

Android

melvin-bot · 2023-09-15T02:04:23Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2023-09-15T02:05:25Z

cc @hungvu193 FYI. The close button part was my fault for giving you an outdated mockup, but the routes v.s. settings thing was a mistake in the coding.

# Conflicts: # src/styles/themes/default.js # src/styles/themes/light.js

src/styles/themes/default.js

src/SCREENS.ts

.github/workflows/platformDeploy.yml

burczu · 2023-09-18T12:15:08Z

Hey @roryabraham! You've only added screen recording for Mobile Web - Safari - does it mean it only affects this environment? In the issue I can see that all the platforms was affected.

roryabraham · 2023-09-19T04:02:35Z

Actually I was just moving fast and cutting corners because this PR isn't really a new feature, just fixing a misuse of an existing pattern. Running a test build and will circle back for screenshots on all platforms.

OSBotify · 2023-09-19T04:30:21Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/27482/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/27482/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/27482/NewExpensify.dmg	https://27482.pr-testing.expensify.com

grgia

LGTM

grgia · 2023-09-25T06:53:19Z

Code looks good, just need to fix merge conflicts and have PR checklist done

# Conflicts: # src/SCREENS.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators.js # src/pages/TeachersUnite/SaveTheWorldPage.js # src/pages/settings/Profile/CustomStatus/StatusPage.js # src/pages/settings/Security/SecuritySettingsPage.js # src/styles/themes/default.ts # src/styles/themes/light.ts

OSBotify · 2023-11-01T00:33:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/27482/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/27482/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/27482/NewExpensify.dmg	https://27482.pr-testing.expensify.com

grgia · 2023-11-01T10:01:14Z

@roryabraham heads up! lint is failing

roryabraham · 2023-11-02T21:13:34Z

Fixed lint and added screenshots on all platforms

burczu · 2023-11-06T11:04:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

burczu

LGTM

melvin-bot · 2023-11-06T11:38:46Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-11-06T12:20:55Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: HERE

Wut. @grgia I assume you don't need me to do this right?

grgia · 2023-11-06T17:24:46Z

@roryabraham looks like there's some conflicts with the new typescript themes

# Conflicts: # src/styles/themes/default.ts # src/styles/themes/light.ts

OSBotify · 2023-11-09T17:42:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-10T15:59:39Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:53:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T22:13:04Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:56:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 4 commits September 15, 2023 09:33

Only one active deploy at a time

6738d49

Fix header theme color for security page

263e992

Fix theme on SaveTheWorld page

ae3e9e0

Dont show close button in settings page

61b462a

roryabraham requested a review from a team as a code owner September 15, 2023 02:04

roryabraham self-assigned this Sep 15, 2023

melvin-bot bot requested review from burczu and removed request for a team September 15, 2023 02:04

roryabraham mentioned this pull request Sep 15, 2023

[HOLD for payment 2023-11-21] [$500] Security - Status bar color does not match with header #27453

Closed

6 tasks

roryabraham added 2 commits September 15, 2023 14:51

Fix lint style

40671c6

Merge branch 'main' into Rory-FixSettingsPageRegression

beb28c5

# Conflicts: # src/styles/themes/default.js # src/styles/themes/light.js

roryabraham mentioned this pull request Sep 15, 2023

Fix undefined color keys #27483

Merged

62 tasks

Fix Settings_Status page

1f7667b

roryabraham changed the title ~~Fix settings page regressions~~ Fix settings page / status bugs Sep 15, 2023

Fix main background color of settings_status

430e41d

roryabraham mentioned this pull request Sep 18, 2023

[HOLD for payment 2023-09-21] [$500] Implement new layout for SecurityPage #26775

Closed

grgia reviewed Sep 18, 2023

View reviewed changes

src/styles/themes/default.js Outdated Show resolved Hide resolved

src/SCREENS.ts Outdated Show resolved Hide resolved

.github/workflows/platformDeploy.yml Outdated Show resolved Hide resolved

grgia mentioned this pull request Sep 18, 2023

[HOLD for payment 2023-09-27] [Awaiting Payment] App crash when requesting money #27487

Closed

6 tasks

roryabraham added 3 commits September 18, 2023 19:46

Remove unrelated deploy change

13f3fa1

Merge branch 'main' into Rory-FixSettingsPageRegression

b798240

Add documentation comment to theme background color field

fcc4258

roryabraham added the Ready To Build label Sep 19, 2023

grgia previously approved these changes Sep 25, 2023

View reviewed changes

roryabraham dismissed grgia’s stale review via 102e1d2 November 1, 2023 00:02

Remove unused import

ae939fc

burczu approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss November 6, 2023 11:38

Julesssss removed their request for review November 7, 2023 08:47

Merge branch 'main' into Rory-FixSettingsPageRegression

11fa8ab

# Conflicts: # src/styles/themes/default.ts # src/styles/themes/light.ts

roryabraham requested a review from grgia November 8, 2023 03:20

grgia approved these changes Nov 9, 2023

View reviewed changes

grgia merged commit 2657550 into main Nov 9, 2023
12 checks passed

grgia deleted the Rory-FixSettingsPageRegression branch November 9, 2023 17:37

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix settings page / status bugs #27482

Fix settings page / status bugs #27482

roryabraham commented Sep 15, 2023 •

edited

Loading

melvin-bot bot commented Sep 15, 2023

roryabraham commented Sep 15, 2023

burczu commented Sep 18, 2023 •

edited

Loading

roryabraham commented Sep 19, 2023

OSBotify commented Sep 19, 2023

grgia left a comment

grgia commented Sep 25, 2023

OSBotify commented Nov 1, 2023

grgia commented Nov 1, 2023

roryabraham commented Nov 2, 2023

burczu commented Nov 6, 2023 •

edited

Loading

burczu left a comment

melvin-bot bot commented Nov 6, 2023

Julesssss commented Nov 6, 2023

grgia commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

Fix settings page / status bugs #27482

Fix settings page / status bugs #27482

Conversation

roryabraham commented Sep 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 15, 2023

roryabraham commented Sep 15, 2023

burczu commented Sep 18, 2023 • edited Loading

roryabraham commented Sep 19, 2023

OSBotify commented Sep 19, 2023

grgia left a comment

Choose a reason for hiding this comment

grgia commented Sep 25, 2023

OSBotify commented Nov 1, 2023

grgia commented Nov 1, 2023

roryabraham commented Nov 2, 2023

burczu commented Nov 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 6, 2023

Julesssss commented Nov 6, 2023

grgia commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

roryabraham commented Sep 15, 2023 •

edited

Loading

burczu commented Sep 18, 2023 •

edited

Loading

burczu commented Nov 6, 2023 •

edited

Loading