Fix/ios wrong permission message #30374

ishpaul777 · 2023-10-25T18:02:09Z

Details

Fixed the incorrect error message displaying "camera permission denied" when the actual issue was a denial of microphone permission. Now, the error message accurately reflects the microphone permission denial.

Fixed Issues

$ #23421
PROPOSAL: #23421 (comment)

Tests

Verify that no errors appear in the JS console
Can be tested on ios
Complete 'Add Bank Account" flow until step 3.
Decline Camera permission in Settings. Start Onfido Verfication, Verfify error with "camera permission denied" (exact copy needs approval here) is shown.
Decline Microphone permission in Settings. Start Onfido Verfication, Verfify error with "Microphone permission denied" (exact copy needs approva herel) is shown.

Offline tests

QA Steps

Verify that no errors appear in the JS console
Can be tested on ios and android
Complete 'Add Bank Account" flow until step 3.
Decline Camera permission in Settings. Start Onfido Verfication, Verfify error with "camera permission denied" (exact copy needs approval here) is shown.
Decline Microphone permission in Settings. Start Onfido Verfication, Verfify error with "Microphone permission denied" (exact copy needs approva herel) is shown.

PR Author Checklist

Screenshots/Videos

Android: Native

VID_20231118155925.mp4

Android: mWeb Chrome

iOS: Native

282568068-a5f149f0-44c8-40cb-a69c-9ba3a3212e00.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan · 2023-10-26T09:46:06Z

src/components/Onfido/index.native.js

-                    return;
-                }
+                if (!_.isEmpty(errorMessage)) {
+                    const micPermission = Platform.select({


Platform.select is not preferred. Please re-use iou/ReceiptSelector/CameraPermission structure to handle platform specific permissions.

ishpaul777 · 2023-10-31T19:27:18Z

@allroundexperts Can you test the changes and provide feedback please?

melvin-bot · 2023-11-01T20:44:01Z

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-11-01T20:48:57Z

@allroundexperts if you are busy with more priorty task, Should I ask @chiragsalian to kick off adhoc build so i can test changes myself.

situchan · 2023-11-01T20:53:16Z

@ishpaul777 you won't be able to test adhoc build as your udid isn't registered.
I will test myself. I think C+ testing should be enough.

ishpaul777 · 2023-11-01T20:57:14Z

@situchan can you please explain how can i build app on ios physical device it would be helpful for future issue, do i need some extra permissions or what?

situchan · 2023-11-01T21:02:00Z

@situchan can you please explain how can i build app on ios physical device it would be helpful for future issue, do i need some extra permissions or what?

If you have your own apple developer account or got invited from any other team, you can point to that cert/provisioning profile, change bundle id to any random one and install the app on iPhone. Note: it's not possible to test features which require cert, i.e. push notification.
If you don't have access to any development team, it's not possible.

ishpaul777 · 2023-11-01T21:49:12Z

Thanks for explaination @situchan

allroundexperts · 2023-11-02T17:17:57Z

@allroundexperts if you are busy with more priorty task, Should I ask @chiragsalian to kick off adhoc build so i can test changes myself.

Sorry guys, I was having issues with native builds till last night. I will test this today and post the results @ishpaul777 @situchan!

allroundexperts · 2023-11-03T05:26:51Z

Hi @ishpaul777!

This does not seem to work. When I have mic disabled, I'm getting the generic Something went wrong error. Did you follow the changes I did in my branch?

Also, can you merge main?

RPReplay_Final1698988388.MP4

ishpaul777 · 2023-11-03T06:43:46Z

@allroundexperts Can you test again please

ishpaul777 · 2023-11-06T11:29:20Z

@allroundexperts bump!

ishpaul777 · 2023-11-24T18:47:32Z

@allroundexperts, sorry for ping again. I just wanted to check in and see if you might have an estimated time when you can test with these cases its been on hold for a while. Thanks!

allroundexperts · 2023-11-26T22:10:00Z

@allroundexperts, sorry for ping again. I just wanted to check in and see if you might have an estimated time when you can test with these cases its been on hold for a while. Thanks!

@ishpaul777 I don't think that these test cases are possible for me to test. As soon as you go offline, we're blocking the Onfido flow.

ishpaul777 · 2023-11-27T08:36:56Z

As soon as you go offline, we're blocking the Onfido flow.

@allroundexperts Thanks i was unaware of this

@situchan you can condsider this open for your review

ishpaul777 · 2023-12-01T13:31:12Z

@situchan Gentle bump

situchan · 2023-12-08T15:45:40Z

@ishpaul777 please pull main

situchan · 2023-12-11T05:26:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android1.mp4

android2.mp4

Android: mWeb Chrome

iOS: Native

ios1.MP4

ios2.MP4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan

Some NAB suggestions:

App/src/CONST.ts

Lines 1093 to 1097 in 4f41819

	USER_CAMERA_DENINED: 'Onfido.OnfidoFlowError',
	USER_CAMERA_PERMISSION: 'Encountered an error: cameraPermission',
	// eslint-disable-next-line max-len
	USER_CAMERA_CONSENT_DENIED:
	'Unexpected result Intent. It might be a result of incorrect integration, make sure you only pass Onfido intent to handleActivityResult. It might be due to unpredictable crash or error. Please report the problem to [email protected]. Intent: null \n resultCode: 0',

remove these lines as not used anymore

src/components/Onfido/index.native.js

Co-authored-by: Situ Chandra Shil <[email protected]>

src/languages/en.ts

Co-authored-by: Situ Chandra Shil <[email protected]>

src/languages/en.ts

Co-authored-by: Situ Chandra Shil <[email protected]>

chiragsalian · 2023-12-12T18:59:07Z

I'm OOO for two months so i'm unsure if i can review this in a timely manner once it's ready for review. So, I am unassigning myself and once its ready for review please reassign to another internal Expensify engineer for review.

chiragsalian · 2023-12-12T19:01:00Z

oops i just realized this is ready for review. I thought it was still WIP, looking at it now 🙂

chiragsalian

LGTM

OSBotify · 2023-12-12T19:07:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:28:55Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:49:38Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T12:17:12Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T15:23:55Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: wrong alert message for microphone permission error

3105687

ishpaul777 mentioned this pull request Oct 26, 2023

[Hold for Payment 2023-12-21][$1000] IOS - Permission popup indicates wrong message #23421

Closed

6 tasks

situchan reviewed Oct 26, 2023

View reviewed changes

ishpaul777 requested a review from situchan October 26, 2023 10:17

ishpaul777 and others added 5 commits October 26, 2023 15:50

added requested changes

ea5b6c9

fix conflicts

c4bdd27

Merge branch 'main' into fix/ios-wrong-permission-message

177d8b9

fix conflicts

a7dd5e3

fix imports

3d18adf

ishpaul777 added 3 commits November 1, 2023 00:59

fix lint

967569d

fix prettier difffs

729f264

made change specific to ios

efe6754

ishpaul777 marked this pull request as ready for review November 1, 2023 20:43

ishpaul777 requested a review from a team as a code owner November 1, 2023 20:43

melvin-bot bot requested review from chiragsalian and removed request for a team November 1, 2023 20:43

ishpaul777 and others added 2 commits November 3, 2023 12:01

Merge branch 'Expensify:main' into fix/ios-wrong-permission-message

9482050

fix no modal error on mic permission

f46a771

situchan mentioned this pull request Nov 6, 2023

fix: Receipt - The border green line on top and bottom in native. #30639

Closed

58 tasks

Merge branch 'Expensify:main' into fix/ios-wrong-permission-message

8ba7176

Merge branch 'Expensify:main' into fix/ios-wrong-permission-message

7ca308e

situchan approved these changes Dec 11, 2023

View reviewed changes

src/components/Onfido/index.native.js Outdated Show resolved Hide resolved

src/components/Onfido/index.native.js Outdated Show resolved Hide resolved

ishpaul777 and others added 4 commits December 11, 2023 16:05

Update src/components/Onfido/index.native.js

8c73e7d

Co-authored-by: Situ Chandra Shil <[email protected]>

Update src/components/Onfido/index.native.js

924247d

Co-authored-by: Situ Chandra Shil <[email protected]>

Merge branch 'Expensify:main' into fix/ios-wrong-permission-message

585e322

Update CONST.ts

099c7fa

situchan reviewed Dec 11, 2023

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

Update src/languages/en.ts

b85636f

Co-authored-by: Situ Chandra Shil <[email protected]>

situchan reviewed Dec 11, 2023

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

Update src/languages/en.ts

8c0b10b

Co-authored-by: Situ Chandra Shil <[email protected]>

chiragsalian removed their request for review December 12, 2023 18:59

chiragsalian self-requested a review December 12, 2023 19:01

chiragsalian approved these changes Dec 12, 2023

View reviewed changes

chiragsalian merged commit 776849a into Expensify:main Dec 12, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

ishpaul777 mentioned this pull request Jan 23, 2024

Enable Fabric and TurboModules on iOS & Android #13767

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/ios wrong permission message #30374

Fix/ios wrong permission message #30374

ishpaul777 commented Oct 25, 2023 •

edited

Loading

situchan Oct 26, 2023

ishpaul777 commented Oct 31, 2023

melvin-bot bot commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023 •

edited

Loading

situchan commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023

situchan commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023

allroundexperts commented Nov 2, 2023

allroundexperts commented Nov 3, 2023 •

edited

Loading

ishpaul777 commented Nov 3, 2023

ishpaul777 commented Nov 6, 2023

ishpaul777 commented Nov 24, 2023

allroundexperts commented Nov 26, 2023

ishpaul777 commented Nov 27, 2023

ishpaul777 commented Dec 1, 2023

situchan commented Dec 8, 2023

situchan commented Dec 11, 2023

situchan left a comment

chiragsalian commented Dec 12, 2023 •

edited

Loading

chiragsalian commented Dec 12, 2023 •

edited

Loading

chiragsalian left a comment

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

Fix/ios wrong permission message #30374

Fix/ios wrong permission message #30374

Conversation

ishpaul777 commented Oct 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

situchan Oct 26, 2023

Choose a reason for hiding this comment

ishpaul777 commented Oct 31, 2023

melvin-bot bot commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023 • edited Loading

situchan commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023

situchan commented Nov 1, 2023

ishpaul777 commented Nov 1, 2023

allroundexperts commented Nov 2, 2023

allroundexperts commented Nov 3, 2023 • edited Loading

ishpaul777 commented Nov 3, 2023

ishpaul777 commented Nov 6, 2023

ishpaul777 commented Nov 24, 2023

allroundexperts commented Nov 26, 2023

ishpaul777 commented Nov 27, 2023

ishpaul777 commented Dec 1, 2023

situchan commented Dec 8, 2023

situchan commented Dec 11, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

chiragsalian commented Dec 12, 2023 • edited Loading

chiragsalian commented Dec 12, 2023 • edited Loading

chiragsalian left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

ishpaul777 commented Oct 25, 2023 •

edited

Loading

ishpaul777 commented Nov 1, 2023 •

edited

Loading

allroundexperts commented Nov 3, 2023 •

edited

Loading

chiragsalian commented Dec 12, 2023 •

edited

Loading

chiragsalian commented Dec 12, 2023 •

edited

Loading