Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Split - Scan bill split is created in one of the participants' chat instead of new group chat #32895

Closed
4 tasks done
kavimuru opened this issue Dec 12, 2023 · 14 comments · Fixed by #32918
Closed
4 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployDeferred Do not use - this label signifies that PR will be deployed later Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.11-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Click FAB > Request money > Scan.
  3. Enter amount > Next.
  4. Select two users that have existing IOUs > Click Split.
  5. Create the bill split.

Expected Result:

The bill split is created in a new group chat with the selected users.

Actual Result:

The bill split is created in one of the participants' 1:1 DM instead of a new group chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • [x ] iOS: mWeb Safari
  • [x ] MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309963_1702353483955.20231212_015403.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 DeployDeferred Do not use - this label signifies that PR will be deployed later Bug Something is broken. Auto assigns a BugZero manager. labels Dec 12, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 12, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 12, 2023

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@abzokhattab
Copy link
Contributor

same as #32855

@MariaHCD
Copy link
Contributor

This does look to be similar to #32855. Closing in favor of that issue.

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Dec 12, 2023

@Julesssss @MariaHCD The fix does not seem to fix this issue. Please reopen this.
It opens wrong report actually

@Julesssss
Copy link
Contributor

Hey @shubham1206agra just to confirm, even with the changes from the linked PR (which haven't yet been merged)?

@shubham1206agra
Copy link
Contributor

Yes
It just opens the wrong report (more specific, of first participant)

@shubham1206agra
Copy link
Contributor

Fix seems to be relatively easy. I will fix this in another PR

@Julesssss
Copy link
Contributor

Thanks, reopening. I will assign you now @shubham1206agra.

@MariaHCD I'll try to keep an eye on this one but we have about 20+ blockers so it would be great if you could also keep on eye on any developments here. Thanks

@Julesssss Julesssss reopened this Dec 12, 2023
@shubham1206agra shubham1206agra mentioned this issue Dec 12, 2023
46 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 12, 2023
@Julesssss
Copy link
Contributor

Fix seems to be relatively easy. I will fix this in another PR

Hey @shubham1206agra just checking which PR you fixed this in?

@shubham1206agra
Copy link
Contributor

#32918

@Julesssss
Copy link
Contributor

Julesssss commented Dec 12, 2023

Thanks, I just merged that fix. We'll verify the fix on staging

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployDeferred Do not use - this label signifies that PR will be deployed later Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants