Fix request flow #32918

shubham1206agra · 2023-12-12T12:35:51Z

Details

Fixed Issues

$ #32867
PROPOSAL: #32867 (comment)
Additional Issue fixed: #32895

Tests

Click FAB > Request money
Enter amount > Next
Click Split next to a few users that have a prior chat (important)
Click Next
Verify that the user cannot modify the participants' list

Verify that no errors appear in the JS console

Additional Test

Click FAB > Request money > Scan.
Upload receipt > Next.
Select two users that have existing IOUs > Click Split.
Create the bill split.
Verify that the user is redirected to the group chat report containing the users.

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-12.at.2.29.55.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-12.at.6.07.56.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-12-12.at.4.17.03.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-12.at.2.41.08.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-12.at.6.12.32.PM.mov

melvin-bot · 2023-12-12T12:35:57Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2023-12-12T12:49:10Z

Reviewing

c3024 · 2023-12-12T13:17:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

splitAndroid.mov

Android: mWeb Chrome

splitmWebChrome.mp4

iOS: Native

splitiOS.mov

iOS: mWeb Safari

splitmWebSafari.mov

MacOS: Chrome / Safari

splitChrome.mov

Additional Test

scanReceiptChrome.mov

MacOS: Desktop

splitDesktop.mov

c3024 · 2023-12-12T13:36:44Z

Since another issue is also being fixed here I think we should include videos for that test as well.

c3024 · 2023-12-12T13:41:40Z

In the additional test I think there need not be an IOU specifically with the user. It appears that any existing chat is fine.

shubham1206agra · 2023-12-12T14:05:29Z

Since another issue is also being fixed here I think we should include videos for that test as well.

Can you do this for a single platform?

c3024 · 2023-12-12T15:18:29Z

Additional test for the other linked issue added for Mac Chrome.

c3024

LGTM

shubham1206agra · 2023-12-12T16:01:00Z

@Julesssss Please merge this

OSBotify · 2023-12-12T16:10:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix request flow (cherry picked from commit d8b8182)

OSBotify · 2023-12-12T16:36:47Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.11-16 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-12T16:47:52Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.11-16 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-12T17:12:33Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.11-16 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2023-12-12T17:48:58Z

Hey @shubham1206agra & @c3024. The review looked good to me, but this doesn't appear to be resolved on 1.4.11-16

Are you able to clarify/verify for @laurenreidexpensify? Thanks

shubham1206agra · 2023-12-12T17:52:05Z

There will not be any group DM if there are only 2 users in split as there is no separate group DM in this case

Same behaviour is on prod

c3024 · 2023-12-13T02:02:47Z

@Julesssss

Selecting two users for splitting means I think the bill the split among three users (including the logged in user who is making the split request).

It is working fine for me on the latest main.

There was no group chat with these users before. Only DMs between User A and User B and User A and User C.

I created a split request from User A with User B and C. On confirming the split request the group chat page with the split request appears.

splitWithTwo.mov

Julesssss · 2023-12-13T09:30:34Z

Thank both, I didn't have time to review yesterday but that is all correct.

OSBotify · 2023-12-13T11:10:49Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

shubham1206agra added 2 commits December 12, 2023 17:55

corrected the condition for modificaion of participants

5f71303

corrected the reportID going to confirmation page

7dfec0e

shubham1206agra requested a review from a team as a code owner December 12, 2023 12:35

melvin-bot bot requested review from c3024 and removed request for a team December 12, 2023 12:35

c3024 approved these changes Dec 12, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam December 12, 2023 15:19

Julesssss approved these changes Dec 12, 2023

View reviewed changes

shubham1206agra mentioned this pull request Dec 12, 2023

Web - Split - Scan bill split is created in one of the participants' chat instead of new group chat #32895

Closed

4 tasks

Julesssss assigned shubham1206agra Dec 12, 2023

Julesssss merged commit d8b8182 into Expensify:main Dec 12, 2023
18 checks passed

OSBotify pushed a commit that referenced this pull request Dec 12, 2023

Merge pull request #32918 from shubham1206agra/fix-request-flow

4a2d139

Fix request flow (cherry picked from commit d8b8182)

github-actions bot mentioned this pull request Dec 12, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

melvin-bot bot mentioned this pull request Dec 13, 2023

[HOLD for payment 2023-12-20] [$500] Split - User can select or unselect members on comfirmation page when splitting bill from FAB #32867

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix request flow #32918

Fix request flow #32918

shubham1206agra commented Dec 12, 2023 •

edited

Loading

melvin-bot bot commented Dec 12, 2023

c3024 commented Dec 12, 2023

c3024 commented Dec 12, 2023 •

edited

Loading

c3024 commented Dec 12, 2023

c3024 commented Dec 12, 2023 •

edited

Loading

shubham1206agra commented Dec 12, 2023

c3024 commented Dec 12, 2023 •

edited

Loading

c3024 left a comment

shubham1206agra commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

Julesssss commented Dec 12, 2023

shubham1206agra commented Dec 12, 2023

c3024 commented Dec 13, 2023

Julesssss commented Dec 13, 2023

OSBotify commented Dec 13, 2023

Fix request flow #32918

Fix request flow #32918

Conversation

shubham1206agra commented Dec 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Additional Test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 12, 2023

c3024 commented Dec 12, 2023

c3024 commented Dec 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 commented Dec 12, 2023

c3024 commented Dec 12, 2023 • edited Loading

shubham1206agra commented Dec 12, 2023

c3024 commented Dec 12, 2023 • edited Loading

c3024 left a comment

Choose a reason for hiding this comment

shubham1206agra commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

OSBotify commented Dec 12, 2023

Julesssss commented Dec 12, 2023

shubham1206agra commented Dec 12, 2023

c3024 commented Dec 13, 2023

Julesssss commented Dec 13, 2023

OSBotify commented Dec 13, 2023

shubham1206agra commented Dec 12, 2023 •

edited

Loading

c3024 commented Dec 12, 2023 •

edited

Loading

c3024 commented Dec 12, 2023 •

edited

Loading

c3024 commented Dec 12, 2023 •

edited

Loading