Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request #34685

Closed
6 tasks done
lanitochka17 opened this issue Jan 17, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Not a priority

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. [User A] Request money from User B
  2. [User B] Navigate to chat with User A
  3. [User B] Click on the preview to go to IOU report
  4. [User B] Click Pay elsewhere

Expected Result:

The system message shows the correct amount

Actual Result:

The system message shows negative amount briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345825_1705526401046.-1068207674234802113bandicam_2024-01-18_02-08-54-906.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 17, 2024

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

@neil-marcellini
Copy link
Contributor

Taking a look now 👀

@neil-marcellini
Copy link
Contributor

This is a very minor problem, but a new problem nonetheless. None of the PRs we deployed recently stand out to me, so I'll debug it and see if I can figure out what's causing the problem.

@neil-marcellini
Copy link
Contributor

I tested this offline so I can inspect the optimistic data. It looks like the html message is right but the iouMessage is wrong.
image

@neil-marcellini
Copy link
Contributor

Asked for feedback on whether we should revert (again again) in Slack here

@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Jan 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 Weekly KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot changed the title Request money - System message shows negative amount briefly when paying request [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request Jan 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-25. 🎊

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 18, 2024
@mountiny mountiny assigned Gonals and unassigned neil-marcellini Jan 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-26. 🎊

Copy link

melvin-bot bot commented Feb 12, 2024

This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Overdue labels Feb 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

@Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

4 participants