Expense - Unable to save report title for workspace expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any workspace
3. Create a manual request
4. Go to expense report
5. Click Title row
6. Change to a new title and save it

Expected Result:

The new report title is saved

Actual Result:

The new report title is not saved. This issue is only reproducible for workspace expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365152_1706897427956.20240203_002336.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[deetergp]

I was able to reproduce this on web. After digging through the code, it looks like it was most recently touched in this PR #34483.

[allroundexperts]

Checking.

[allroundexperts]

@thienlnam The backend is not letting the report being renamed. It throws the following:

You can't rename the report of a free plan

We can do one of the following:

1. Allow rename from the backend for the free plan users.
2. Disable ONLY the title field for free plan users.
3. Disable ALL report fields for the free plan users.

Let me know what we want to do here.

[thienlnam]

You shouldn't be able to set report fields for free workspaces - this should be a control / collect policy only. How are you setting report fields for free plan users?

[thienlnam]

Will take this over since I have context - we don't need to block on this since it's behind a beta and you shouldn't be able to set report fields on a free plan

[allroundexperts]

For free workspaces, we're always sending a title report field attached to the policy. That is why people from free workspaces are able to see the option to edit the title.

[thienlnam]

By default, there might be the text_title for free workspaces. If that's the case, I will update the BE so that it does not return for free workspaces

[allroundexperts]

Yep, that's exactly what is the issue.

[thienlnam]

Ah I see, yeah I'll handle this via the BE then

[thienlnam]

Working on it this week, moving to a weekly since this is still behind beta

[thienlnam]

This is handled by #36044