[HOLD for payment 2024-02-20] [$500] Task – User with the custom name is shown as Hidden in task assignee field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4301190
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login
3. Navigate to a Group Chat
4. Click on the + in the compose box and select "Assign task"
5. Enter a a Title
6. Assign a user from the group that you have access to
7. Create the task

Expected Result:

The assignee with the custom name is displayed in the assignee field

Actual Result:

User with the custom name is shown as Hidden in task assignee field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376640_1707748629323.User_with_the_name_is_shown_as_Hidden_in_task_assignee.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0177663dcf0666e903
• Upwork Job ID: 1757110933025804288
• Last Price Increase: 2024-02-12

Issue Owner

Current Issue Owner: @abekkala

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[bondydaa]

no PRs from the checklist stand out to me as obvious root causes, there were 2 that touched Tasks but I don't see how they would have caused this:

#35585
#36048

[fedirjh]

@bondydaa I think it's a regression from #35027.

Edit: This is not correct.

[situchan]

#35027 was deployed to production last week but this is deploy blocker

[bondydaa]

I tried reverting just #36048 locally and that didn't fix it.

Also tried reverting #35027 locally and that didn't fix it either:

[fedirjh]

@bondydaa It's a regression from #35462 , Specially this line

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 39 in d068807

const user = personalDetails.htmlAttribAccountID;

It should be updated to

const user = personalDetails[htmlAttribAccountID];

[bondydaa]

🎉

tested that and 👍 seems to work

@fedirjh can you get a PR up? will assign now

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bondydaa]

@anmurali nothing for you to do right now, just assigning bug for a BZ to handle payments when the time comes.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0177663dcf0666e903

[melvin-bot]

Current assignees @fedirjh and @situchan are eligible for the External assigner, not assigning anyone new.

[Beamanator]

This was tested! NAB!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [Fix] User mention is shown as Hidden #36358

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment (Needs manual offer from BZ)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh / @situchan] Determine if we should create a regression test for this bug.
• [@fedirjh / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lanitochka17]

@bondydaa Issue is not reproducible on the latest build 1.4.41-4

Screenrecorder-2024-02-14-22-37-37-928.mp4

[bondydaa]

great thanks!

[anmurali]

Payment not due for another 4 days. Rotated the label since I will be OOO till 29th!

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@bondydaa, @abekkala, @fedirjh, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abekkala]

PAYMENT SUMMARY FOR FEB 20

• Issue reported by: Applause - Internal Team
• Fix: @fedirjh [$500 - pending no regressions] Offer Link
• PR Review: @situchan [$500 - pending no regressions] Offer Link

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @fedirjh paid $(AMOUNT) via Upwork (LINK)
• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1757110933025804288/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

@fedirjh and @situchan payments were sent and contracts ended - thank you! 🎉