Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [Remove Free Workspace Creation] Update Welcome Message on NewDot #37152

Closed
tgolen opened this issue Feb 23, 2024 · 40 comments
Closed

[$500] [Remove Free Workspace Creation] Update Welcome Message on NewDot #37152

tgolen opened this issue Feb 23, 2024 · 40 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@tgolen
Copy link
Contributor

tgolen commented Feb 23, 2024

Update the workspace.inviteMessage.welcomeNote translation key in en.ts and es.ts to be:

#[senders display name] ([senders login]) invited you to Expensify
Hi there -

To join "[workspace name]", [click here](link) to start tracking your expenses!

They also added the message:
[Input message]

Additionally, here is the workspace description:
[Input description]
  • The first line of the message must be proceeded with the "#" so that it utilizes the backend functionality for custom subject lines (eg. the first line of the message gets parsed out and used as the subject for email notifications)
  • The "[Input message]" part of the message template is what currently exists in workspace.inviteMessage.welcomeNote
  • The template will need some new variables:
    • Senders display name and login
    • Workspace description
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0b03e2c9b6c2e93
  • Upwork Job ID: 1762127177147461632
  • Last Price Increase: 2024-02-26
  • Automatic offers:
    • dukenv0307 | Contributor | 0
    • rayane-djouah | Contributor | 0
@tgolen tgolen added Weekly KSv2 Improvement Item broken or needs improvement. Bug Something is broken. Auto assigns a BugZero manager. labels Feb 23, 2024
@tgolen tgolen moved this to Release 2: No New Free Workspaces in [#whatsnext] Wave 05 - Deprecate Free Feb 23, 2024
Copy link

melvin-bot bot commented Feb 23, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@eucool
Copy link
Contributor

eucool commented Feb 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Welcome Message on NewDot

What is the root cause of that problem?

We currently have the current welcomeNote as follows:

App/src/languages/en.ts

Lines 1844 to 1845 in 0e5dc98

welcomeNote: ({workspaceName}: WelcomeNoteParams) =>
`You have been invited to ${workspaceName || 'a workspace'}! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.`,

This is the same for Spanish translation in es.ts.

What changes do you think we should make in order to solve the problem?

The first line would be
#[senders display name] ([senders login]) invited you to Expensify
As mentioned # is important as the BE will convert it to the subject header of mail.

Then it would be:

Hi there -

To join "[workspace name]", [click here](link) to start tracking your expenses!

They also added the message:

`You have been invited to ${workspaceName || 'a workspace'}! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.`

Additionally, here is the workspace description: 

Note: we will pass the parameters Senders display name and login, Workspace description, and workspace name separately

Same would be done for the spanish translation

What alternative solutions did you explore? (Optional)

N/A

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@tgolen tgolen added the External Added to denote the issue can be worked on by a contributor label Feb 26, 2024
@melvin-bot melvin-bot bot changed the title [HOLD] [Wave 5 - Remove Free Workspace Creation] Update Welcome Message on NewDot [$500] [HOLD] [Wave 5 - Remove Free Workspace Creation] Update Welcome Message on NewDot Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b0b03e2c9b6c2e93

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Welcome Message on NewDot

What is the root cause of that problem?

This is a feature request

What changes do you think we should make in order to solve the problem?

We need to update the workspace.inviteMessage.welcomeNote key to something like below:

welcomeNote: ({workspaceName, senderDisplayName, senderLogin, workspaceDescription, workspaceLink}: WelcomeNoteParams) => `
#${senderDisplayName} (${senderLogin}) invited you to Expensify
Hi there -

To join "${workspaceName}", [click here](${workspaceLink}) to start tracking your expenses!

They also added the message:
You have been invited to ${workspaceName || 'a workspace'}! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.

Additionally, here is the workspace description:
${workspaceDescription}
            `

Then when we use it, we should fill in the proper params for workspaceName, senderDisplayName, senderLogin, workspaceDescription. There're some edge cases like: senderDisplayName, senderLogin, workspaceDescription could be empty, then some parts of the message relating to those need to be omitted. For example, if the workspaceDescription is empty, the Additionally, here is the workspace description: part should not be included. Some minor conditioning logic will need to be added to the template to address these cases.

There could also be cases where the displayName and the login of the sender (current user) are the same, since the user did not set any custom names, in this case we likely should only include the displayName (equal to login) in the template, but this will be subject to the design team's decision. If the displayName is empty, we also should only show ${senderLogin} instead of #${senderDisplayName} (${senderLogin}).

Some further notes:

  • The workspaceLink is likely just our app domain (depending on the environment, for example on prod: https://new.expensify.com/) so the user can quickly click to login. This is the same as in the email sent to the invited user's email. If it's other links (like Workspace chat/settings link) then we'll use that.
  • The senderLogin (with SMS removed and proper phone number formatting) and senderDisplayName can be easily retrieved from the current logged in user's personal details
  • Workspace description will be the description field of the policy. However this field could be HTML, we need to decide how we want for format this to put in the template. I think stripping the HTML in this case should be fine, or we can convert the HTML back to markdown.

These cases can be addressed during the PR.

Similar changes will be needed for the ES translation.

What alternative solutions did you explore? (Optional)

For cases where senderDisplayName, senderLogin, workspaceDescription could be empty

@ghost
Copy link

ghost commented Feb 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Wave 5 - Remove Free Workspace Creation] Update Welcome Message on NewDot

What is the root cause of that problem?

Here, in the file i.e. in en.ts file

App/src/languages/en.ts

Lines 1863 to 1864 in 9bfe961

welcomeNote: ({workspaceName}: WelcomeNoteParams) =>
`You have been invited to ${workspaceName || 'a workspace'}! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.`,

What changes do you think we should make in order to solve the problem?

We need to make changes in workspace.inviteMessage.welcomeNote according to the above mentioned i.e. comment

What alternative solutions did you explore? (Optional)

N/A

@jayeshmangwani
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the welcome Message when creating or inviting to workspace

What is the root cause of that problem?

its a feature, right now we are using the welcomeNote like this

welcomeNote: ({workspaceName}: WelcomeNoteParams) =>
    `You have been invited to ${workspaceName || 'a workspace'}! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.`,

What changes do you think we should make in order to solve the problem?

We need to add five params to the translation of the welcomeNote

  1. DisplayName and login of the admin
  2. Workspace name and Workspace invite link
  3. message added on the WorkspaceInviteMessagePage
  4. If Policy.description then show the last line
welcomeNote: ({
    displayName,
    login,
    workspaceName,
    workspaceLink,
    message,
    description,
})  =>  `#[${displayName}] ([${login}]) invited you to Expensify\n\n
            Hi there -\n\n
            
            To join ${workspaceName}, [click here](${workspaceLink}) to start tracking your expenses!\n\n
            
            They also added the message:\n
            ${message}\n\n
            
            ${description ? `Additionally, here is the workspace description:${description}`: ''}`,

What alternative solutions did you explore? (Optional)

none

@dukenv0307

This comment was marked as duplicate.

1 similar comment
@dukenv0307
Copy link
Contributor

Proposal updated to clarify the cases

@situchan
Copy link
Contributor

situchan commented Feb 28, 2024

reviewing

Edit: actually, this is on hold for 2 issues.

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@bfitzexpensify
Copy link
Contributor

Still held on #37151 and #37149

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@bfitzexpensify
Copy link
Contributor

#37151 and #37149 were deployed to prod yesterday, so you can proceed with proposal review @situchan!

@trjExpensify trjExpensify changed the title [$500] [HOLD] [Wave 5 - Remove Free Workspace Creation] Update Welcome Message on NewDot [$500] [HOLD] [Remove Free Workspace Creation] Update Welcome Message on NewDot Mar 6, 2024
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 1, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 1, 2024
@mallenexpensify mallenexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024
@mallenexpensify
Copy link
Contributor

@situchan is out OOO, reassigning a C+ via the auto-assigner for fairness.

Copy link

melvin-bot bot commented Apr 1, 2024

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Gonals Gonals self-assigned this Apr 4, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@youssef-lr, @Gonals, @bfitzexpensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dukenv0307
Copy link
Contributor

The PR just merged.

@rayane-djouah
Copy link
Contributor

@trjExpensify, Could you please assign me here? Thank you!

@trjExpensify
Copy link
Contributor

Done!

Copy link

melvin-bot bot commented Apr 16, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Copy link

melvin-bot bot commented Apr 22, 2024

@youssef-lr, @Gonals, @bfitzexpensify, @rayane-djouah, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 24, 2024

@youssef-lr, @Gonals, @bfitzexpensify, @rayane-djouah, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Apr 26, 2024

@youssef-lr, @Gonals, @bfitzexpensify, @rayane-djouah, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@rayane-djouah
Copy link
Contributor

Melvin didn't update the issue, #38023 (comment) PR is on production

@trjExpensify
Copy link
Contributor

@bfitzexpensify can you take care of prepping this issue for payment?

@bfitzexpensify
Copy link
Contributor

Payment complete.

This wasn't really a bug, and I don't see a need for a specific regression test for this. Closing this out.

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
No open projects
Archived in project
Status: Release 2: No New Free Workspaces
Development

No branches or pull requests