Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-03] [$1000] Android - LHN - Unable to open reports, tasks and threads in LHN #40048

Closed
1 of 6 tasks
m-natarajan opened this issue Apr 10, 2024 · 56 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Launch the app and log in with an existing account with multiple chats
  2. Open several reports, tasks, and threads

Expected Result:

All reports, tasks, and threads can be opened

Actual Result:

Some reports and tasks can be opened while I cannot open others. They are unresponsive to a tap.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445058_1712779979538.video_2024-04-10_16-12-01.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a5ce21b6eda6732
  • Upwork Job ID: 1778387468668194816
  • Last Price Increase: 2024-04-17
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #vip-vsb

@m-natarajan m-natarajan removed the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2024
@m-natarajan m-natarajan added the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Current assignee @roryabraham is eligible for the DeployBlockerCash assigner, not assigning anyone new.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

Can reproduce on Android, it seems that reports I haven't opened in a while won't open.

@dylanexpensify
Copy link
Contributor

@Julesssss shall we make external?

@Julesssss
Copy link
Contributor

@dylanexpensify I shared it in the channel seeking thoughts, but yeah lets open it up. I'll share it with contributors too and bump it to 500 for a solution that doesn't revert the architecture PR

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Apr 11, 2024
@melvin-bot melvin-bot bot changed the title Android - LHN - Unable to open reports, tasks and threads in LHN [$250] Android - LHN - Unable to open reports, tasks and threads in LHN Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012a5ce21b6eda6732

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@Julesssss Julesssss changed the title [$250] Android - LHN - Unable to open reports, tasks and threads in LHN [$500] Android - LHN - Unable to open reports, tasks and threads in LHN Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Upwork job price has been updated to $500

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@kbecciv
Copy link

kbecciv commented Apr 22, 2024

@roryabraham Removing the DeployBlockerCash label per your comment #40048 (comment)

@kbecciv kbecciv removed the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
@roryabraham roryabraham added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@parasharrajat, @roryabraham, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@roryabraham
Copy link
Contributor

Unfortunately we don't have a substantive update or minimal reproduction here. Posted about this issue here: https://expensify.slack.com/archives/C06UTGZBWCA/p1713807467633649

@roryabraham
Copy link
Contributor

Just merged #40905, which I confirmed fixes this issue 🎉

Going to let that go through full regressions rather than CPing it

Copy link

melvin-bot bot commented Apr 24, 2024

@parasharrajat @roryabraham @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

github-merge-queue bot pushed a commit to software-mansion/react-native-reanimated that referenced this issue Apr 25, 2024
## Summary

Fix for the issue: Expensify/App#40048 which
root cause of seems to be the not copied state of `ScrollView` when this
code is not added. I'll try to provide a simple repro when I get some
time to do it.

## Test plan
piaskowyk pushed a commit to software-mansion/react-native-reanimated that referenced this issue Apr 26, 2024
## Summary

Fix for the issue: Expensify/App#40048 which
root cause of seems to be the not copied state of `ScrollView` when this
code is not added. I'll try to provide a simple repro when I get some
time to do it.

## Test plan
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 26, 2024
@melvin-bot melvin-bot bot changed the title [$1000] Android - LHN - Unable to open reports, tasks and threads in LHN [HOLD for payment 2024-05-03] [$1000] Android - LHN - Unable to open reports, tasks and threads in LHN Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 26, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
  • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@parasharrajat] Determine if we should create a regression test for this bug.
  • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@parasharrajat
Copy link
Member

I didn't review the PR.

@dylanexpensify
Copy link
Contributor

Payment coming up

@dylanexpensify
Copy link
Contributor

Payment coming up!

@thienlnam
Copy link
Contributor

Was all internal / agency work - no payments needed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests