Save the world - Back button opens Save the world page with chat LHN instead of menu list

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Profile > Save the world > I know a teacher.
3. With RHP open, refresh the page.
4. Dismiss the RHP.
5. Click browser back button.

Expected Result:

App will reopen Save the world page with menu items on the left side bar.

Actual Result:

App reopens Save the world page with LHN instead of menu items from Settings.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6445407_1712811678074.bandicam_2024-04-11_12-57-46-351.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[shubham1206agra]

Related to #37175
cc @Ollyws @Amarparab2024

[shubham1206agra]

You forgot to do TAB_TO_CENTRAL_PANE_MAPPING and CENTRAL_PANE_TO_RHP_MAPPING.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Save the world - Back button opens Save the world page with chat LHN instead of menu list

What is the root cause of that problem?

We forgot to do TAB_TO_CENTRAL_PANE_MAPPING and CENTRAL_PANE_TO_RHP_MAPPING in #37175.

What changes do you think we should make in order to solve the problem?

Add in CENTRAL_PANE_TO_RHP_MAPPING

[SCREENS.SETTINGS.SAVE_THE_WORLD]: [SCREENS.I_KNOW_A_TEACHER, SCREENS.I_AM_A_TEACHER],

And update in TAB_TO_CENTRAL_PANE_MAPPING

[SCREENS.SETTINGS.ROOT]: [
        SCREENS.SETTINGS.PROFILE.ROOT,
        SCREENS.SETTINGS.PREFERENCES.ROOT,
        SCREENS.SETTINGS.SECURITY,
        SCREENS.SETTINGS.WALLET.ROOT,
        SCREENS.SETTINGS.ABOUT,
        SCREENS.SETTINGS.WORKSPACES,
        SCREENS.SETTINGS.SAVE_THE_WORLD,
    ],

What alternative solutions did you explore? (Optional)

NA

[Ollyws]

cc @Amarparab2024, if they're not around happy for @shubham1206agra to make a PR with their proposal and I can review.

[aeioual]

Will make a PR in an hour, Also can you check if this exists in production as well? (Be on setting page, open save the world and refresh again, i guess this must be a missed case which might be present in production as well)

…

On Thu, Apr 11, 2024 at 1:37 PM Olly ***@***.***> wrote: cc @Amarparab2024 <https://github.com/Amarparab2024>, if they're not around happy for @shubham1206agra <https://github.com/shubham1206agra> to make a PR with their proposal and I can review. — Reply to this email directly, view it on GitHub <#40084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFJQ62NTHD74TANKRWS3MXDY4ZAD5AVCNFSM6AAAAABGBZCP6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGE2TINRSGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[shubham1206agra]

Will make a PR in an hour, Also can you check if this exists in production as well? (Be on setting page, open save the world and refresh again, i guess this must be a missed case which might be present in production as well)

Sorry, but this is a new change. Production behaviour was in fact correct.

[aeioual]

@Ollyws , in the PR should I link this issue or The original issue? @shubham1206agra

[shubham1206agra]

This and original both.

[aeioual]

Cool, thanks :)

[puneetlath]

Marking as not a blocker as it seems like a very, very niche flow.

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[puneetlath]

I don't think this is worth worrying about right now, so going to close. Feel free to comment or reopen if you disagree.