[HOLD for payment 2024-06-06] [$250] Android - Distance - Waypoint does not change position correctly by dragging

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Request money > Distance.
3. Add three waypoints (A, B and C)
4. Drag the waypoint C over waypoint A.

Expected Result:

The waypoint sequence will now be C, A, B.

Actual Result:

The waypoint sequence is B, C, A. The "Start" waypoint is in the middle instead of at the top after dragging the distance.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445791_1712835794464.Screen_Recording_20240411_194116_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010257ce95cba77cc8
• Upwork Job ID: 1778535041816735744
• Last Price Increase: 2024-04-25
• Automatic offers:
• ishpaul777 | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[rlinoz]

Starting an android build to check what is happening

[rlinoz]

Having a really hard time building it, the build is getting fixed here #40102

[rlinoz]

Latest app is crashing when opening distance request page

Hmm, swtiching tabs fixed it?

[rlinoz]

Can reproduce though, not sure what broke it yet

[rlinoz]

This is not a backend issue and it is almost EOD for my, I am opening this for help.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010257ce95cba77cc8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[rlinoz]

Thinking more about this, I don't think it needs to be a blocker, the functionality still works (the start/stop are swapped and the map preview is updated) and it is working as intended in all other platforms.

Gonna go ahead and remove the label.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

@ishpaul777, PR ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @rlinoz, @jliexpensify, @Krishna2323, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ishpaul777]

we are actively working on the PR #41378, sorry for no updates on issue 🙇

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Android - Distance - Waypoint does not change position correctly by dragging. #41378

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary

• C: @Krishna2323 $250
• C+: @ishpaul777 $250

Upwork job

Just waiting on checklist

[jliexpensify]

Bumping @ishpaul777 for the checklist!

[jliexpensify]

Here's a new Upworks job because the previous one was closed automatically. Please accept invites @ishpaul777 and @Krishna2323

[ishpaul777]

I'll fill out checklist today.

[jliexpensify]

Bump @ishpaul777 to accept offer + complete checklist

[ishpaul777]

[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: #28618
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1631030961
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@ishpaul777] Determine if we should create a regression test for this bug. - Yes
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Launch New Expensify app.
2. Go to FAB > Request money > Distance.
3. Add three waypoints (A, B and C)
4. Drag the waypoint C over waypoint A.

Expected Result:

The waypoint sequence will now be C, A, B.

Do we 👍 or 👎 ?

[ishpaul777]

Sorry i left early yesterday, Accepted offer!

[jliexpensify]

Awesome, cheers - all paid and job closed.