Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace - Workspace chat member list does not remove user when user has left the chat #40417

Closed
6 tasks done
izarutskaya opened this issue Apr 18, 2024 · 27 comments
Closed
6 tasks done

Workspace - Workspace chat member list does not remove user when user has left the chat #40417

izarutskaya opened this issue Apr 18, 2024 · 27 comments
Assignees
@isabelastisser @MonilBhavsar @ikevin127
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 18, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace chat.
  4. Mention User B.
  5. Invite User B from the whisper.
  6. Send a message to the workspace chat.
  7. As User B, go to workspace chat.
  8. As User B, leave the workspace chat.
  9. As User A, click on the chat header > Members.

Expected Result:

User B will be removed from the workspace chat member list.

Actual Result:

User B is not removed from the workspace chat member list, even though User B has left the workspace chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6453287_1713425268442.left_workspace_member_list.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019627df30080310e8
  • Upwork Job ID: 1783472042234789888
  • Last Price Increase: 2024-04-25
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya izarutskaya removed the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
@github-actions github-actions bot mentioned this issue Apr 18, 2024
Closed
@NikkiWines
Copy link
Contributor

NikkiWines commented Apr 18, 2024 •
edited
Loading

I think this is a deploy blocker so re-adding the label

@NikkiWines NikkiWines added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Current assignee @NikkiWines is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NikkiWines
Copy link
Contributor

Possibly tied to #35671 cc: @MonilBhavsar @rezkiy37

@melvin-bot melvin-bot bot mentioned this issue Apr 18, 2024
Closed
@NikkiWines
Copy link
Contributor

@thienlnam since you're app deployer today, what're your thoughts? Looks like is an bug / edge-case not covered by a new feature. Not sure if we want to block the deploy on this given this functionality didn't exist previously so it's not really breaking existing features.

Maybe this can instead be patched as a follow up?

@thienlnam
Copy link
Contributor

Yeah I agree, this doesn't look like it needs to be a blocker

@NikkiWines NikkiWines added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 18, 2024
@NikkiWines
Copy link
Contributor

Cool, removing the label then and dropping priority

@MonilBhavsar
Copy link
Contributor

From a brief look, this looks like backend issue to me

@rezkiy37
Copy link
Contributor

Hey! High-priority tasks currently occupy me.

@NikkiWines
Copy link
Contributor

re-assigning to @MonilBhavsar per our discussion as he has context 🙇

@NikkiWines NikkiWines removed their assignment Apr 23, 2024
@MonilBhavsar MonilBhavsar mentioned this issue Apr 25, 2024
Merged
50 tasks
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Weekly KSv2 labels Apr 25, 2024
@MonilBhavsar
Copy link
Contributor

Looking into this now

@MonilBhavsar MonilBhavsar added the Internal Requires API changes or must be handled by Expensify staff label Apr 25, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019627df30080310e8

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 25, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ikevin127 (Internal)

@rezkiy37
Copy link
Contributor

Hey!
I just wanted to let you know about my vacation for next week. I will be back on 06.05.2024. Meanwhile, I asked @waterim to help with this issue.
See you soon!

@MonilBhavsar
Copy link
Contributor

PR is in review

@MonilBhavsar MonilBhavsar added the Reviewing Has a PR in review label Apr 26, 2024
@ikevin127
Copy link
Contributor

Will I be needed for review here ? 🙂

@MonilBhavsar
Copy link
Contributor

Issue is on server side and hence the PR. So not really, thank you though!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 3, 2024

@isabelastisser, @MonilBhavsar, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@isabelastisser
Copy link
Contributor

Hey,@ikevin12, can you please provide an update? Thanks!

@ikevin127
Copy link
Contributor

@isabelastisser I was told in #40417 (comment) that my help as a reviewer is not needed here since this is a server side issue and PR which I don't have access to review.

@isabelastisser
Copy link
Contributor

My bad, @MonilBhavsar, is there an update? Thanks!

@MonilBhavsar
Copy link
Contributor

PR was deployed last week.
We can close this out after creating regression test.

@MonilBhavsar
Copy link
Contributor

Regression test issue created https://github.com/Expensify/Expensify/issues/393485
... and closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isabelastisser isabelastisser

@MonilBhavsar MonilBhavsar

@ikevin127 ikevin127

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@NikkiWines @thienlnam @isabelastisser @MonilBhavsar @ikevin127 @rezkiy37 @izarutskaya