Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] Chat - Black Video Preview Issue in Concierge Welcome Message #40907

Closed
4 of 6 tasks
kbecciv opened this issue Apr 24, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.65-2
Reproducible in staging?: y
Reproducible in production?: new feature
Issue found when executing PR: #39687
Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in with a new account and complete the onboarding flow.
  2. Navigate to the Expensify Concierge welcome message.
  3. Move to another chat and then return to the Concierge message.

Expected Result:

The black preview of the Concierge video should not be displayed. Instead, a live preview should be shown.

Actual Result:

A black preview of the Concierge video is shown in the Expensify Concierge welcome message.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460317_1713966547065.Screen_Recording_2024-04-24_at_6.35.11_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f89966fcb2b8f2a8
  • Upwork Job ID: 1783161751164862464
  • Last Price Increase: 2024-04-24
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@tgolen
Copy link
Contributor

tgolen commented Apr 24, 2024

@filip-solecki Is this caused by the PR #39687?

@mountiny
Copy link
Contributor

It seems like this is happening with any video preview, discussing in this thread

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 24, 2024
@melvin-bot melvin-bot bot changed the title Chat - Black Video Preview Issue in Concierge Welcome Message [$250] Chat - Black Video Preview Issue in Concierge Welcome Message Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f89966fcb2b8f2a8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 Weekly KSv2 labels Apr 24, 2024
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 24, 2024
@NJ-2020
Copy link
Contributor

NJ-2020 commented Apr 25, 2024

I want to solve this issue, but after trying on the Expensify Staging website, your issue seems to be working properly.
I am using Windows operating system.
Can you please clarify?

2024-04-25.15-51-09.mp4

Copy link

melvin-bot bot commented Apr 25, 2024

📣 @NJ-2020! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@NJ-2020
Copy link
Contributor

NJ-2020 commented Apr 25, 2024

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01ff73ff788ecf5f2e

Copy link

melvin-bot bot commented Apr 25, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@tgolen tgolen removed their assignment Apr 25, 2024
@tgolen
Copy link
Contributor

tgolen commented Apr 25, 2024

@francoisl I think you were looking into this one, so I'm going to assign it to you.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 25, 2024
@melvin-bot melvin-bot bot changed the title [$250] Chat - Black Video Preview Issue in Concierge Welcome Message [HOLD for payment 2024-05-02] [$250] Chat - Black Video Preview Issue in Concierge Welcome Message Apr 25, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 26, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-02] [$250] Chat - Black Video Preview Issue in Concierge Welcome Message [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] Chat - Black Video Preview Issue in Concierge Welcome Message Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 1, 2024
Copy link

melvin-bot bot commented May 3, 2024

Issue is ready for payment but no BZ is assigned. @muttmuure you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented May 3, 2024

Payment Summary

Upwork Job

  • ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1783161751164862464/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@francoisl
Copy link
Contributor

This was handled and reviewed internally.

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants