[$250] [Live Markdown] Does not recognize blank quoted lines

[thienlnam]

Live markdown does not recognize blank quoted lines
Actual

Expected

cc @tomekzaw

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad3446a3440e57ed
• Upwork Job ID: 1783911251734421504
• Last Price Increase: 2024-05-10
• Automatic offers:
• hungvu193 | Reviewer | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad3446a3440e57ed

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[skyweb331]

Duplicated issue #40571

#41110 (comment)

cc @jjcoffee

[melvin-bot]

@trjExpensify, @hungvu193, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hungvu193]

@jjcoffee Can you confirm the above comment?

[jjcoffee]

@hungvu193 This is not a duplicate as far as I can tell, the other issue doesn't relate to Live Markdown.

[skyweb331]

@hungvu193 I am sorry. #40571 is to parse HTML to MarkDown correctly.
This issue is parsing Markdown to HTML and after finishing edit, it is saved correctly. Just live preview does not show correctly.

[skyweb331]

As far as I investigated, this is related to https://github.com/Expensify/react-native-live-markdown which is developed by software-mansion

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[KartikeyNamdev]

To fix this, you can try inserting an invisible character in place of the empty line.

[melvin-bot]

📣 @KartikeyNamdev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hungvu193]

To fix this, you can try inserting an invisible character in place of the empty line.

Thank you. Please post a proposal following our contributing guides here

[trjExpensify]

@thienlnam are you expecting someone from SWM to pick this up?

[thienlnam]

@robertKozik Any interest in this one or should we just leave it as external?

[trjExpensify]

@BrtqKr do you have a PR for this one yet?

[melvin-bot]

@trjExpensify @hungvu193 @thienlnam @BrtqKr this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[BrtqKr]

@trjExpensify turns out it requires changes to the blockquote regex in ExpensiMark, someone from our team will take a look and we'll pass it to further if everything is fine Expensify/expensify-common#706

[BrtqKr]

So there are actually couple of behaviors I must confirm:

• firstly because we're not enforcing any of the chat restrictions to the input itself (maximum number of nested quotes, the fact that the chat won't accept an empty message) the result is getting parsed slightly differently. For example, when we try to input "> > >" the result is going to be two blockquotes and ">" treated as a character because three blockquotes would cause an empty message error. The same happens for many nested blockquotes - we're not limiting it in the chat input. The first point is more important because it results from the empty blockquote regex changes.

• secondly, the styling of the blockquotes is already broken. The paddings for the nested blockquotes are causing height differences between the containers, and the min-height of the container isn't set, so when we try to insert empty blockquotes, we end up with the situation presented below.

Since all those things are already present in the app and would also require changes in expensify-app repository, maybe we should handle them separately as a whole in another ticket?
Regarding the restrictions on live markdown content, this is something I must confirm, because I'm not sure what changes would need to be made.

[thienlnam]

I can't find the conversation where it was discussed, but I think we landed on a spot where it is intentional that we don't limit the amount of nested quotes in the input

However, the styling of block quotes can be addressed in a separate ticket

[trjExpensify]

Okay, so what's the next step here?

[thienlnam]

We've merged the PR for this issue, we'll need to have another PR that bumps the expensify-common version in App to complete this issue.

I'll create another App issue to address the padding in nested block quotes

[trjExpensify]

Second PR in review.

[trjExpensify]

Oh wait.. that's a different issue. Do we have the PR for bumping expensify-common, @thienlnam?

[thienlnam]

So looks like the changes made were included in v2.0.8

Looks like on main we're already on expensify-common 2.0.10

So looks like we're good here actually

[trjExpensify]

Meaning.. we close this issue or something else? The first PR didn't have a C+, so I think we can close if there's nothing more to do.

[BartoszGrajdek]

Meaning.. we close this issue or something else?

I believe so, the fix is already on staging (on prod too I think), you can try testing it out yourself 🙌🏻

[thienlnam]

We can close here - looks like everything was handled by expert contributors or internal reviewers