Allow empty blockquotes #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
BrtqKr
force-pushed
the
brtqkr/41107-empty-blockquotes
branch
from
fa5182a to
5131c1b
Compare
melvin-bot
bot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
approved these changes
Jun 4, 2024
|
@stitesExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
melvin-bot
bot
added
the
Emergency
|
🚀Published to npm in v2.0.8 |
stitesExpensify
removed
the
Emergency
|
Hmm it does look like CLA failed, but the comment says |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we parse blockquotes in shouldKeepRawInput mode - empty blockquotes will not be excluded by the regex.
Fixed Issues
$ Expensify/App#41107
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
There are no tests verifying the shouldKeepRawInput flag paths, but all the existing tests are passing as expected (the logic is supposed to change only for the react-native-live-markdown).
What tests did you perform that validates your changed worked?
I verified how it works by applying a proper patch including a modified regex in react-native-live-markdown.
QA
What does QA need to do to validate your changes?
bump expensify-common version in E/App and use chat normally - sent messages should be parsed with the new rule
What areas to they need to test for regressions?
All quotes usage scenarios are vulnerable to regressions