[$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703397
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: the user must have created a Workspace and have enabled Workflows.

1. Go to Settings > Workspaces > Workspace > Workflows.
2. Tap on "Connect bank account".
3. Select "Connect manually".
4. Go trough the add bank account process using the testing credentials.
5. Once you reach the Incorporation state page on the Company info section, tap on the field and try to select a state.

Expected Result:

Once the user taps on an option, the selected option should be displayed on the Incorporation state field and the user should be able to continue with the add bank account process.

Actual Result:

Once the user taps on an option, "Hmm... it's not here" page is displayed and the user is not able to continue with the add bank account process.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6536449_1720481576566.Ooji8370_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f7892dcd73eb461
• Upwork Job ID: 1810720111946419022
• Last Price Increase: 2024-07-09

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[danieldoglas]

Doesn't look related to backend changes. Removing the label.

[Julesssss]

Hey @izarutskaya, what is the reason that we cannot test this in prod?

Reproducible in production?: Unable to check

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Once the user taps on an option, "Hmm... it's not here" page is displayed and the user is not able to continue with the add bank account process.

What is the root cause of that problem?

We're removing the params (policyID) when navigating to state selector page

App/src/components/StateSelector.tsx

Line 92 in d486302

const activeRoute = Navigation.getActiveRouteWithoutParams();

That why when users go back, the policy is empty -> not found page is shown

What changes do you think we should make in order to solve the problem?

We should not remove policyID

Solution 1: add new params to the function getActiveRouteWithoutParams named excludedParams: str[], then we don't remove the excludedParams. In this case we pass policyID

Solution 2: Check the route has policyID, if there is, we will use getActiveRoute instead. Because getActiveRouteWithoutParams is used in profile page only

What alternative solutions did you explore? (Optional)

[Julesssss]

@dominictb these options make sense to me. I like solution 2 for now as we don't need a more complex and scalable solution yet.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f7892dcd73eb461

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[Julesssss]

Hi @s77rt can you please review the proposal above, ideally using solution 2?

We need the solution to resolve two bugs, so the changes will need to pass the test cases listed below:

• [$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state #45060
• [CP Staging] fix: Country field reverts to the previous selection #44981

[dangrous]

2 makes sense to me as well but happy to hear what @s77rt says.

Alternately - do we want to get @nkdengineer / @hoangzinh on this since it seems like a regression from #44981 ?

[s77rt]

@dominictb Your RCA is correct. However regarding the solution I would prefer to revert #44981 being a workaround, the backTo param shouldn't be manipulated. Then we need to find another solution for #44957. The RCA for that issue is not totally clear.

If we look at the param in the URL path when selecting state, we'll see that &country=AQ (old country code) is there

Why do we even have that param in the backTo param if the original page didn't have it?

Screen.Recording.2024-07-09.at.7.34.39.PM.mov

cc @nkdengineer

[mountiny]

cc @mateuuszzzzz seems like the issue is not completely fixed

[mountiny]

@s77rt This is last of 2 blockers, I think the issue that @nkdengineer PR fixed was less severe, user could still add the correct country and state afterwards I assume.

So maybe we can demote that one and revert the CPed change to fix this issue. To unblock a deploy

[s77rt]

@mountiny I agree. Let's revert the PR

[mountiny]

Ok I have raised the revert PR here #45121 and going to demote the other issue

[mountiny]

The PR will be QAed in staging