Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "fix: Country field reverts to the previous selection" #45121

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Jul 9, 2024

Reverts #44981

Fixes #45060

Brings back #44957 but that is less severe so to unblock the deploy, we are going to revert this fix

QA steps

Pre-requisite: the user must have created a Workspace and have enabled Workflows.

  1. Go to Settings > Workspaces > Workspace > Workflows.
  2. Tap on "Connect bank account".
  3. Select "Connect manually".
  4. Go trough the add bank account process using the testing credentials.
  5. Once you reach the Incorporation state page on the Company info section, tap on the field and try to select a state.
  6. Once the user taps on an option, the selected option should be displayed on the Incorporation state field and the user should be able to continue with the add bank account process.

@mountiny mountiny self-assigned this Jul 9, 2024
@mountiny mountiny requested a review from a team as a code owner July 9, 2024 21:15
@melvin-bot melvin-bot bot removed the request for review from a team July 9, 2024 21:15
Copy link

melvin-bot bot commented Jul 9, 2024

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from marcochavezf July 9, 2024 21:15
Copy link
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@mountiny mountiny changed the title [CP Staging] Revert "[CP Staging] fix: Country field reverts to the previous selection" [CP Staging] Revert "fix: Country field reverts to the previous selection" Jul 9, 2024
@mountiny mountiny merged commit f3ef92e into main Jul 9, 2024
12 of 17 checks passed
@mountiny mountiny deleted the revert-44981-fix/44957 branch July 9, 2024 21:35
@melvin-bot melvin-bot bot added the Emergency label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Jul 9, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Jul 9, 2024

Straight revert

OSBotify pushed a commit that referenced this pull request Jul 9, 2024
[CP Staging] Revert "fix: Country field reverts to the previous selection"

(cherry picked from commit f3ef92e)
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2024

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.5-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state
3 participants