[$250] Address - Country field reverts to the previous selection after selecting a new state

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Profile
3. Click Address
4. Click Country
5. Select a country
6. Enter a US address and select any US address
7. Click State
8. Select a different state

Expected Result:

The country field will not revert to the previous selection after selecting a new state

Actual Result:

The country field reverts to the previous selection after selecting a new state

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535805_1720442346387.country.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0114854c60bfc7069c
• Upwork Job ID: 1810317607567373547
• Last Price Increase: 2024-07-08
• Automatic offers:
• hoangzinh | Contributor | 103031606
• nkdengineer | Contributor | 103032506

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@lakchote FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Julesssss]

I see no obvious cause in our checklist so far...

[lakchote]

I found the culprit, it's #43348

cc @mountiny

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0114854c60bfc7069c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[lakchote]

I've talked with @mountiny on the matter, refactoring was difficult to undertake, as such we should try to find the issue and fix.

Which is why I've made it External.

[nkdengineer]

@lakchote @mountiny I'm happy to raise PR asap if assigned

Proposal

Please re-state the problem that we are trying to solve in this issue.

The country field reverts to the previous selection after selecting a new state

What is the root cause of that problem?

In

App/src/components/StateSelector.tsx

Line 92 in e7a46a5

const activeRoute = Navigation.getActiveRoute();

, we use getActiveRoute, not getActiveRouteWithoutParams like in CountrySelector

App/src/components/CountrySelector.tsx

Line 78 in e7a46a5

const activeRoute = Navigation.getActiveRouteWithoutParams();

So the param of the old country left over in the route param is still used, and the country gets updated to the old value. If we look at the param in the URL path when selecting state, we'll see that &country=AQ (old country code) is there, means the route we're using is wrong (it contains outdated param)

What changes do you think we should make in order to solve the problem?

In StateSelector here

App/src/components/StateSelector.tsx

Line 92 in e7a46a5

const activeRoute = Navigation.getActiveRoute();

, use getActiveRouteWithoutParams like in CountrySelector

const activeRoute = Navigation.getActiveRouteWithoutParams();

What alternative solutions did you explore? (Optional)

[mountiny]

@nkdengineer We had to revert your change here #45121 as as it led to worse blocker.

Lets find a proper solution for this issue and make sure #45060 is not brought back. cc @mateuuszzzzz can help maybe

[nkdengineer]

I'll raise follow PR soon

[mountiny]

@nkdengineer lets try to identify the root cause as @s77rt highlighted it seems like we are still not clear on that

[zfurtak]

hi there 😊 after investigation, me and @mateuuszzzzz came to a conclusion that the problem here is connected to navigation. 🤔
Function getActiveRoute() was returning wrong path (with previously selected country) and the result was being passed to backTo param.
I made a PR with a fix for that problem. 👩🏽‍💻

[mountiny]

Thank you! PR merged

[hoangzinh]

PR #45394 (comment) has been deployed to Prod since last week. It's payment time :yay:

[hoangzinh]

@lakchote already found the offending PR #44957 (comment). Therefore we don't need a BZ checklist 🤔

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[puneetlath]

@mountiny can you help me understand what needs to happen here. I see that both @s77rt and @hoangzinh reviewed this PR. Do they both need to be paid?

[s77rt]

@puneetlath Only @hoangzinh is due payment

[puneetlath]

Got it! @hoangzinh has been paid.

@mountiny is @nkdengineer due any payment here?

[hoangzinh]

I think nope. @nkdengineer's PR has been reverted here #44957 (comment).

[puneetlath]

Ok going to go ahead and close this out then. Thanks everyone!

[mountiny]

Thanks for handling