[HOLD for payment 2024-11-14] HOLD ON PR #52228 [$250] ND app hangs at the splash screen when on a bad connection and opening after a while

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1728600237229689

Action Performed:

1. Be on a bad connection
2. Open the ND

Expected Result:

ND should open and should not stuck on the splash screen

Actual Result:

ND is stuck at the splash screen and refreshing the screen logs user out

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence


View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852278098288894434
• Upwork Job ID: 1852278098288894434
• Last Price Increase: 2024-11-01

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @zirgulis

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[twisterdotcom]

So far, I am unable to recreate.

[twisterdotcom]

Gonna close this as I cannot recreate after a few times testing this week.

511885.mp4

[muttmuure]

@zirgulis is going to update the unit test which is meant to be catching this bug

[muttmuure]

@zirgulis please can you comment for assignment?

[muttmuure]

Bump @zirgulis

[zirgulis]

@muttmuure test PR #51805

[allgandalf]

I was assigned to review the PR, does it require a C+ review ?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA]: Add test to reauthenticate offline user #51805

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @zirgulis does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[neil-marcellini]

Hi, I was linked over to the PR that recently updated the test from the issue I'm working on #51707. It sounds like these issues might be very similar. What's the plan to fix this issue? I think the solution to my issue is to retry re-authentication if it's failing, but I'm not sure if that will fix this one too.

I see you're adding tests to improve this, but that can't solve the issue, and shouldn't the tests you're adding be failing tests, not passing ones? I'm confused.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @zirgulis is from an agency-contributor and not due payment
• C+: @allgandalf paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/104898191)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1852278098288894434/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[twisterdotcom]

@zirgulis and @allgandalf please see @neil-marcellini's Q above.

[zirgulis]

@neil-marcellini @twisterdotcom the proposed approach to tackle this issue was firstly to fix the test which check's if the user is still logged in after reauthentication while offline.

Steps to fix it:

1. Add a a test which reproduces the issue. My PR: [No QA] [HOLD ON PR #52228] Improve simulating online/offline conditions in reauthentication test #52165
2. Add a fix to the reauth flow. @neil-marcellini PR: Fix re-authentication when it fails to fetch #52228
3. Make sure the the updated test (step 1) passes with the fix (step 2).

Regarding step 3 it seems the test itself works with that fix but there are general issues with the network tests suite. I left more detailed explanation here

[melvin-bot]

@madmax330, @twisterdotcom, @zirgulis, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

As discussed over here: https://expensify.slack.com/archives/C05LX9D6E07/p1731940801581519?thread_ts=1728600237.229689&cid=C05LX9D6E07

Let's focus on getting this PR done: #52228

[muttmuure]

Putting this issue on hold while we wait for the PR to be completed

[zirgulis]

@neil-marcellini @allgandalf @muttmuure I opened a new PR which incorporates changes by Neil and in addition:

• reverted reauth test
• reverted RequestThrottle to be function based
• fixed flaky network tests
• add improved reauth while offline test

[neil-marcellini]

Thanks @zirgulis, I will review that one and maybe add some of my own commits there too. All those points sound good, except I do think we should have the RequestThrottle for re-auth separate from the one for the sequential queue, which is why I made it a class.

[muttmuure]

This was merged - #52727

So I think we are good to unhold this one and also add retest label

[mvtglobally]

Issue not reproducible during KI retests. (First week)