[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Chat - There is no “Take a 2-minute tour” task at the Concierge chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with the new Gmail account in incognito mode
3. Complete the incorporation process using the option “Track and Budge Expenses”
4. Enter a first name and click on the Continue button
5. Go to the Concierge chat.

Expected Result:

A task “Take a 2-minute tour” must be displayed in the Concierge chat

Actual Result:

The “Take a 2-minute tour” task is not displayed in the Concierge chat. In some cases when executing the tour action, you hear the sound as of a completed task but nothing is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-11-22.23-24-32-898.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

Bug6673595_1732311343627.Issue.mp4

[chiragsalian]

Both the recorded videos are of production so i think maybe you made a mistake there? Can you double check @lanitochka17.

I tested the same steps on staging with a new account and i see Take a 2-minute tour.

[lanitochka17]

sorry for confusion
correct video:

bandicam.2024-11-22.23-24-32-898.mp4

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2024-11-22 22:31:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Take a 2-minute tour is not shown in concierge for Track and Budge Expenses

What is the root cause of that problem?

we did not include selfGuidedTourTask in the tasks if the tour purpose is combinedTrackSubmitOnboardingChoices.PERSONAL_SPEND:
in

App/src/CONST.ts

Lines 212 to 226 in 3ebe852

	const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = {
	...onboardingPersonalSpendMessage,
	tasks: [
	{
	type: 'trackExpense',
	autoCompleted: false,
	title: 'Track an expense',
	description:
	'*Track an expense* in any currency, whether you have a receipt or not.\n' +
	'\n' +
	'Here’s how to track an expense:\n' +
	'\n' +
	'1. Click the green *+* button.\n' +
	'2. Choose *Create expense*.\n' +
	'3. Enter an amount or scan a receipt.\n' +

What changes do you think we should make in order to solve the problem?

add selfGuidedTourTask to it as:

const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = {
    ...onboardingPersonalSpendMessage,
    tasks: [
+        selfGuidedTourTask,

        {
            type: 'trackExpense',

Screen.20Recording.202024-11-23.20at.204.mp4

[chiragsalian]

Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀

[chiragsalian]

But yeah your solution works @Shahidullah-Muffakir, feel free to create the PR. I will be heading out now but we can CP it early on Monday.

[Shahidullah-Muffakir]

Woah, if i add a first and last name it works. But if i add only first name i don't see "Take a 2-minute tour", weird. Do you know why @Shahidullah-Muffakir? 👀

@chiragsalian, Not sure, I could produce the issue even by entering first and last name.

[Shahidullah-Muffakir]

But yeah your solution works @Shahidullah-Muffakir, feel free to create the PR. I will be heading out now but we can CP it early on Monday.

@chiragsalian, Sure, Thank you.

[c3024]

PR #52912 opened for fixing all missing cases of tasks. This should be fixed too in that PR.

cc: @rushatgabhane @chiragsalian @jjcoffee @NJ-2020

[c3024]

This is also on production. It is just that this can be seen only in cases where account id is even.

App/src/libs/Permissions.ts

Lines 34 to 35 in 8c4661d

	const session = SessionUtils.getSession();
	return isAccountIDEven(session?.accountID ?? -1);

Perhaps, this need not be a deploy blocker.

cc: @mountiny

[mountiny]

I went ahead and merged and CPed the fix from @Shahidullah-Muffakir as they were assigned and already had the Pr ready and reviewed and tested.

@c3024 please continue with the fix in your linked PR

[chiragsalian]

It is just that this can be seen only in cases where account id is even.

Wow that's why it was inconsistent for me. Good to know.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] display "Take a 2-minute tour" task in Concierge chat for "Track and Budge Expenses" #52990

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] display "Take a 2-minute tour" task in Concierge chat for "Track and Budge Expenses" #52990

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @CortneyOfstad you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @Shahidullah-Muffakir paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@CortneyOfstad)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[CortneyOfstad]

@Shahidullah-Muffakir can you confirm if this needs a regression test?

Also, I've sent you a proposal here in Upwork — please let me know once you accept. Thanks!

[Shahidullah-Muffakir]

@Shahidullah-Muffakir can you confirm if this needs a regression test?

Also, I've sent you a proposal here in Upwork — please let me know once you accept. Thanks!

@CortneyOfstad ,
@brunovjk has reviewed the PR as C+.
Offer Accepted, Thanks!

[CortneyOfstad]

Oops, sorry about that! @brunovjk can you confirm if this needs a regression test? Thanks!

Also, it looks like you need payment as well — going to whip up an Upwork proposal and get that sent over ASAP!

[brunovjk]

No problem, I was missing that too :D thanks for letting us know @Shahidullah-Muffakir. I'll fill out the BZ checklist in a moment. Thanks @CortneyOfstad

[CortneyOfstad]

@brunovjk proposal has been sent here!

[brunovjk]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: Applause - Internal Team

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [Self-guided tours][V2] Add tour links to onboarding tasks #51153 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

1. Log in with a new account
2. Complete the onboarding process by selecting Track and Budget Expenses in the onboarding flow.
3. Verify the Take a 2-minute tour task appears in the Concierge chat.

Do we agree 👍 or 👎

[brunovjk]

All yours @CortneyOfstad :D

[rayane-djouah]

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
  Link to comment: Tasks for guided setup #39951 (comment)

Actually, the issue was introduced by this PR: #51153. The self guided tour task did not exist when we implemented this PR :)

[brunovjk]

I updated the BZ checklist and posted the comment in the aforementioned PR. Thank you @rayane-djouah

[CortneyOfstad]

Payment Summary

@brunovjk — paid $250 via Upwork
@Shahidullah-Muffakir — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/451766