-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] display "Take a 2-minute tour" task in Concierge chat for "Track and Budge Expenses" #52990
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native52990_android_native.movAndroid: mWeb Chrome52990_android_web.moviOS: Native52990_ios_native.moviOS: mWeb Safari52990_ios_web.movMacOS: Chrome / Safari52990_web_chrome.movMacOS: Desktop52990_web_desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] display "Take a 2-minute tour" task in Concierge chat for "Track and Budge Expenses" (cherry picked from commit 97fa65b) (CP triggered by mountiny)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.66-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.66-8 🚀
|
Explanation of Change
Ensure the Take a 2-minute tour task is created in Concierge chat when the user selects
Track and Budget Expenses
during the onboarding flow.Fixed Issues
$ #52985
PROPOSAL: #52985 (comment)
Tests
Track and Budget Expenses
in the onboarding flow.Take a 2-minute tour
task appears in theConcierge
chat.Offline tests
This feature requires internet
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.native.mov
Android: mWeb Chrome
android.chrome.mov
iOS: Native
ios.native.mov
iOS: mWeb Safari
ios.safari.mov
MacOS: Chrome / Safari
Screen.20Recording.202024-11-23.20at.204.mp4
MacOS: Desktop
macos.20desktop-2.mp4