Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-06-16 #9480

Closed
50 tasks done
OSBotify opened this issue Jun 16, 2022 · 18 comments
Closed
50 tasks done

Deploy Checklist: New Expensify 2022-06-16 #9480

OSBotify opened this issue Jun 16, 2022 · 18 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 16, 2022

Release Version: 1.1.78-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 17, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.78-0 🚀

@mvtglobally
Copy link

@francoisl Android build is still not updated. We are just waiting for the Android to finish up this checklist

@francoisl
Copy link
Contributor

@francoisl Android build is still not updated. We are just waiting for the Android to finish up this checklist

Yep thanks, we're looking into this. I'll let you know when we have an update.


Also, I'm checking 9487 from the blockers list based on this comment.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jun 20, 2022
@francoisl
Copy link
Contributor

We might have to wait a few more days for the new Android build.

For context, Google rejected the app saying that it didn't respect their Payments policy because we don't use Google Play's billing system. We believe they made a mistake, because their policy mandates that apps that use peer-to-peer payments should not use their billing system. We filed an appeal and are waiting to hear back from them.

@SumitDiyora
Copy link

SumitDiyora commented Jun 21, 2022

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9266, #9401, #9404, #9445, #9460, #9462, #9468, #9473
Logged Issues - #8432 , #9491 #8434 #8433 #8413 #8651 #8430 #8388 #8465 #8392 #8395 #8560 #8393 #8398 #8484 #8623 #8506 #9463 #8577

New PRs Added
Checked all new PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9450, #9458, #9471, #9482, #9475, #9490, #9488, #9502, #9523
Logged Issues - #8430, #8393, #8465, #8392, #8395, #8398, #8506, #9463, #8616, #8463, #8484, #8407, #8465, #8392, #8393, #8398, #8385, #9557, #8395, #8556, #8430, #8580, #8463, #8651, #8393, #8484, #9571

@mvtglobally mvtglobally added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Jun 21, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.78-7 🚀

@francoisl
Copy link
Contributor

francoisl commented Jun 24, 2022

@Expensify/applauseleads there should be a new build 1.1.78-8 rolling out - including on Android this time. Can you please resume QA from that version?

@sketchydroide
Copy link
Contributor

sketchydroide commented Jun 27, 2022

#9487 and #9564 no longer seem to be Deploy blockers and #9565 is closed and dusted
I would say once this latest build is QA we can ship this.

@Expensify/applauseleads can we excpect the QA to be done today?

@sketchydroide sketchydroide self-assigned this Jun 27, 2022
@mvtglobally
Copy link

@sketchydroide, Regression is completed. I am sending a summary in few min

@mvtglobally
Copy link

mvtglobally commented Jun 27, 2022

@sketchydroide @francoisl , Regression is completed.

PR #9031 is failing due to #9438. Not a blocker, so checking off
PR #9401 & PR #9445 are blocked by #9564. Blocker label was removed. are we ok to check it off then?
PR #9471 is failing due to #9533 Not a blocker, are we ok to check off?
PR #9490 is failing due to #9490. Not a blocker checking off
PR ##9496 is internal. Can you double check its ok to check it off?

Issues logged
#9485
#9487
#9533
#9535
#9539
#9541
#9542
#9564

@francoisl
Copy link
Contributor

PR #9401 & PR #9445 are blocked by #9564. Blocker label was removed. are we ok to check it off then?

Yes since there's also a similar issue with the production build. We'll reopen the GH issue to look into this. (cc @aldo-expensify @TomatoToaster)

@francoisl
Copy link
Contributor

francoisl commented Jun 27, 2022

PR #9471 is failing due to #9533 Not a blocker, are we ok to check off?

Double-checking now, but at first glance it looks like this wouldn't be a blocker indeed and we should be able to check it off.

PR #9490 is failing due to #9490. Not a blocker checking off

👍

PR ##9496 is internal. Can you double check its ok to check it off?

Yes this was a fix for iOS deploys not working, it's confirmed to work by the fact that we could CP and generate an iOS build.

@mvtglobally
Copy link

Great, Looks like we are good to 🚀

@sketchydroide
Copy link
Contributor

thanks @francoisl for going over those, I agree, I think those are not blockers

@sketchydroide
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Jun 28, 2022
@sketchydroide
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants