17049 - migrate RadioButton to PressableWithFeedback #20250

Skalakid · 2023-06-06T10:37:56Z

Details

Fixed Issues

Tests

[DEV] I think the simplest way to test it, without the account with a wallet, is to hardcode questions. You can do it by changing these lines in AdditionalDetailsStep.js:

        if (!_.isEmpty(this.props.walletAdditionalDetails.questions)) {
              ...
        }

to:

        const questions = [{answer: ['1251', '6253', '113', 'None of the above', 'Skip Question'], prompt: 'Which number goes with your address on MASONIC AVE?', type: 'street.number.b'}];
        if (!_.isEmpty(questions)) {
            return (
                <ScreenWrapper
                    style={[styles.flex1]}
                    keyboardAvoidingViewBehavior="height"
                >
                    <HeaderWithBackButton
                        title={this.props.translate('additionalDetailsStep.headerTitle')}
                        onBackButtonPress={() => Wallet.setAdditionalDetailsQuestions(null)}
                    />
                    <IdologyQuestions
                        questions={questions}
                        idNumber={this.props.walletAdditionalDetails.idNumber}
                    />
                </ScreenWrapper>
            );
        }

Access the Idology question section inside Enable Payments Page by entering:
http://localhost:8080/enable-payments
Click/Press the radio button, verify styling and behavior

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb-chrome.mov

Mobile Web - Safari

mWeb-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-06-06T10:38:30Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-06-06T15:35:24Z

@allroundexperts assigned you as a reviewer since you were assigned to the issue.

luacmartins · 2023-06-06T15:36:59Z

src/components/RadioButton.js

+        hoverDimmingValue={1}
+        pressDimmingValue={1}
+        accessibilityLabel={props.accessibilityLabel}
+        accessibilityRole="radio"


Maybe we should create a CONST for "radio"?

I think it will be added in #20251, so we can put this PR on hold until CONST values will be available

Yea, that seems fine. We could also add it in this PR in case it's merged first.

allroundexperts · 2023-06-06T21:19:27Z

@luacmartins How can I test this page? Do I need an account with special permissions?

luacmartins · 2023-06-06T22:13:49Z

@Skalakid could you please provide more details on Access the Idology question section inside Enable Payments Page?

allroundexperts · 2023-06-08T16:28:05Z

Bump on above @Skalakid!

luacmartins · 2023-06-08T17:53:24Z

@allroundexperts you can get to that page by:

Navigate to /settings/payments/enable-payments
In the form, enter first name Alberta, last name Bobbeth and SSN as 3333. Enter any data for the other fields. When you get an error regarding SSN, simply click Save & continue
You should see the KBA questions

allroundexperts · 2023-06-08T17:54:36Z

@allroundexperts you can get to that page by:

Navigate to /settings/payments/enable-payments

In the form, enter first name Alberta, last name Bobbeth and SSN as 3333. Enter any data for the other fields. When you get an error regarding SSN, simply click Save & continue

You should see the KBA questions

@luacmartins Thanks. I'll try this.

allroundexperts · 2023-06-08T20:49:33Z

@luacmartins I'm getting the following error after following the steps you mentioned above.

luacmartins · 2023-06-08T21:27:42Z

Hmm maybe my steps are not available in staging 🤔 @Skalakid how did you access that page in staging?

Skalakid · 2023-06-12T09:17:06Z

@allroundexperts @luacmartins I just described how to test this PR, but honestly, I don't know how to do it without changing the code. I was trying to test it using old PRs' test flows (like from #8009 or #9914) but I wasn't able to reproduce them :/

luacmartins · 2023-06-12T17:34:10Z

@allroundexperts can you just review the code? I'll complete the checklist and submit the videos

allroundexperts · 2023-06-12T17:35:00Z

@allroundexperts can you just review the code? I'll complete the checklist and submit the videos

Sure @luacmartins!

allroundexperts

Code wise, this looks good!

luacmartins · 2023-06-12T20:27:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

OSBotify · 2023-06-13T00:31:30Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T01:05:41Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-06-13T10:26:34Z

@Skalakid @luacmartins @allroundexperts do we need to QA this? Can you share clear QA steps

luacmartins · 2023-06-13T14:55:26Z

@mvtglobally I think it's fine to QA it as part of Wallet regression tests.

OSBotify · 2023-06-14T21:21:48Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

migrated RadioButton to PressableWithFeedback

2ea6b1e

Skalakid requested a review from a team as a code owner June 6, 2023 10:37

melvin-bot bot requested review from luacmartins and removed request for a team June 6, 2023 10:38

luacmartins requested a review from allroundexperts June 6, 2023 15:35

luacmartins approved these changes Jun 6, 2023

View reviewed changes

Merge branch 'main' into 17049-migrate-RadioButton

d8bce4d

allroundexperts approved these changes Jun 12, 2023

View reviewed changes

Expensify deleted a comment from allroundexperts Jun 12, 2023

luacmartins merged commit 28ad1da into Expensify:main Jun 12, 2023

OSBotify mentioned this pull request Jun 12, 2023

Deploy Checklist: New Expensify 2023-06-12 #20640

Closed

71 tasks

melvin-bot bot mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-06-21] [$250] [Group 5][Accessible Pressable] Migrate RadioButton #17049

Closed

payal-lathidadiya mentioned this pull request Jul 13, 2023

[NoQA] refactor: migrate RadioButtons to function component #22770

Merged

57 tasks

blazejkustra mentioned this pull request Oct 20, 2023

[No QA] [TS migration] Migrate 'FormScrollView.js' component to TypeScript #29757

Merged

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

17049 - migrate RadioButton to PressableWithFeedback #20250

17049 - migrate RadioButton to PressableWithFeedback #20250

Skalakid commented Jun 6, 2023 •

edited

Loading

melvin-bot bot commented Jun 6, 2023

luacmartins commented Jun 6, 2023

luacmartins Jun 6, 2023 •

edited

Loading

Skalakid Jun 7, 2023

luacmartins Jun 7, 2023

allroundexperts commented Jun 6, 2023

luacmartins commented Jun 6, 2023

allroundexperts commented Jun 8, 2023

luacmartins commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

luacmartins commented Jun 8, 2023

Skalakid commented Jun 12, 2023

luacmartins commented Jun 12, 2023

allroundexperts commented Jun 12, 2023

allroundexperts left a comment

luacmartins commented Jun 12, 2023 •

edited

Loading

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

mvtglobally commented Jun 13, 2023

luacmartins commented Jun 13, 2023

OSBotify commented Jun 14, 2023

17049 - migrate RadioButton to PressableWithFeedback #20250

17049 - migrate RadioButton to PressableWithFeedback #20250

Conversation

Skalakid commented Jun 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2023

luacmartins commented Jun 6, 2023

luacmartins Jun 6, 2023 • edited Loading

Choose a reason for hiding this comment

Skalakid Jun 7, 2023

Choose a reason for hiding this comment

luacmartins Jun 7, 2023

Choose a reason for hiding this comment

allroundexperts commented Jun 6, 2023

luacmartins commented Jun 6, 2023

allroundexperts commented Jun 8, 2023

luacmartins commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

luacmartins commented Jun 8, 2023

Skalakid commented Jun 12, 2023

luacmartins commented Jun 12, 2023

allroundexperts commented Jun 12, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

luacmartins commented Jun 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

mvtglobally commented Jun 13, 2023

luacmartins commented Jun 13, 2023

OSBotify commented Jun 14, 2023

Skalakid commented Jun 6, 2023 •

edited

Loading

luacmartins Jun 6, 2023 •

edited

Loading

luacmartins commented Jun 12, 2023 •

edited

Loading