refactor: refactor money request form #24274

koko57 · 2023-08-08T15:27:32Z

Details

Fixed Issues

$ #23149 (follow-up)
PROPOSAL: link to comments:
#23979 (comment)
#23979 (comment)
#23979 (comment)
#23979 (comment)
#23979 (comment)

under some of the comments I’ve left explanation why I had to solve it differently

Tests

Start an IOU flow (request money, split bill)
Verify that the value is stored correctly, the whole flow works as expected and there are no other errors

Verify that no errors appear in the JS console

Offline tests

QA Steps

Start an IOU flow (request money, split bill)
Verify that the value is stored correctly, the whole flow works as expected and there are no other errors

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

melvin-bot · 2023-08-08T15:27:35Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-08-09T17:24:30Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2023-08-09T18:33:30Z

Hey @marcaaron, reassigning you as I believe you're assigned to the issue.

marcaaron · 2023-08-09T21:41:24Z

@s77rt tagging you in on this one too since you reviewed the other! feel free to unassign if you have more pressing things.

s77rt · 2023-08-09T21:46:43Z

Will review asap

s77rt · 2023-08-10T00:17:31Z

src/pages/iou/steps/MoneyRequestAmountForm.js

@@ -194,7 +170,6 @@ function MoneyRequestAmountForm({amount, currency, isEditing, forwardedRef, onCu
        onSubmitButtonPress(currentAmount);
    }, [onSubmitButtonPress, currentAmount]);

-    const formattedAmount = MoneyRequestUtils.replaceAllDigits(currentAmount, toLocaleDigit);


This is still required otherwise you won't be able to request money with decimal comma (if lang is Spanish).

@s77rt yeah, you're right! Fixed!

s77rt · 2023-08-11T13:39:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

s77rt · 2023-08-11T13:43:58Z

Bug: [Android] When you try to edit the amount the cursor is placed at the wrong position

Kooha-2023-08-11-14-37-45.mp4

This seems related to the removal of selectedAmountAsString at first render. For some reason the useEffect is not fulfilling its role in Android.

koko57 · 2023-08-11T16:14:45Z

@s77rt Fixed!

s77rt · 2023-08-11T23:59:41Z

@koko57 Thank you!

s77rt

LGTM! 🚀

melvin-bot · 2023-08-12T00:06:22Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #24469.

marcaaron

This looks great thanks!

OSBotify · 2023-08-15T18:37:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:21:07Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:27:49Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:10:50Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

refactor: refactor money request form

d2e121d

koko57 marked this pull request as ready for review August 9, 2023 17:23

koko57 requested a review from a team as a code owner August 9, 2023 17:23

melvin-bot bot requested review from srikarparsi and removed request for a team August 9, 2023 17:24

srikarparsi requested review from marcaaron and removed request for srikarparsi August 9, 2023 18:32

marcaaron requested a review from s77rt August 9, 2023 21:40

marcaaron assigned koko57 Aug 9, 2023

s77rt suggested changes Aug 10, 2023

View reviewed changes

koko57 added 2 commits August 11, 2023 07:37

Merge branch 'main' into refactor/23149-follow-up-money-request-page

9a36ed2

fix: apply requested changes

a2dfa8e

koko57 requested a review from s77rt August 11, 2023 05:43

fix: restore selectedAmountAsString

347ccf1

s77rt approved these changes Aug 12, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Aug 12, 2023

Payment issue for E/App PR#24274 #24469

Closed

fix: resolve conflicts

cabcce4

marcaaron approved these changes Aug 15, 2023

View reviewed changes

marcaaron merged commit 2e8e699 into Expensify:main Aug 15, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

koko57 deleted the refactor/23149-follow-up-money-request-page branch September 28, 2023 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: refactor money request form #24274

refactor: refactor money request form #24274

koko57 commented Aug 8, 2023 •

edited

Loading

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 9, 2023

srikarparsi commented Aug 9, 2023

marcaaron commented Aug 9, 2023

s77rt commented Aug 9, 2023

s77rt Aug 10, 2023

koko57 Aug 11, 2023

s77rt commented Aug 11, 2023 •

edited

Loading

s77rt commented Aug 11, 2023

koko57 commented Aug 11, 2023

s77rt commented Aug 11, 2023

s77rt left a comment

melvin-bot bot commented Aug 12, 2023

marcaaron left a comment

OSBotify commented Aug 15, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

refactor: refactor money request form #24274

refactor: refactor money request form #24274

Conversation

koko57 commented Aug 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 9, 2023

srikarparsi commented Aug 9, 2023

marcaaron commented Aug 9, 2023

s77rt commented Aug 9, 2023

s77rt Aug 10, 2023

Choose a reason for hiding this comment

koko57 Aug 11, 2023

Choose a reason for hiding this comment

s77rt commented Aug 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Aug 11, 2023

koko57 commented Aug 11, 2023

s77rt commented Aug 11, 2023

s77rt left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 12, 2023

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 15, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

koko57 commented Aug 8, 2023 •

edited

Loading

s77rt commented Aug 11, 2023 •

edited

Loading