Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630

hungvu193 · 2023-08-16T15:40:34Z

Details

Fix: Copy to clipboard button does not copy content of an IOU edit comment

Fixed Issues

$ #24569
PROPOSAL: #24569 (comment)

Tests

Make money request from account A to account B
Click on the IOU preview component twice
Click on the amount and change it
Hover over the posted comment and click on copy to clipboard
Paste the content elsewhere
Verify that paste content matched with the copied content.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Make money request from account A to account B
Click on the IOU preview component twice
Click on the amount and change it
Hover over the posted comment and click on copy to clipboard
Paste the content elsewhere
Verify that paste content matched with the copied content.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-16.at.23.06.45.mov

Mobile Web - Chrome

Screen.Recording.2023-08-16.at.23.07.57.mov

Mobile Web - Safari

Screen.Recording.2023-08-16.at.23.11.13.mov

Desktop

Screen.Recording.2023-08-16.at.23.06.45.mov

iOS

Screen.Recording.2023-08-16.at.23.18.34.mov

Android

Screen.Recording.2023-08-16.at.23.07.57.mov

…mment

melvin-bot · 2023-08-16T16:22:15Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-08-16T16:23:05Z

@narefyev91 PR is ready for review! Please have a look, ty 😄

narefyev91 · 2023-08-17T09:38:57Z

@hungvu193 can you please update check list for IOS and Desktop - do not see preview videos (you need to add space before video link)
Also running on all platforms i see NaN for changed value

Also when i tried to copy message (no matter with copy button, or selecting all text) - i see test is doubled

hungvu193 · 2023-08-17T09:41:30Z

@narefyev91 I think NAN is another bug, I saw a report on slack too. Let me update the ios and desktop 😄

hungvu193 · 2023-08-17T09:43:30Z

Updated @narefyev91 😄

narefyev91 · 2023-08-17T09:59:50Z

@narefyev91 I think NAN is another bug, I saw a report on slack too. Let me update the ios and desktop 😄

Ok for NaN let's skip that - but i see duplication during copy - and it should be fixed in current PR

hungvu193 · 2023-08-17T10:01:35Z

@narefyev91 I think NAN is another bug, I saw a report on slack too. Let me update the ios and desktop 😄

Ok for NaN let's skip that - but i see duplication during copy - and it should be fixed in current PR

I saw that too, it happened after I merged my branch with latest main and that issue is out of scope for this PR I believe,
here's the slack report:
https://app.slack.com/client/T03SC9DTT/C049HHMV9SM

narefyev91 · 2023-08-17T14:09:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

8mb.video-L6w-jmPFJvBN.mp4

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

pecanoro · 2023-08-17T18:57:24Z

It works well except for the duplication issue. I tried opening the link for the bug report (https://app.slack.com/client/T03SC9DTT/C049HHMV9SM) but it is not redirecting me to the right place, can you link it again?

src/pages/home/report/ContextMenu/ContextMenuActions.js

hungvu193 · 2023-08-18T18:20:37Z

https://app.slack.com/client/T03SC9DTT/C049HHMV9SM

Ok, here's the GH issue about it:
#25409

hungvu193 · 2023-08-18T18:50:26Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

            const isReportPreviewAction = ReportActionUtils.isReportPreviewAction(reportAction);
            const message = _.last(lodashGet(reportAction, 'message', [{}]));
-            const messageHtml = lodashGet(message, 'html', '');
+            const originalMessage = _.get(reportAction, 'originalMessage', {});


We need originalMessage here because the taskAction doesn't have html field in our message object.
cc @narefyev91 @pecanoro

pecanoro · 2023-08-21T13:46:05Z

I am testing everything again before merging. @narefyev91 Can you test the PR again with the new changes?

narefyev91 · 2023-08-21T14:22:01Z

Web tested well - working fine
Desktop tested well - working fine
IOS tested well - working fine
IOS-web tested well - working fine
Android-web tested well - working fine
Android tested well - working fine

cc @hungvu193 @pecanoro

pecanoro · 2023-08-21T19:04:35Z

Damn, we have some conflicts!

hungvu193 · 2023-08-22T00:40:27Z

@pecanoro Resolved! But I'm not sure why these tests are failed 🤦

hungvu193 · 2023-08-22T02:31:47Z

re-run test

hungvu193 · 2023-08-22T02:33:12Z

Oops, seems mapbox sdk is required to run the test 🤦 .
Here's the slack convo btw:
https://expensify.slack.com/archives/C01GTK53T8Q/p1692671810391089

pecanoro · 2023-08-22T12:27:17Z

Working well, thank you!

OSBotify · 2023-08-22T12:31:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-24T03:36:22Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:53:54Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:08:03Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:22:56Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix: Copy to clipboard button does not copy content of an IOU edit co…

fe13270

…mment

hungvu193 force-pushed the fix-24569 branch from a3b9467 to fe13270 Compare August 16, 2023 15:50

hungvu193 marked this pull request as ready for review August 16, 2023 16:22

hungvu193 requested a review from a team as a code owner August 16, 2023 16:22

melvin-bot bot requested review from narefyev91 and removed request for a team August 16, 2023 16:22

narefyev91 approved these changes Aug 17, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro August 17, 2023 14:10

pecanoro requested changes Aug 17, 2023

View reviewed changes

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

update copy for taskAction

89c75f6

hungvu193 force-pushed the fix-24569 branch from 4bb9c12 to 89c75f6 Compare August 18, 2023 18:43

hungvu193 commented Aug 18, 2023

View reviewed changes

pecanoro previously approved these changes Aug 21, 2023

View reviewed changes

sync with main

6cf4fd2

hungvu193 dismissed pecanoro’s stale review via 6cf4fd2 August 22, 2023 00:38

Merge remote-tracking branch 'origin/main' into fix-24569

88a7c38

pecanoro approved these changes Aug 22, 2023

View reviewed changes

pecanoro merged commit 600b089 into Expensify:main Aug 22, 2023

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

lanitochka17 mentioned this pull request Aug 24, 2023

Android - Request money - App crashes when editing Amount twice #25841

Closed

6 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

melvin-bot bot mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

Closed

6 tasks

parasharrajat mentioned this pull request Sep 6, 2023

[$500] The updated amount is not copied to clipboard. #26664

Closed

6 tasks

pecanoro mentioned this pull request Sep 12, 2023

[$500] Task message preview when copied is not copying exact content #27072

Closed

6 tasks

Ollyws mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-11-13] [$500] IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown #29878

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630

Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630

hungvu193 commented Aug 16, 2023 •

edited

Loading

melvin-bot bot commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

narefyev91 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

narefyev91 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

narefyev91 commented Aug 17, 2023

narefyev91 left a comment

pecanoro commented Aug 17, 2023

hungvu193 commented Aug 18, 2023

hungvu193 Aug 18, 2023

pecanoro commented Aug 21, 2023

narefyev91 commented Aug 21, 2023

pecanoro commented Aug 21, 2023

hungvu193 commented Aug 22, 2023

hungvu193 commented Aug 22, 2023

hungvu193 commented Aug 22, 2023 •

edited

Loading

pecanoro commented Aug 22, 2023

OSBotify commented Aug 22, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630

Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630

Conversation

hungvu193 commented Aug 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

narefyev91 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

narefyev91 commented Aug 17, 2023

hungvu193 commented Aug 17, 2023

narefyev91 commented Aug 17, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

pecanoro commented Aug 17, 2023

hungvu193 commented Aug 18, 2023

hungvu193 Aug 18, 2023

Choose a reason for hiding this comment

pecanoro commented Aug 21, 2023

narefyev91 commented Aug 21, 2023

pecanoro commented Aug 21, 2023

hungvu193 commented Aug 22, 2023

hungvu193 commented Aug 22, 2023

hungvu193 commented Aug 22, 2023 • edited Loading

pecanoro commented Aug 22, 2023

OSBotify commented Aug 22, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

hungvu193 commented Aug 16, 2023 •

edited

Loading

hungvu193 commented Aug 22, 2023 •

edited

Loading