-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enable wallet button #29573
Merged
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
af05114
feat: add enable wallet button
samh-nl b28682a
fix: disable when offline
samh-nl 4beaad4
Merge branch 'main' into feat/issue-29320
samh-nl 49ac0b5
feat: continue kyc flow
samh-nl a381ece
feat: language update
samh-nl 029b55d
feat: store source initiating kyc flow
samh-nl 1493c32
feat: update button text
samh-nl d0744c4
feat: upgrade to gold wallet requires bank account
samh-nl 924f3f5
fix: navigate to wallet upon upgrading
samh-nl 52de510
Merge branch 'main' into feat/issue-29320
samh-nl acfef2a
fix: updated ts type
samh-nl 2617784
fix: satisfy linter
samh-nl 9687887
Merge branch 'main' into feat/issue-29320
samh-nl 25bd8ae
refactor: consistent wallet activation check
samh-nl 9037c85
fix: rely on continue button press
samh-nl 68ef8c6
refactor: improve naming
samh-nl c943353
fix: require bank account to be linked wallet
samh-nl 2c00b82
Revert "fix: require bank account to be linked wallet"
samh-nl a342a05
Update src/components/KYCWall/kycWallPropTypes.js
samh-nl 660904c
Merge branch 'main' into feat/issue-29320
samh-nl 4af2029
refactor: update continueSetup due to ts migration
samh-nl bb13297
Update src/CONST.ts
samh-nl 41a6974
Merge branch 'main' into feat/issue-29320
samh-nl 0bd8f47
refactor: specify fallback route in updated method
samh-nl 15c561d
refactor: remove duplicate export
samh-nl 4385242
refactor: satisfy linter
samh-nl 3dc1a79
fix: add pending delete check
samh-nl d6e71ea
fix: make not required
samh-nl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,15 @@ | ||
import PropTypes from 'prop-types'; | ||
import _ from 'underscore'; | ||
import CONST from '../../CONST'; | ||
|
||
/** Prop types related to the Terms step of KYC flow */ | ||
export default PropTypes.shape({ | ||
/** Any error message to show */ | ||
errors: PropTypes.objectOf(PropTypes.string), | ||
|
||
/** The source that triggered the KYC wall */ | ||
source: PropTypes.oneOf(_.values(CONST.KYC_WALL_SOURCE)).isRequired, | ||
|
||
/** When the user accepts the Wallet's terms in order to pay an IOU, this is the ID of the chatReport the IOU is linked to */ | ||
chatReportID: PropTypes.string, | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #32906, we should have callled
BankAccounts.openPersonalBankAccountSetupView();
to ensure that Plaid data is cleared before Plaid view gets rendered.