feat: add enable wallet button #29573

samh-nl · 2023-10-13T15:23:25Z

Details

Present an 'Enable wallet' button that allows the user to upgrade to a Gold wallet.

Fixed Issues

$ #29320
PROPOSAL: N/A, assigning was discussed via Slack here

Tests

Preconditions: The user must not have enabled the wallet yet and must have no payment method.

Go to Settings
Go to Wallet
Press 'Add payment method'
Press 'Bank account'
Add the 'Plaid Checking' or 'Plaid Saving' bank account
Verify an 'Enable wallet' button is present in the wallet page
Press the 'Enable wallet' button
Verify the user is navigated to a page requesting additional details to be provided
Successfully complete the steps
Verify you are navigated back to the 'Wallet' page
Verify the wallet page does not show an 'Enable wallet' button, but instead a link stating 'Transfer balance'

Verify that no errors appear in the JS console

Offline tests

Preconditions: The user must not have enabled the wallet yet but must have added a payment method.

Go to Settings
Go to Wallet
Verify an 'Enable wallet' button is present in the wallet page
Verify the button is disabled

QA Steps

Preconditions: The user must not have enabled the wallet yet and must have no payment method.

Go to Settings
Go to Wallet
Press 'Add payment method'
Press 'Bank account'
Add the 'Plaid Checking' or 'Plaid Saving' bank account
Verify an 'Enable wallet' button is present in the wallet page
Press the 'Enable wallet' button
Verify the user is navigated to a page requesting additional details to be provided

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.Screen.Recording.2023-10-19.at.19.16.29.mov

Android: mWeb Chrome

mWeb.Chrome.Screen.Recording.2023-10-19.at.19.20.44.mov

iOS: Native

iOS.Native.Screen.Recording.2023-10-19.at.19.23.41.mov

iOS: mWeb Safari

mWeb.Safari.Screen.Recording.2023-10-19.at.19.27.06.mov

MacOS: Chrome / Safari

Web.Screen.Recording.2023-10-19.at.19.05.40.mov

MacOS: Desktop

Desktop.Screen.Recording.2023-10-19.at.19.32.34.mov

samh-nl · 2023-10-13T15:37:34Z

@kevinksullivan @MariaHCD

Regarding testing steps, I cannot get past the enable payments page to test the complete flow. Upon clicking 'Save & continue', the UpdatePersonalDetailsForWallet endpoint returns this error (no error is made visible in UI, though), please see below.

To verify a comment:

we'd want to redirect them to setup their bank account first.

The KYC wall currently checks if there is either a bank account or a debit card. Are both valid options for allowing upgrading the wallet or should there specifically be a bank account?

The description on the enable payments page indicates that a payment will be processed. However, the intention here seems to only be to upgrade to a gold wallet and not to initiate any payments, or am I wrong?

melvin-bot · 2023-10-15T09:01:20Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MariaHCD · 2023-10-16T10:04:56Z

Regarding testing steps, I cannot get past the enable payments page to test the complete flow. Upon clicking 'Save & continue', the UpdatePersonalDetailsForWallet endpoint returns this error (no error is made visible in UI, though), please see below.

We've got an internal fix for this: https://github.com/Expensify/Web-Expensify/pull/39205

The KYC wall currently checks if there is either a bank account or a debit card. Are both valid options for allowing upgrading the wallet or should there specifically be a bank account?

Let's restrict this to just bank accounts, debit cards are not allowed for now.

The description on the enable payments page indicates that a payment will be processed. However, the intention here seems to only be to upgrade to a gold wallet and not to initiate any payments, or am I wrong?

Could you clarify which messaging? There will be no payments initiated (automatically) but the user can now start initiating payments. Could we also change the default text in the ContinueButton to common.continue

samh-nl · 2023-10-16T10:20:05Z

I will make the adjustments shortly.

Could you clarify which messaging?

Sure, I was referring to this text (defined here). If it needs to be changed for this flow, please provide the updated text.

robertKozik · 2023-10-16T11:34:48Z

@samh-nl I assume I should wait for the fix and your adjustment before C+ review?

samh-nl · 2023-10-16T11:37:25Z

Yes, please wait indeed

MariaHCD · 2023-10-16T12:14:56Z

If it needs to be changed for this flow, please provide the updated text.

Nice catch. Going to add the Waiting for copy label on the issue along with context.

Update: #29320 (comment)

samh-nl · 2023-10-17T09:36:07Z

I've resolved conflicts and I believe it's ready to be reviewed.

There's a problem but possibly outside the scope of this PR (though I'd be happy to look into it): the Wallet page does not refresh when it transitions away from the empty state (i.e. after adding a payment method). This causes the Expensify Wallet section to not immediately appear. Please see the video below.

Screen.Recording.2023-10-17.at.11.22.00.mov

MariaHCD · 2023-10-17T12:40:50Z

This causes the Expensify Wallet section to not immediately appear.

Nice catch, I think this can be outside the scope of your PR. We are looking to redirect the user to the KYC flow after adding a PBA instead of back to the Wallet page: #29726

MariaHCD · 2023-10-17T12:49:20Z

@robertKozik feel free to start on the review for this one 🙏🏼

samh-nl · 2023-10-19T10:42:55Z

@MariaHCD with the details you mentioned, I'm unable to proceed. Is there anything that I'm missing?

Same error.

getusha · 2023-10-19T10:44:37Z

Issue have been logged with QA team for Save and Continue button is not responding https://github.com/Expensify/Web-Expensify/pull/39174#issuecomment-1765391356

I saw this, i think this is a known issue @MariaHCD

samh-nl · 2023-10-19T10:56:40Z

To skip these steps so you can check if it redirects correctly when finishing the 'enable payments' flow, you can do:

This brings you to the last step:

window.Onyx.merge('userWallet', {shouldShowWalletActivationSuccess: true});

This then upgrades your wallet to gold:

window.Onyx.merge('userWallet', {tierName: 'GOLD'});

Ideally of course we can go through the flow fully.

MariaHCD · 2023-10-19T12:56:58Z

Looking at the BE logs to see why you both are getting blocked at the additional details step.

Update: Got an internal fix - https://github.com/Expensify/Web-Expensify/pull/39314

samh-nl · 2023-10-19T13:58:28Z

Thanks, let us know when it's deployed. I can't see the status of PRs in that repository.

samh-nl · 2023-10-19T14:45:48Z

@MariaHCD Check has been added (I've defined a new method getPendingAction to make it more in line with the rest).

BUG Option to enable wallet does not appear immediately after adding a bank account. You have to go back and then to the wallet page again in order to see the enable button.
Screen.Recording.2023-10-19.at.3.21.09.PM.mov

See #29573 (comment), thoughts?

Didn't see that. Thanks for this!

Worth mentioning that an issue has already been created for this here. Perhaps that issue should be expedited? There's a couple proposals.

MariaHCD · 2023-10-19T15:05:50Z

@samh-nl @allroundexperts The fix has been deployed to staging, please let me know if you're still getting blocked at the additional details step 🙏🏼

MariaHCD · 2023-10-19T16:27:59Z

I realized you both won't be able to test steps 9 - 11 because we do not allow test activated wallets on staging. I will test on dev. @allroundexperts feel free to do the final code review, I'll do the reviewer checklist.

allroundexperts

Code wise, this looks good!

samh-nl · 2023-10-19T16:39:48Z

I've pushed a proptype fix: walletTerms.source should not be required.

walletTerms is used in the Indicator component, which is rendered prior to the user interacting with KYCWall, so walletTerms is still empty at that point.

samh-nl · 2023-10-19T17:40:32Z

I've updated the checklist and added videos for all platforms.

MariaHCD · 2023-10-19T17:43:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-19.at.8.36.59.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-19.at.8.41.08.PM.mov

Screen.Recording.2023-10-19.at.8.40.27.PM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-10-19.at.8.39.56.PM.mov

Screen.Recording.2023-10-19.at.8.39.07.PM.mov

iOS

Android

XRecorder_19102023_212302.mp4

MariaHCD · 2023-10-19T17:49:48Z

Really don't know why the reviewer checklist check is failing when I clearly have it here. I've retried it multiple times.

Found the reviewer checklist!
You completed 0 out of 54 checklist items with 54 unfinished items
Make sure you are using the most up to date checklist found here: https://raw.githubusercontent.com/Expensify/App/main/contributingGuides/REVIEWER_CHECKLIST.md
Error: PR Reviewer Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Going to merge anyway...

OSBotify · 2023-10-19T17:56:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

feat: add enable wallet button (cherry picked from commit 35920b6)

OSBotify · 2023-10-20T01:24:33Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.3.87-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

kevinksullivan · 2023-10-20T04:19:15Z

been trying to test this here but have run into unrelated issues.

OSBotify · 2023-10-20T21:06:49Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fedirjh · 2023-12-30T05:33:03Z

src/components/KYCWall/BaseKYCWall.js

+    selectPaymentMethod(paymentMethod) {
+        this.props.onSelectPaymentMethod(paymentMethod);
+        if (paymentMethod === CONST.PAYMENT_METHODS.BANK_ACCOUNT) {
+            Navigation.navigate(this.props.addBankAccountRoute);


Coming from #32906, we should have callled BankAccounts.openPersonalBankAccountSetupView(); to ensure that Plaid data is cleared before Plaid view gets rendered.

samh-nl added 2 commits October 13, 2023 16:56

feat: add enable wallet button

af05114

fix: disable when offline

b28682a

samh-nl added 2 commits October 14, 2023 21:48

Merge branch 'main' into feat/issue-29320

4beaad4

feat: continue kyc flow

49ac0b5

samh-nl marked this pull request as ready for review October 15, 2023 09:01

samh-nl requested a review from a team as a code owner October 15, 2023 09:01

melvin-bot bot removed the request for review from a team October 15, 2023 09:01

melvin-bot bot requested a review from robertKozik October 15, 2023 09:01

samh-nl mentioned this pull request Oct 15, 2023

[$500] [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [P2P Activation] [External] [CRITICAL] Update pending Wallet state to show Enable Wallet button #29320

Closed

samh-nl added 10 commits October 16, 2023 19:08

feat: language update

a381ece

feat: store source initiating kyc flow

029b55d

feat: update button text

1493c32

feat: upgrade to gold wallet requires bank account

d0744c4

fix: navigate to wallet upon upgrading

924f3f5

Merge branch 'main' into feat/issue-29320

52de510

fix: updated ts type

acfef2a

fix: satisfy linter

2617784

Merge branch 'main' into feat/issue-29320

9687887

refactor: consistent wallet activation check

25bd8ae

MariaHCD self-requested a review October 17, 2023 12:49

allroundexperts approved these changes Oct 19, 2023

View reviewed changes

melvin-bot bot requested a review from joelbettner October 19, 2023 16:30

fix: make not required

d6e71ea

MariaHCD approved these changes Oct 19, 2023

View reviewed changes

MariaHCD merged commit 35920b6 into Expensify:main Oct 19, 2023
11 of 14 checks passed

OSBotify pushed a commit that referenced this pull request Oct 20, 2023

Merge pull request #29573 from samh-nl/feat/issue-29320

ade473c

feat: add enable wallet button (cherry picked from commit 35920b6)

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

izarutskaya mentioned this pull request Oct 20, 2023

[$500] Wallet - Unable completed the wallet connection without receiving correct test data. Connecting BA via Wallet not showing transfer balance onle enable wallet displayed #30069

Closed

6 tasks

situchan mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-31] Staging is crashing when opening a chat #30109

Closed

6 tasks

This was referenced Oct 20, 2023

feat: migrate KYCWall class component to functional #28798

Merged

[Awaiting Payment][$250] Migrate BaseKYCWall.js to function component #16170

Closed

fedirjh reviewed Dec 30, 2023

View reviewed changes

fedirjh mentioned this pull request Dec 30, 2023

[$500] Wallet-Tapping "Enable wallet",add bank account page with select Chase is displayed. #32906

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add enable wallet button #29573

feat: add enable wallet button #29573

samh-nl commented Oct 13, 2023 •

edited

Loading

samh-nl commented Oct 13, 2023 •

edited

Loading

melvin-bot bot commented Oct 15, 2023

MariaHCD commented Oct 16, 2023

samh-nl commented Oct 16, 2023 •

edited

Loading

robertKozik commented Oct 16, 2023

samh-nl commented Oct 16, 2023

MariaHCD commented Oct 16, 2023 •

edited

Loading

samh-nl commented Oct 17, 2023

MariaHCD commented Oct 17, 2023

MariaHCD commented Oct 17, 2023

samh-nl commented Oct 19, 2023

getusha commented Oct 19, 2023

samh-nl commented Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023 •

edited

Loading

samh-nl commented Oct 19, 2023

samh-nl commented Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023

MariaHCD commented Oct 19, 2023

allroundexperts left a comment

samh-nl commented Oct 19, 2023 •

edited

Loading

samh-nl commented Oct 19, 2023

MariaHCD commented Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

kevinksullivan commented Oct 20, 2023

OSBotify commented Oct 20, 2023

fedirjh Dec 30, 2023

feat: add enable wallet button #29573

feat: add enable wallet button #29573

Conversation

samh-nl commented Oct 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

samh-nl commented Oct 13, 2023 • edited Loading

melvin-bot bot commented Oct 15, 2023

MariaHCD commented Oct 16, 2023

samh-nl commented Oct 16, 2023 • edited Loading

robertKozik commented Oct 16, 2023

samh-nl commented Oct 16, 2023

MariaHCD commented Oct 16, 2023 • edited Loading

samh-nl commented Oct 17, 2023

MariaHCD commented Oct 17, 2023

MariaHCD commented Oct 17, 2023

samh-nl commented Oct 19, 2023

getusha commented Oct 19, 2023

samh-nl commented Oct 19, 2023 • edited Loading

MariaHCD commented Oct 19, 2023 • edited Loading

samh-nl commented Oct 19, 2023

samh-nl commented Oct 19, 2023 • edited Loading

MariaHCD commented Oct 19, 2023

MariaHCD commented Oct 19, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

samh-nl commented Oct 19, 2023 • edited Loading

samh-nl commented Oct 19, 2023

MariaHCD commented Oct 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

MariaHCD commented Oct 19, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

kevinksullivan commented Oct 20, 2023

OSBotify commented Oct 20, 2023

fedirjh Dec 30, 2023

Choose a reason for hiding this comment

samh-nl commented Oct 13, 2023 •

edited

Loading

samh-nl commented Oct 13, 2023 •

edited

Loading

samh-nl commented Oct 16, 2023 •

edited

Loading

MariaHCD commented Oct 16, 2023 •

edited

Loading

samh-nl commented Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023 •

edited

Loading

samh-nl commented Oct 19, 2023 •

edited

Loading

samh-nl commented Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023 •

edited

Loading