-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS migration] Migrate 'RadioButtons.js' component to TypeScript #29970
[No QA][TS migration] Migrate 'RadioButtons.js' component to TypeScript #29970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<RadioButtonWithLabel | ||
key={`${item.label}-${index}`} | ||
key={item.value} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are values always unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blazejkustra Since it's radio buttons where only one option can be selected, and selecting logic is based on the item.value
isChecked={item.value === checkedValue}
, I assume so. Otherwise, there will be two same values in radio buttons, which will cause problems anyway.
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWeb & DesktopScreen.Recording.2023-10-21.at.2.32.31.AM.movMobile Web - Chrome & Mobile Web - SafariScreen.Recording.2023-10-21.at.2.30.11.AM.moviOS & AndroidScreen.Recording.2023-10-21.at.2.31.02.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests well!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25008 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Holding the PR until Money2020 (a conference) is over |
@hayata-suenaga Can we progress it since Money2020 is over? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.93-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
Details
[TS migration] Migrate 'RadioButtons.js' component to TypeScript
Fixed Issues
$ #25008
PROPOSAL: N/A
Tests
to:
Access the Idology question section inside Enable Payments Page by entering:
http://localhost:8082/enable-payments (make sure to use the port your app is running on)
To test this on other platforms (Desktop, android/ios apps), you can send the link for this to any E/App chat and click to open that
Click/Press the radio button, verify styling and behavior
Offline tests
N/A
QA Steps
Same as Tests steps.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4