Fix pressing the task report (with assignee) header opens the assignee profile page #30452

bernhardoj · 2023-10-26T16:08:14Z

Details

Pressing the task report (with assignee) header opens the assignee profile page instead of the report details page.

Fixed Issues

$ #30182
PROPOSAL: #30182 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Create 2 tasks, 1 with assignee, 1 without assignee
Open both task reports one by one
Press the header
Verify the task report details page is open

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-27.at.00.07.22.mov

Android: mWeb Chrome

Screen.Recording.2023-10-27.at.00.00.06.mov

iOS: Native

Screen.Recording.2023-10-26.at.23.58.55.mov

iOS: mWeb Safari

Screen.Recording.2023-10-26.at.23.59.40.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-26.at.23.55.02.mov

MacOS: Desktop

Screen.Recording.2023-10-26.at.23.56.56.mov

melvin-bot · 2023-10-26T16:08:19Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra

@bernhardoj There seems to be some problem with isOneOnOneChat function. Can you check any one-one chat and fix this?

bernhardoj · 2023-10-31T06:51:54Z

@shubham1206agra thanks for catching that. I totally missed testing the 1:1 chat itself.

In isOneOnOneChat, we check the length of participantsList,

App/src/libs/ReportUtils.js

Lines 3161 to 3163 in 5b5d465

    
           function isOneOnOneChat(report) { 
        
               const isChatRoomValue = lodashGet(report, 'isChatRoom', false); 
        
               const participantsListValue = lodashGet(report, 'participantsList', []);

but this value actually doesn't exist on a report, but comes from SidebarUtils.getOptionData.

App/src/libs/SidebarUtils.ts

Line 505 in 5b5d465

result.participantsList = participantPersonalDetailList;

isOneOnOneChat is currently being used in OptionRowLHN to show the user status emoji only on a 1:1 chat.

App/src/components/LHNOptionsList/OptionRowLHN.js

Line 155 in 5b5d465

    
           const isStatusVisible = Permissions.canUseCustomStatus(props.betas) && !!emojiCode && ReportUtils.isOneOnOneChat(optionItem);

This works fine because we pass the result from SidebarUtils.getOptionData which contains the participantsList instead of the report object (which is what we expected).

That's why in the status emoji PR, they have a problem where ReportUtils.isChatRoom() always returns false because they don't pass the report object, but ReportUtils.isChatRoom expects a report object to be passed on because it needs to check the chatType property which is not available from the object returned by SidebarUtils.getOptionData. This is also why they get isChatRoom property from the "report" object.

App/src/libs/ReportUtils.js

Line 3162 in 5b5d465

const isChatRoomValue = lodashGet(report, 'isChatRoom', false);

App/src/libs/SidebarUtils.ts

Line 358 in 5b5d465

result.isChatRoom = ReportUtils.isChatRoom(report);

I have fixed and tested on both 1:1 and task chat and it works fine now.

shubham1206agra · 2023-10-31T07:06:09Z

@bernhardoj Can you check that the status functionality works fine now?
Just to confirm

bernhardoj · 2023-10-31T07:17:59Z

@shubham1206agra yes, it only shows on 1:1 chat

shubham1206agra · 2023-10-31T07:19:48Z

Can you please put a short video?

bernhardoj · 2023-10-31T07:28:05Z

here you go. You can see that when the isOneOnOneChat doesn't work correctly, the status emoji will show on a non 1:1 chat.
https://github.com/Expensify/App/assets/50919443/f322d54f-8778-4b3d-bf22-9810a95a2d96

shubham1206agra · 2023-10-31T12:28:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-31.at.4.49.51.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-10-31.at.11.31.00.AM.mov

iOS: Native

Screen.Recording.2023-10-31.at.3.52.06.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-31.at.3.31.50.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-31.at.11.20.19.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-31.at.3.36.36.PM.mov

hayata-suenaga

the code looks good to me 👍

OSBotify · 2023-10-31T19:04:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T21:58:43Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:50:42Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:14:03Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:38:50Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:08:53Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

navigate to profile only if it's a 1:1 chat

f384924

bernhardoj requested a review from a team as a code owner October 26, 2023 16:08

melvin-bot bot requested review from shubham1206agra and removed request for a team October 26, 2023 16:08

bernhardoj added 2 commits October 27, 2023 00:21

move isOneOnOneChat definition up

e681d30

Merge branch 'main' into fix/30182-wrong-navigate-details

3925722

shubham1206agra suggested changes Oct 31, 2023

View reviewed changes

use the correct report data

7caa628

remove console

bd5becb

shubham1206agra approved these changes Oct 31, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga October 31, 2023 12:29

bernhardoj mentioned this pull request Oct 31, 2023

[HOLD for payment 2023-11-30] [$125] Deeplink access of user notify me page and back opens wrong page #30629

Closed

6 tasks

hayata-suenaga approved these changes Oct 31, 2023

View reviewed changes

hayata-suenaga merged commit 45da3b8 into Expensify:main Oct 31, 2023
12 checks passed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

melvin-bot bot mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-09] [$500] Task - Task assignee profile opens when clicking on the header of task report #30182

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pressing the task report (with assignee) header opens the assignee profile page #30452

Fix pressing the task report (with assignee) header opens the assignee profile page #30452

bernhardoj commented Oct 26, 2023

melvin-bot bot commented Oct 26, 2023

shubham1206agra left a comment

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

hayata-suenaga left a comment

OSBotify commented Oct 31, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

Fix pressing the task report (with assignee) header opens the assignee profile page #30452

Fix pressing the task report (with assignee) header opens the assignee profile page #30452

Conversation

bernhardoj commented Oct 26, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 26, 2023

shubham1206agra left a comment

Choose a reason for hiding this comment

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

bernhardoj commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

Reviewer Checklist

Screenshots/Videos

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 31, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023