Fix: App uses ultra-wide camera by default in Scan receipt page #30460

tienifr · 2023-10-26T17:55:15Z

Details

On mWeb, app uses ultra-wide camera by default in Scan receipt page. This PR fixes that.

Fixed Issues

$ #29484
PROPOSAL: #29484 (comment)

Tests

Preconditions:

The device has ultra-wide camera

Press FAB >> Request money >> Scan
Verify that app uses regular len camera

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Galaxy S21

media_20240225_013359_441799025417269672.mp4

Vivo 1920

667FDC37-675A-45D5-ADEC-B3FE5B386F52s.mp4

iOS: Native

iOS: mWeb Safari

iOS 17.2

74CB407C-92E5-4275-827A-22D5AAFA968Cs.mp4

iOS 15

original-4C5EE840-1F72-4192-B5EF-4D929FED6CB8.mp4

iOS: mWeb Chrome

A2C31946-E303-4BE4-91B1-CD33B7EC9C07s.mp4

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-10-27T06:24:05Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-11-02T17:38:50Z

@aimane-chnaif Can you check?

aimane-chnaif · 2023-11-02T17:40:15Z

I am struggling to test on physical android device because of new https approach

tienifr · 2023-11-02T17:46:57Z

Are you having problems with setting up the domain or granting camera permission?

If it was with the domain, testing on https://127.0.0.1:8082 is just fine (no need for dev.new.expensify.com).

On the other hand, granting permission on https connection is allowed in Chrome.

aimane-chnaif · 2023-11-02T17:49:22Z

I am not able to grant admin permission on my phone.
As per slack, it seems no one tried to run on physical android / iOS device.

aimane-chnaif · 2023-11-02T17:50:07Z

I will revert back to localhost myself and test on ngrok

aimane-chnaif · 2023-11-02T17:50:13Z

Performance Tests failing

tienifr · 2023-11-02T17:55:59Z

Hmm I can do it on my phone. I tried:

Connect by USB (enabled USB debugging)
adb reverse tcp:8082 tcp:8082

aimane-chnaif · 2023-11-02T17:56:58Z

What about iOS?

tienifr · 2023-11-02T18:09:40Z

Opps I agree that it's not possible on iOS. The failing test is new and seems unrelated. It has just been added 3 hours ago. Might be a regression.

tienifr · 2023-11-03T10:32:40Z

Or we can request AdHoc build? Reverting to localhost seems a lot of work.

aimane-chnaif · 2023-11-03T11:18:32Z

src/pages/iou/ReceiptSelector/index.js

+     * The last deviceId is of regular len camera.
+     */
+    useEffect(() => {
+        navigator.mediaDevices.getUserMedia({audio: true, video: true}).then((stream) => {


We should not ask microphone permission here

aimane-chnaif · 2023-11-05T16:03:15Z

@tienifr please attach video instead of screenshot. I am not sure how you tested web. It's buggy

tienifr · 2023-11-06T05:24:12Z

As we don't use camera on Desktop and Web, I added the check for mobile browser before requring camera permission.

Previously when I tested on Web, I had already granted the permission before so I wasn't aware of this.

aimane-chnaif · 2023-11-06T05:25:35Z

Another bug is that we should not request camera permission even on mWeb before visiting Scan tab.
Please check current behavior (production app).

aimane-chnaif · 2024-02-29T10:48:26Z

@tienifr please pull main

aimane-chnaif · 2024-02-29T11:01:30Z

@tienifr can you please re-test on all platforms after your every change?

Infinite loading on android chrome

tienifr · 2024-03-07T02:30:18Z

Still testing. It's working fine on my Samsung phone with dual cameras.

tienifr · 2024-03-13T08:01:38Z

@aimane-chnaif Can you try testing again? I conducted tests on serveral devices, both iOS and Android, with single, dual and triple cameras but they are working fine on my side. If possible, would you mind checking the console error/warning so I can debug more conveniently? Thanks!

aimane-chnaif · 2024-03-18T00:55:44Z

@tienifr I am still getting this. This issue is that no camera permission modal is prompted.
@srikarparsi can you please generate adhoc build?

srikarparsi · 2024-03-18T17:55:22Z

Yes, just ran the build.

github-actions · 2024-03-19T01:11:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/30460/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/30460/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/30460/NewExpensify.dmg	https://30460.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

srikarparsi · 2024-03-19T04:05:10Z

Builds above @aimane-chnaif

aimane-chnaif

Tested on adhoc build.
Android Chrome, iPhone Chrome, iPhone Safari.
All tests pass.

aimane-chnaif

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

iOS: mWeb Safari

mchrome.MP4

msafari.MP4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

srikarparsi

lgtm as well

srikarparsi · 2024-03-19T17:10:37Z

Thank you for covering all the cases, @aimane-chnaif, do you think you could add the videos for android and ios native, and I think this will be good to go.

aimane-chnaif · 2024-03-19T17:13:36Z

do you think you could add the videos for android and ios native, and I think this will be good to go.

That actually doesn't make sense because code change here is purely web file.
IOURequestStepScan/index.native.js isn't touched.

aimane-chnaif · 2024-03-19T17:22:58Z

I added android video. iOS native camera cannot be tested by contributors because they cannot install iOS app on physical device without provisioning profile.

srikarparsi · 2024-03-19T17:45:46Z

Awesome thanks.

That actually doesn't make sense because code change here is purely web file.

Just thought it would be better to add them so that if there are regressions later, we can more easily confirm that it's not because of this PR if they're related to native.

OSBotify · 2024-03-19T23:50:19Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-20T00:50:54Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-03-20T14:35:50Z

@tienifr @aimane-chnaif Should we test with specific device models as in the PR screenshots / videos? Or can we use any android / iOS devices with ultra-wide camera? Applause QA team does not have the exact devices like S21 and Vivo 1920.

aimane-chnaif · 2024-03-20T14:38:22Z

I think it's fine if your android device has ultra-wide camera.
This is clearly reproducible on Samsung Galaxy series so be good to test on one of those models.

tienifr · 2024-03-20T14:39:32Z

Yes as long as the device has ultra-wide camera (0.5x len).

kavimuru · 2024-03-20T18:32:03Z

Thanks @aimane-chnaif @tienifr

OSBotify · 2024-03-22T16:09:40Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits October 27, 2023 00:44

fix: app uses ultra-wide camera by default

c8692c0

Merge branch 'main' of https://github.com/tienifr/App into fix/29484

ad28dd7

tienifr marked this pull request as ready for review October 27, 2023 06:24

tienifr requested a review from a team as a code owner October 27, 2023 06:24

melvin-bot bot requested review from aimane-chnaif and removed request for a team October 27, 2023 06:24

tienifr mentioned this pull request Oct 27, 2023

[HOLD for payment 2024-03-29] [$500] mWeb - Scan - Camera on Scan tab on mweb uses ultrawide camera lens instead of regular lens #29484

Closed

6 tasks

tienifr added 5 commits October 27, 2023 16:54

useState approach

3d3bd77

Merge branch 'main' into fix/29484

01a6312

remove getUserMedia

56f99e6

close active stream

3180d32

Merge branch 'main' of https://github.com/tienifr/App into fix/29484

9db005e

aimane-chnaif reviewed Nov 3, 2023

View reviewed changes

Merge branch 'main' into fix/29484

67b92db

tienifr added 2 commits November 6, 2023 12:19

Merge branch 'main' of https://github.com/tienifr/App into fix/29484

82cdfb5

do not request permission on desktop

c853f69

tienifr added 2 commits March 13, 2024 14:15

Merge branch 'main' of https://github.com/tienifr/App into fix/29484

8b1001d

fix: stop camera usage

59c49e8

srikarparsi added the Ready To Build label Mar 18, 2024

aimane-chnaif approved these changes Mar 19, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi March 19, 2024 13:26

aimane-chnaif reviewed Mar 19, 2024

View reviewed changes

srikarparsi approved these changes Mar 19, 2024

View reviewed changes

srikarparsi merged commit d3b894d into Expensify:main Mar 19, 2024
17 of 18 checks passed

github-actions bot mentioned this pull request Mar 19, 2024

Deploy Checklist: New Expensify 2024-03-19 #38651

Closed

66 tasks

rlinoz mentioned this pull request Mar 20, 2024

[HOLD for payment 2024-03-29] mWeb/Chrome - Scan - Infinite loading instead of placeholder page after denying camera access #38696

Closed

6 tasks

pac-guerreiro mentioned this pull request Nov 19, 2024

[$250] Mobile browser camera too zoomed in and not focusing. (iPhone Pro Max 16) #51347

Open

8 tasks

Fix: App uses ultra-wide camera by default in Scan receipt page #30460

Fix: App uses ultra-wide camera by default in Scan receipt page #30460

Conversation

tienifr commented Oct 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 27, 2023

tienifr commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

tienifr commented Nov 2, 2023 • edited Loading

aimane-chnaif commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

tienifr commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

tienifr commented Nov 2, 2023 • edited Loading

tienifr commented Nov 3, 2023 • edited Loading

aimane-chnaif Nov 3, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Nov 5, 2023

tienifr commented Nov 6, 2023 • edited Loading

aimane-chnaif commented Nov 6, 2023 • edited Loading

aimane-chnaif commented Feb 29, 2024

aimane-chnaif commented Feb 29, 2024

tienifr commented Mar 7, 2024

tienifr commented Mar 13, 2024 • edited Loading

aimane-chnaif commented Mar 18, 2024

srikarparsi commented Mar 18, 2024

github-actions bot commented Mar 19, 2024

srikarparsi commented Mar 19, 2024

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

srikarparsi left a comment

Choose a reason for hiding this comment

srikarparsi commented Mar 19, 2024

aimane-chnaif commented Mar 19, 2024

aimane-chnaif commented Mar 19, 2024 • edited Loading

srikarparsi commented Mar 19, 2024

OSBotify commented Mar 19, 2024

OSBotify commented Mar 20, 2024

kavimuru commented Mar 20, 2024

aimane-chnaif commented Mar 20, 2024

tienifr commented Mar 20, 2024

kavimuru commented Mar 20, 2024

OSBotify commented Mar 22, 2024

tienifr commented Oct 26, 2023 •

edited

Loading

tienifr commented Nov 2, 2023 •

edited

Loading

tienifr commented Nov 2, 2023 •

edited

Loading

tienifr commented Nov 3, 2023 •

edited

Loading

tienifr commented Nov 6, 2023 •

edited

Loading

aimane-chnaif commented Nov 6, 2023 •

edited

Loading

tienifr commented Mar 13, 2024 •

edited

Loading

aimane-chnaif left a comment •

edited

Loading

aimane-chnaif commented Mar 19, 2024 •

edited

Loading