-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReportAction text for transactions edited in OldDot #30603
Merged
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
94e2dee
ReportAction text for transactions edited in OldDot
cristipaval 6e5d6b0
Make Lint happy.
cristipaval a7f3f38
Run prettier.
cristipaval a445ea6
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval a0a856c
Improve message for MODIFIEDEXPENSE action
cristipaval 960d00a
Add a safety check
cristipaval a4e82a8
Improve MODIFIEDEXPENSE action message
cristipaval b9b7ef4
Improve MODIFIEDEXPENSE action message
cristipaval 5190539
Remove redundancy.
cristipaval b5518be
Update function doc
cristipaval be978f9
Create reusable function
cristipaval b31ba92
Run prettier
cristipaval 376944c
Fix lint.
cristipaval b9f4243
Update src/libs/ReportUtils.js
cristipaval 16df2d9
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval bab1de4
Move logic in a separate unit
cristipaval 4ea44ee
Move policy tags logic to PolicyUtils
cristipaval b9229a7
Better naming
cristipaval 72714ad
Dry up code.
cristipaval 18d1bf0
Run prettier
cristipaval 5444abd
Fix lint errors
cristipaval 371f138
Make it a ts file.
cristipaval ceaa915
Migrate to TS
cristipaval 3bec4fd
Make Lint happy.
cristipaval b350c6b
Update src/libs/ModifiedExpenseMessage.ts
cristipaval 03931a2
Update src/libs/ModifiedExpenseMessage.ts
cristipaval 4e9a118
Update src/libs/ModifiedExpenseMessage.ts
cristipaval d855c90
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval 41f8a94
Resolve conflicts after merge.
cristipaval ceff5c1
Move policyTags to ModifiedExpenseMessage
cristipaval 57f0837
Remove unused function.
cristipaval 7dd7afb
Make lint happy.
cristipaval 1cb7f47
Better checks.
cristipaval 388962f
Update src/libs/ReportUtils.ts
cristipaval 9cc7637
Update src/libs/ModifiedExpenseMessage.ts
cristipaval 60a1493
Improve function doc.
cristipaval 8dd3c99
Add return type declaration
cristipaval 4606a46
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval 0d83c68
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval a136b74
Fix conflicts after merge
cristipaval 262cb52
RUn prettier
cristipaval cd28c61
Performance test for ModifiedExpenseMessage
cristipaval 5219b6a
Fix typecheck failures
cristipaval df90850
Unit test for ModifiedExpenseMessage
cristipaval db1f935
More tests.
cristipaval 8babd0e
One more test
cristipaval 02c09f2
One more test
cristipaval a6a28a6
3 more tests
cristipaval 27945e8
3 more tests
cristipaval 8aad9bd
Make lint happy an run prettier
cristipaval d22c617
Merge remote-tracking branch 'origin/main' into cristi_modified-expen…
cristipaval 13f7b9c
Add changes from main
cristipaval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make Lint happy.
- Loading branch information
commit 6e5d6b04de5cfe67f3179ad65cb4d0d2340e3201
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks a bit strange to have a mixture of upper/lower case and also a mix of punctuation:
The reason they don't start with a capital is because you should read it like "Cristi changed...". With the addition of these multiple fragments though, it looks off. Here is what I suggest:
changed the date to blah and the amount to blah.
(for two) andchanged the date to blah, the amount to blah, and the description to blah.
(for more than two)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented it similar to how it currently is in OldDot.
I really like your suggestion, I'll also ask in the wave4 channel if we want to change it in OldDot as well because it sounds more natural.