-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReportAction text for transactions edited in OldDot #30603
Conversation
I'll attach the screenshots soon. |
src/libs/ReportUtils.js
Outdated
if (index === 0) { | ||
return acc + value; | ||
} | ||
return `${acc}. ${value.charAt(0).toUpperCase()}${value.slice(1)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks a bit strange to have a mixture of upper/lower case and also a mix of punctuation:
The reason they don't start with a capital is because you should read it like "Cristi changed...". With the addition of these multiple fragments though, it looks off. Here is what I suggest:
- Each message should start with a lower case
- Each message should end with a period
- If there are multiple fragments, then they should be like
changed the date to blah and the amount to blah.
(for two) andchanged the date to blah, the amount to blah, and the description to blah.
(for more than two)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented it similar to how it currently is in OldDot.
I really like your suggestion, I'll also ask in the wave4 channel if we want to change it in OldDot as well because it sounds more natural.
@tgolen, I addressed your feedback. The wording is different when the user sets a field that was empty before, changes it, or deletes it. I know there's a lot of repetitive code that can be improved, but for now I want to see if how the message looks is ok, see below: |
I think that looks OK, yeah. Thanks for doing that.
…On Tue, Nov 7, 2023 at 3:37 PM Cristi Paval ***@***.***> wrote:
@tgolen <https://github.com/tgolen>, I addressed your feedback. The
wording is different when the user sets a field that was empty before,
changes it, or deletes it.
I know there's a lot of repetitive code that can be improved, but for now
I want to see if how the message looks is ok, see below:
[image: Screenshot 2023-11-08 at 00 33 54]
<https://user-images.githubusercontent.com/18078393/281200947-ecdcc9ef-7766-4168-abb6-9459c4381fd7.png>
—
Reply to this email directly, view it on GitHub
<#30603 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB5PV2QVKK23ZOZKORDYDKZYXAVCNFSM6AAAAAA6WQGPEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGMYDQMBXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ready for a new review, @tgolen. |
This is again ready for review @situchan! |
bump @situchan for review! |
I will retest and checklist today |
Please do; I want to merge this one, as conflicts are coming in. |
oldDot: this branch: staging: I noticed that date doesn't match (In above example, |
LHN last message not displaying correctly until open report first time after login. Screen.Recording.2023-12-19.at.11.26.47.AM.mov |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.15-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀
|
return ''; | ||
} | ||
const reportActionOriginalMessage = reportAction.originalMessage as ExpenseOriginalMessage | undefined; | ||
const policyID = ReportUtils.getReportPolicyID(reportAction.reportID) ?? ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MODIFIEDEXPENSE
report actions don't have the reportID
property, so we fail to get the policyTagListName
here. This caused #33493.
This is part of the Backward compatibility project.
Details
In OldDot, it's possible to edit multiple fields at once on transactions. This PR adds support for the
MODIFIEDEXPENSE
report actions that have multiple changes in theoriginalMessage
.Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/327756
Tests
admin
account has a free workspace and adds theemployee
as a memberemployee
creates a money request in workspace chatadmin
signs into OldDot and opens the newly created expense reportadmin
edits multiple fields of the transaction (eg. price, category and description)admin
sees a new report action in the report history in OldDot, describing the changesadmin
sees a new report action in the transaction thread in NewDot, describing the changesemployee
sees a new report action in the transaction thread in NewDot, describing the changesOffline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop