[CP Staging] Move View wrapper to AttachmentViewPdf #31130

Beamanator · 2023-11-09T15:22:21Z

Details

Reverting what was done in #30995, using @mollfpr 's suggestion here

Let's make sure this solves all cases before we move forward!

Fixed Issues

$ #31103
$ #31080
$ #30977

Tests

Password-protected PDFs:

Launch app
Tap on a report
Tap plus icon near compose and select "Add attachment"
Select any password protected pdf from "Choose document"
Verify Password Protected Preview is shown.
Enter the password.
Scroll the pdf up and down.
Verify the pdf can be scrolled.

Concierge Avatar:

Open NewDot
Log in with any account
Select Concierge
Click on avatar
Verify Avatar is centered
Do the same with multiple other avatars, verifying they're centered

Attaching video files / docx files:

Open NewDot
Log in with any Gmail account.
Open 1:1 conversation, click on the + button in the compose box.
Click on add attachment.
Upload docx or mp4.
Verify The file name is placed on the center of the preview page, if you add docx and mp4 attachments.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-09T15:22:26Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-11-09T15:26:30Z

I can help to review this.

Beamanator · 2023-11-09T15:29:32Z

Aah that would be great @mollfpr - the more eyes the better 🙏

mollfpr · 2023-11-09T16:32:21Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

31130.iOS.-.Password.protected.mp4

31130.iOS.-.Concierge.avatar.mp4

31130.iOS.-.Attaching.video.mp4

iOS: mWeb Safari

31130.mWeb-Safari.-.Concierge.avatar.mp4

31130.mWeb-Safari.-.Attaching.docx.mp4

MacOS: Chrome / Safari

31130.Web.-.Concierge.avatar.mp4

31130.Web.-.Attaching.video.mp4

31130.Web.-.Password.protected.mp4

MacOS: Desktop

31130.Desktop.-.Concierge.avatar.mp4

31130.Desktop.-.Attaching.video.mp4

31130.Desktop.-.Password.protected.mp4

mollfpr · 2023-11-09T16:36:57Z

@Beamanator The changes look good, and I did the test on some of the platforms, but it's already late for me. 🙏

Santhosh-Sellavel · 2023-11-09T16:40:01Z

Thanks for the videos, @mollfpr.

I will add the missing video for the other platforms you missed & complete the checklist.

I'm already on it.

Santhosh-Sellavel · 2023-11-09T17:20:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-09.at.10.42.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-09.at.10.40.42.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-11-09.at.10.47.04.PM.mov

MacOS: Chrome / Safari & MacOS: Desktop

Screen.Recording.2023-11-09.at.10.34.29.PM.mov

Beamanator · 2023-11-09T17:32:25Z

Amazing, thanks for the great work both of you! @Santhosh-Sellavel it looks like there's 1 checkbox left, are you close to completing that one?

Santhosh-Sellavel · 2023-11-09T17:34:54Z

Stuck with pod install on iOS alone

Santhosh-Sellavel · 2023-11-09T17:36:07Z

It's been more than 30 minutes on it. Didn't test on iOS native alone, other wise all good here!

Beamanator · 2023-11-09T17:39:08Z

Aah ouch, I need to get my iOS simulator working with Sonoma some day soon 🙃 Thanks @Santhosh-Sellavel 🙏

Santhosh-Sellavel · 2023-11-09T17:40:46Z

I'll just go ahead and approve as @mollfpr already tested and added videos here

Santhosh-Sellavel

LGTM!

melvin-bot · 2023-11-09T17:41:46Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-11-09T17:51:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Move View wrapper to AttachmentViewPdf (cherry picked from commit 9e02e96)

Beamanator · 2023-11-09T20:09:54Z

I believe this successfully made it to staging - https://github.com/Expensify/App/actions/runs/6815566820

OSBotify · 2023-11-10T15:42:27Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T22:13:00Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:56:16Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Move View wrapper to AttachmentViewPdf

41d71ab

Beamanator self-assigned this Nov 9, 2023

Beamanator requested a review from a team as a code owner November 9, 2023 15:22

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team November 9, 2023 15:22

Beamanator mentioned this pull request Nov 9, 2023

fix: pdf send attachment regression #30995

Merged

59 tasks

... you saw nothing ...

595bb78

Santhosh-Sellavel approved these changes Nov 9, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro November 9, 2023 17:41

pecanoro approved these changes Nov 9, 2023

View reviewed changes

Beamanator changed the title ~~Move View wrapper to AttachmentViewPdf~~ [CP Staging] Move View wrapper to AttachmentViewPdf Nov 9, 2023

pecanoro merged commit 9e02e96 into main Nov 9, 2023
14 of 16 checks passed

pecanoro deleted the beaman-reFixPdfAttachmentModal branch November 9, 2023 17:47

OSBotify pushed a commit that referenced this pull request Nov 9, 2023

Merge pull request #31130 from Expensify/beaman-reFixPdfAttachmentModal

1788f59

[CP Staging] Move View wrapper to AttachmentViewPdf (cherry picked from commit 9e02e96)

OSBotify mentioned this pull request Nov 9, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Beamanator mentioned this pull request Nov 9, 2023

[HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Android - Attachments-Password protected file preview is not shown #30977

Closed

6 tasks

lanitochka17 mentioned this pull request Nov 10, 2023

[$1000] mWeb - Cannot open protected PDF in chat view while logged into an old account #31166

Closed

6 tasks

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Move View wrapper to AttachmentViewPdf #31130

[CP Staging] Move View wrapper to AttachmentViewPdf #31130

Beamanator commented Nov 9, 2023 •

edited

Loading

melvin-bot bot commented Nov 9, 2023

mollfpr commented Nov 9, 2023

Beamanator commented Nov 9, 2023

mollfpr commented Nov 9, 2023 •

edited

Loading

mollfpr commented Nov 9, 2023 •

edited

Loading

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023 •

edited

Loading

Beamanator commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Beamanator commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel left a comment

melvin-bot bot commented Nov 9, 2023

OSBotify commented Nov 9, 2023

Beamanator commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

[CP Staging] Move View wrapper to AttachmentViewPdf #31130

[CP Staging] Move View wrapper to AttachmentViewPdf #31130

Conversation

Beamanator commented Nov 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 9, 2023

mollfpr commented Nov 9, 2023

Beamanator commented Nov 9, 2023

mollfpr commented Nov 9, 2023 • edited Loading

Screenshots/Videos

mollfpr commented Nov 9, 2023 • edited Loading

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Beamanator commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Beamanator commented Nov 9, 2023

Santhosh-Sellavel commented Nov 9, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 9, 2023

OSBotify commented Nov 9, 2023

Beamanator commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

Beamanator commented Nov 9, 2023 •

edited

Loading

mollfpr commented Nov 9, 2023 •

edited

Loading

mollfpr commented Nov 9, 2023 •

edited

Loading

Santhosh-Sellavel commented Nov 9, 2023 •

edited

Loading