[TS migration] Migrate 'Reactions' component to TypeScript #32929

VickyStash · 2023-12-12T15:53:11Z

Details

[TS migration] Migrate 'Reactions' component to TypeScript

Fixed Issues

$ #25153
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the app using account A.
Go to chat with user B. Send any message.
WEB/DESKTOP: Hover over the message, the context menu should appear in the top right corner of the message.
3.1 Make sure it looks the same way as before and has quick reaction options in the list.
3.2 When you hover over the reaction you should see a small tooltip with reaction info.
3.3 Click on any reaction button in the menu , "👍" for example. The "👍" gets added as a reaction to the message.
When pressing the "👍" in the menu again, the reaction should be removed.
Right press (on web/desktop), or long-press (mobile) the message -> the context menu should be opened. It should have several quick reactions and Add Reactions button at the top.
4.1 Add several reactions using quick reactions and Add Reactions button.
Make sure reactions to the message look ok.
Login from account B on another device. Open the same chat and make sure reactions look the same way. Add a reaction to the same message, make sure it looks ok.
Go back to using account B.
WEB/DESKTOP: Hover over the reaction bubble of the message, you should see a tooltip with the info about users who left the reactions, make sure it looks the same way as before.
MOBILE: Long press the reaction bubble of the message, you should see a popup with the info about users who left the reactions, make sure it looks the same way as before.
Press Add Reactions button in the bottom of the message -> Change default skin tone -> Select another skin tone.
Use reactions with another skin tone, make sure it works ok.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

# Conflicts: # src/components/Reactions/AddReactionBubble.tsx # src/components/Reactions/EmojiReactionBubble.js

# Conflicts: # src/components/Reactions/AddReactionBubble.tsx # src/components/Reactions/EmojiReactionBubble.js # src/components/Reactions/MiniQuickEmojiReactions.tsx # src/components/Reactions/QuickEmojiReactions/BaseQuickEmojiReactions.js # src/components/Reactions/ReactionTooltipContent.js # src/components/Reactions/ReportActionItemEmojiReactions.tsx

src/components/Reactions/QuickEmojiReactions/types.ts

# Conflicts: # src/components/Reactions/AddReactionBubble.tsx # src/components/Reactions/QuickEmojiReactions/index.js # src/components/Reactions/QuickEmojiReactions/index.native.tsx # src/libs/EmojiTrie.ts # src/libs/EmojiUtils.ts # src/libs/actions/EmojiPickerAction.ts

blazejkustra

LGTM, just couple questions

src/components/Reactions/MiniQuickEmojiReactions.tsx

src/components/Reactions/QuickEmojiReactions/index.native.tsx

src/components/Reactions/QuickEmojiReactions/index.tsx

blazejkustra · 2024-01-02T14:54:08Z

assets/emojis/index.ts

@@ -26,10 +29,10 @@ const emojiCodeTableWithSkinTones = emojis.reduce<EmojiTable>((prev, cur) => {
    return newValue;
 }, {});

-const localeEmojis = {
+const localeEmojis: LocaleEmojis = {


Why was this needed?

Otherwise, I had a TS error in this function. I guess it also could be resolved with assertion/additional conditions if you think type update isn't a good idea

It's fine as you coded 👍

melvin-bot · 2024-01-03T12:58:18Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # assets/emojis/index.ts # src/libs/EmojiTrie.ts # src/libs/EmojiUtils.ts # src/libs/actions/EmojiPickerAction.ts # src/pages/home/ReportScreenContext.ts # src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

fedirjh · 2024-01-04T16:19:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-01-04.at.18.26.43.mp4

Android: mWeb Chrome

CleanShot.2024-01-04.at.18.43.02.mp4

iOS: Native

CleanShot.2024-01-04.at.17.21.32.mp4

iOS: mWeb Safari

CleanShot.2024-01-04.at.17.09.02.mp4

MacOS: Chrome / Safari

CleanShot.2024-01-04.at.17.06.10.mp4

MacOS: Desktop

CleanShot.2024-01-04.at.18.55.32.mp4

fedirjh · 2024-01-04T18:32:46Z

src/types/onyx/ReportActionReactions.ts

@@ -24,7 +24,7 @@ type ReportActionReaction = {
    users: UsersReactions;

    /** Is this action pending? */
-    pendingAction?: OnyxCommon.PendingAction;
+    pendingAction: OnyxCommon.PendingAction;


pendingAction doesn’t seems like a required prop.

@fedirjh Right, I've prepared a follow-up PR

@VickyStash Thanks for raising a quick PR.

fedirjh

Looking good and tests well.

melvin-bot · 2024-01-04T18:38:35Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25153 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-01-04T22:57:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:36:03Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-10T06:03:18Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

VickyStash added 14 commits December 12, 2023 16:51

[TS migration] Migrate 'Reactions' component

e59d87f

Merge branch 'main' into ts-migration/reactions-component

03eb9cd

# Conflicts: # src/components/Reactions/AddReactionBubble.tsx # src/components/Reactions/EmojiReactionBubble.js

Fix after merging main

2374486

Minor code improvements

2b4037d

Updates to follow main branch

a2134b2

Remove TODO related to PersonalDetailsUtils

d4f7ba8

Type improvements

a21eef6

Add ReactionListEvent and ReactionListAnchor types

78d61d7

Undo unnecessary updates in withCurrentUserPersonalDetails HOC

6e94929

Get rid of extra emoji types

e5663f1

Add LocaleEmojis type

e1670ca

Update type imports

30ea4d5

Merge branch 'main' into ts-migration/reactions-component

2c907a1

fabioh8010 reviewed Dec 21, 2023

View reviewed changes

src/components/Reactions/QuickEmojiReactions/types.ts Outdated Show resolved Hide resolved

Update TODO comment

60c58b0

fabioh8010 approved these changes Dec 21, 2023

View reviewed changes

VickyStash added 4 commits December 22, 2023 09:09

Merge branch 'main' into ts-migration/reactions-component

52c37de

TS fixes after merging main

0137c9a

Fix TS issues after merging main

0ae9f50

blazejkustra reviewed Jan 2, 2024

View reviewed changes

VickyStash added 2 commits January 2, 2024 16:42

Merge branch 'main' into ts-migration/reactions-component

115286e

Update MiniQuickEmojiReactionsOnyxProps type

8ed6017

blazejkustra approved these changes Jan 3, 2024

View reviewed changes

VickyStash marked this pull request as ready for review January 3, 2024 12:58

VickyStash requested a review from a team as a code owner January 3, 2024 12:58

melvin-bot bot requested review from fedirjh and removed request for a team January 3, 2024 12:58

VickyStash added 2 commits January 4, 2024 09:57

Fix lint errors

1d4010e

fedirjh reviewed Jan 4, 2024

View reviewed changes

fedirjh approved these changes Jan 4, 2024

View reviewed changes

AndrewGable approved these changes Jan 4, 2024

View reviewed changes

AndrewGable merged commit b03fe67 into Expensify:main Jan 4, 2024
18 checks passed

VickyStash mentioned this pull request Jan 8, 2024

[No QA] [TS migration] Follow-up: update ReportActionReaction type #34095

Merged

50 tasks

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

melvin-bot bot mentioned this pull request Jan 10, 2024

[HOLD for payment 2024-01-17] [TS migration] Migrate 'Reactions' component to TypeScript #25153

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'Reactions' component to TypeScript #32929

[TS migration] Migrate 'Reactions' component to TypeScript #32929

VickyStash commented Dec 12, 2023 •

edited

Loading

blazejkustra left a comment

blazejkustra Jan 2, 2024

VickyStash Jan 2, 2024

blazejkustra Jan 3, 2024

melvin-bot bot commented Jan 3, 2024

fedirjh commented Jan 4, 2024 •

edited

Loading

fedirjh Jan 4, 2024

VickyStash Jan 8, 2024

fedirjh Jan 8, 2024

fedirjh left a comment

melvin-bot bot commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

[TS migration] Migrate 'Reactions' component to TypeScript #32929

[TS migration] Migrate 'Reactions' component to TypeScript #32929

Conversation

VickyStash commented Dec 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra Jan 2, 2024

Choose a reason for hiding this comment

VickyStash Jan 2, 2024

Choose a reason for hiding this comment

blazejkustra Jan 3, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Jan 3, 2024

fedirjh commented Jan 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh Jan 4, 2024

Choose a reason for hiding this comment

VickyStash Jan 8, 2024

Choose a reason for hiding this comment

fedirjh Jan 8, 2024

Choose a reason for hiding this comment

fedirjh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

VickyStash commented Dec 12, 2023 •

edited

Loading

fedirjh commented Jan 4, 2024 •

edited

Loading