[TS migration] Migrate 'OptionRow.js' component to TypeScript #33077

VickyStash · 2023-12-14T15:52:57Z

Details

[TS migration] Migrate 'OptionRow.js' component to TypeScript

Fixed Issues

$ #25118
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

First case:

Click FAB and select Start chat
Make sure the list of users, names, and avatars look as expected.
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes.
[WEB AND DESKTOP] Verify the hover effect over the Option Row. When hovering over Add to group button, the hover state should be removed.
Toggle select status by clicking Add to group or checkbox button and verify that the button is changed correctly.

Second case:

Click FAB and select Request money
Go to Manual section, enter any amount of money and press Next. You should see the list of users and workspaces.
Make sure the list looks as expected, all names and avatars look correct.
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes.
[WEB AND DESKTOP] Verify the hover effect over the Option Row. When hovering over Split button, the hover state should be removed.
Toggle select status by clicking Split or checkbox button and verify that the button is changed correctly.

Third case:

Open any room.
Press on the room header to open room details.
Click on members.
Make sure the members list look as expected.
[WEB AND DESKTOP] Verify the hover effect over the Option Row works as expected, and the tooltip appears if you hover over the user name.

Storybook:

Open Storybook
Select OptionRow component and make sure it looks ok.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android.web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios.web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

Storybook

src/components/OptionRow.tsx

src/libs/ReportUtils.ts

src/styles/utils/index.ts

src/components/Icon/index.tsx

# Conflicts: # src/components/Icon/index.tsx # src/languages/es.ts

# Conflicts: # src/components/OptionRow.tsx

src/components/Pressable/GenericPressable/types.ts

src/components/OptionRow.tsx

# Conflicts: # src/components/Icon/index.tsx # src/components/OptionRow.tsx

melvin-bot · 2023-12-20T07:57:27Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/components/OptionRow.tsx

situchan · 2023-12-27T05:32:14Z

src/components/OptionRow.tsx

@@ -326,7 +318,7 @@ export default React.memo(
        prevProps.showSelectedState === nextProps.showSelectedState &&
        prevProps.highlightSelected === nextProps.highlightSelected &&
        prevProps.showTitleTooltip === nextProps.showTitleTooltip &&
-        !_.isEqual(prevProps.option.icons, nextProps.option.icons) &&
+        !lodashIsEqual(prevProps.option.icons, nextProps.option.icons) &&


Please fix conflict.
!lodashIsEqual > lodashIsEqual to fix #33353

@situchan Done, thank you!

# Conflicts: # src/components/OptionRow.tsx

situchan · 2023-12-29T07:38:38Z

Seems like recent regression - default avatar not showing at all on native. Also happening on main so out of scope

Edit: commented on offending PR

situchan · 2023-12-29T07:49:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan

melvin-bot · 2023-12-29T08:03:14Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25118 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mountiny

No comments for the code, this is highly used component so please be on a look out for any regressions cc @situchan

OSBotify · 2023-12-29T21:11:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-02T23:51:22Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:53:58Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:18:48Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:16:15Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

VickyStash added 3 commits December 14, 2023 16:44

[TS migration] Migrate 'OptionRow.js' component

f312cb2

Minor code improvement

6aaadf3

Update hoveredStyle check

a695370

fabioh8010 reviewed Dec 15, 2023

View reviewed changes

src/components/OptionRow.tsx Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/styles/utils/index.ts Outdated Show resolved Hide resolved

VickyStash added 2 commits December 15, 2023 10:30

Add CustomIcon type

74189c4

Add new word to translation vocabulary

825ba76

pasyukevich reviewed Dec 15, 2023

View reviewed changes

src/components/Icon/index.tsx Outdated Show resolved Hide resolved

fabioh8010 approved these changes Dec 15, 2023

View reviewed changes

VickyStash added 3 commits December 18, 2023 08:32

Merge branch 'main' into ts-migration/optionRow-component

ad17956

# Conflicts: # src/components/Icon/index.tsx # src/languages/es.ts

Merge branch 'main' into ts-migration/optionRow-component

258a9ba

# Conflicts: # src/components/OptionRow.tsx

Add comments

2def510

blazejkustra approved these changes Dec 19, 2023

View reviewed changes

src/components/Pressable/GenericPressable/types.ts Outdated Show resolved Hide resolved

src/components/OptionRow.tsx Show resolved Hide resolved

VickyStash added 2 commits December 19, 2023 14:54

Update option text typing

3628384

Merge branch 'main' into ts-migration/optionRow-component

215ea09

# Conflicts: # src/components/Icon/index.tsx # src/components/OptionRow.tsx

VickyStash marked this pull request as ready for review December 20, 2023 07:57

VickyStash requested a review from a team as a code owner December 20, 2023 07:57

melvin-bot bot requested review from situchan and removed request for a team December 20, 2023 07:57

Merge branch 'main' into ts-migration/optionRow-component

b1e3247

# Conflicts: # src/components/OptionRow.tsx

situchan reviewed Dec 27, 2023

View reviewed changes

VickyStash added 3 commits December 27, 2023 11:09

Merge branch 'main' into ts-migration/optionRow-component

94d36d6

# Conflicts: # src/components/OptionRow.tsx

Use IconAsset type

876dc9c

Merge branch 'main' into ts-migration/optionRow-component

f178a82

# Conflicts: # src/components/OptionRow.tsx

situchan mentioned this pull request Dec 29, 2023

Migrate Icon and FloatingActionButton to function component #33336

Merged

50 tasks

situchan approved these changes Dec 29, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini December 29, 2023 08:04

rayane-djouah mentioned this pull request Dec 29, 2023

[CP Staging] fix default avatar not showing on native #33752

Merged

50 tasks

mountiny assigned VickyStash Dec 29, 2023

mountiny approved these changes Dec 29, 2023

View reviewed changes

mountiny merged commit 38bb94e into Expensify:main Dec 29, 2023
18 checks passed

github-actions bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

kbecciv mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-25] [$500] Storybook - "Page not found.." appears when navigate to Storybook link from chat #33934

Closed

6 tasks

melvin-bot bot mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-11] [TS migration] Migrate 'OptionRow.js' component to TypeScript #25118

Closed

lanitochka17 mentioned this pull request Jan 5, 2024

Room - Member avatar changes after being invited to the room #34000

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'OptionRow.js' component to TypeScript #33077

[TS migration] Migrate 'OptionRow.js' component to TypeScript #33077

VickyStash commented Dec 14, 2023 •

edited

Loading

melvin-bot bot commented Dec 20, 2023

situchan Dec 27, 2023

VickyStash Dec 27, 2023

situchan commented Dec 29, 2023 •

edited

Loading

situchan commented Dec 29, 2023

situchan left a comment

melvin-bot bot commented Dec 29, 2023

mountiny left a comment

OSBotify commented Dec 29, 2023

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

[TS migration] Migrate 'OptionRow.js' component to TypeScript #33077

[TS migration] Migrate 'OptionRow.js' component to TypeScript #33077

Conversation

VickyStash commented Dec 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 20, 2023

situchan Dec 27, 2023

Choose a reason for hiding this comment

VickyStash Dec 27, 2023

Choose a reason for hiding this comment

situchan commented Dec 29, 2023 • edited Loading

situchan commented Dec 29, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 29, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 29, 2023

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

VickyStash commented Dec 14, 2023 •

edited

Loading

situchan commented Dec 29, 2023 •

edited

Loading