Select members from ONYX on page open, remove them on unmounting #34028

BhuvaneshPatil · 2024-01-05T14:39:11Z

Details

When we select users for adding to workspace and go to invite message page and refresh it, after going back to invite page those users are not selected. This PR addresses that issue by setting the selected options from Onyx.

Fixed Issues

$ #32839
PROPOSAL: #32839 (comment)

Tests

Go to any workspace setting page
Then members, invite
select few options and click on next
Refresh the page
Go back, verify if previously selected options are still selected

Further more -
6. Go back to members page
7. click on invite
8. Verify if the users are not selected

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-10.at.11.36.28.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-09.at.8.23.08.AM.mov

iOS: Native

Screen.Recording.2024-01-08.at.10.43.37.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-08.at.10.49.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-08.at.10.40.20.PM.mov

MacOS: Desktop

https://github.com/Expensify/App/assets/27822551/f97745f7-a6c6-458b-b09d-1ae15b85b2f2

melvin-bot · 2024-01-05T14:39:17Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BhuvaneshPatil · 2024-01-09T03:02:49Z

@allroundexperts Can you continue the review, I am facing some issues building android app from last two days.

BhuvaneshPatil · 2024-01-10T18:10:06Z

@allroundexperts all yours

allroundexperts · 2024-01-12T18:41:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-13.at.2.35.43.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-13.at.2.34.11.AM.mov

iOS: Native

Screen.Recording.2024-01-13.at.2.32.38.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-13.at.2.08.14.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-13.at.2.03.55.AM.mov

MacOS: Desktop

Screen.Recording.2024-01-13.at.2.06.48.AM.mov

allroundexperts · 2024-01-12T21:46:16Z

BUG

Select some members on the invite members page of workspace.
Reload the page.
After the reload, page keeps on loading forever.

Screen.Recording.2024-01-13.at.2.44.09.AM.mov

@BhuvaneshPatil I think this is not related to your PR but can you please double check?

BhuvaneshPatil · 2024-01-13T03:50:53Z

@allroundexperts I checked on v1.4.24-7
The issue exist

Screen.Recording.2024-01-13.at.9.18.32.AM.mov

allroundexperts

Looks good!

OSBotify · 2024-01-15T12:20:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-18T03:13:17Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2024-05-20T07:31:40Z

src/pages/workspace/WorkspaceInvitePage.js

+                return;
+            }
+            newSelectedOptions.push({...detailsMap[login], isSelected: true});
+        });


This logic caused minor regression.
More details about the root cause: #36350 (comment)

Select members from ONYS on page open, remove them on unmounting

92f51e2

BhuvaneshPatil requested a review from a team as a code owner January 5, 2024 14:39

melvin-bot bot requested review from allroundexperts and removed request for a team January 5, 2024 14:39

BhuvaneshPatil changed the title ~~Select members from ONYS on page open, remove them on unmounting~~ Select members from ONYX on page open, remove them on unmounting Jan 6, 2024

allroundexperts approved these changes Jan 13, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval January 13, 2024 19:27

cristipaval approved these changes Jan 15, 2024

View reviewed changes

cristipaval merged commit bea694d into Expensify:main Jan 15, 2024
16 of 19 checks passed

github-actions bot mentioned this pull request Jan 17, 2024

Deploy Checklist: New Expensify 2024-01-17 #34621

Closed

58 tasks

melvin-bot bot mentioned this pull request Jan 18, 2024

[Awaiting checklist completion] [$500] Workspace - Selected users to invite turn deselected when refresh Add message page #32839

Closed

6 tasks

bernhardoj mentioned this pull request Feb 13, 2024

[$500] Unchecked users persist as checked when inviting others #36350

Closed

6 tasks

situchan reviewed May 20, 2024

View reviewed changes

bernhardoj mentioned this pull request Jun 27, 2024

Fix member is unselected when refresh at workspace invite message page and go back #44189

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select members from ONYX on page open, remove them on unmounting #34028

Select members from ONYX on page open, remove them on unmounting #34028

BhuvaneshPatil commented Jan 5, 2024 •

edited

Loading

melvin-bot bot commented Jan 5, 2024

BhuvaneshPatil commented Jan 9, 2024

BhuvaneshPatil commented Jan 10, 2024

allroundexperts commented Jan 12, 2024 •

edited

Loading

allroundexperts commented Jan 12, 2024

BhuvaneshPatil commented Jan 13, 2024

allroundexperts left a comment

OSBotify commented Jan 15, 2024

OSBotify commented Jan 18, 2024

situchan May 20, 2024

Select members from ONYX on page open, remove them on unmounting #34028

Select members from ONYX on page open, remove them on unmounting #34028

Conversation

BhuvaneshPatil commented Jan 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 5, 2024

BhuvaneshPatil commented Jan 9, 2024

BhuvaneshPatil commented Jan 10, 2024

allroundexperts commented Jan 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Jan 12, 2024

BhuvaneshPatil commented Jan 13, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 15, 2024

OSBotify commented Jan 18, 2024

situchan May 20, 2024

Choose a reason for hiding this comment

BhuvaneshPatil commented Jan 5, 2024 •

edited

Loading

allroundexperts commented Jan 12, 2024 •

edited

Loading